diff options
| author | Herb Lewis <herb@samba.org> | 2004-01-14 22:53:50 +0000 |
|---|---|---|
| committer | Herb Lewis <herb@samba.org> | 2004-01-14 22:53:50 +0000 |
| commit | a363e5d8c549861329506bd87c11d82ace5520e5 (patch) | |
| tree | 1208108b6f0808a327cd785b1bc229a0a1f3c8ae | |
| parent | 40b7d863dc246ea23ff3d9cdc167f1fb96166e1d (diff) | |
| download | samba-a363e5d8c549861329506bd87c11d82ace5520e5.tar.gz samba-a363e5d8c549861329506bd87c11d82ace5520e5.tar.xz samba-a363e5d8c549861329506bd87c11d82ace5520e5.zip | |
source/rpc_parse/parse_prs.c ZERO_STRUCTP(ps) not needed as it is done
in prs_init now
testsuite/printing/psec.c cannot do a prs_mem_free() when tdb_prs_fetch fails
as the prs structure has not been initialized
| -rw-r--r-- | source/rpc_parse/parse_prs.c | 1 | ||||
| -rw-r--r-- | testsuite/printing/psec.c | 7 |
2 files changed, 5 insertions, 3 deletions
diff --git a/source/rpc_parse/parse_prs.c b/source/rpc_parse/parse_prs.c index 58652fa0c56..0e5a25fe8c2 100644 --- a/source/rpc_parse/parse_prs.c +++ b/source/rpc_parse/parse_prs.c @@ -1307,7 +1307,6 @@ int tdb_prs_fetch(TDB_CONTEXT *tdb, char *keystr, prs_struct *ps, TALLOC_CTX *me if (!dbuf.dptr) return -1; - ZERO_STRUCTP(ps); prs_init(ps, 0, mem_ctx, UNMARSHALL); prs_give_memory(ps, dbuf.dptr, dbuf.dsize, True); diff --git a/testsuite/printing/psec.c b/testsuite/printing/psec.c index 9d38b9b10ae..7ba40b18a31 100644 --- a/testsuite/printing/psec.c +++ b/testsuite/printing/psec.c @@ -195,8 +195,11 @@ int psec_getsec(char *printer) if (tdb_prs_fetch(tdb, keystr, &ps, mem_ctx) != 0) { printf("error fetching descriptor for printer %s\n", printer); - result = 1; - goto done; + /* cannot do a prs_mem_free() when tdb_prs_fetch fails */ + /* as the prs structure has not been initialized */ + tdb_close(tdb); + talloc_destroy(mem_ctx); + return 1; } /* Unpack into security descriptor buffer */ |