diff options
| author | Luke Leighton <lkcl@samba.org> | 1999-11-19 02:05:19 +0000 |
|---|---|---|
| committer | Luke Leighton <lkcl@samba.org> | 1999-11-19 02:05:19 +0000 |
| commit | 9795e5948c698115e34c28993cdb82ba31377f5d (patch) | |
| tree | 136064ca75e9162c2c803a30692a32670620a099 | |
| parent | 172601b84ae94044b27ded917d4e0e21e47a5a66 (diff) | |
| download | samba-9795e5948c698115e34c28993cdb82ba31377f5d.tar.gz samba-9795e5948c698115e34c28993cdb82ba31377f5d.tar.xz samba-9795e5948c698115e34c28993cdb82ba31377f5d.zip | |
nt5rc2 falling over because the LsaQueryInfoPolicy() response _must_
have the string max length = string length + 1.
if not, then it gets its knickers in a twist over whether the string
is NULL-terminated or not.
four days.
four days i spent on this one.
| -rw-r--r-- | source/lsarpcd/srv_lsa.c | 3 | ||||
| -rw-r--r-- | source/rpc_parse/parse_lsa.c | 1 | ||||
| -rw-r--r-- | source/rpc_server/srv_lsa.c | 3 |
3 files changed, 5 insertions, 2 deletions
diff --git a/source/lsarpcd/srv_lsa.c b/source/lsarpcd/srv_lsa.c index 7bc5841cfc9..b1761219afc 100644 --- a/source/lsarpcd/srv_lsa.c +++ b/source/lsarpcd/srv_lsa.c @@ -88,14 +88,15 @@ static void make_dom_query(DOM_QUERY *d_q, char *dom_name, DOM_SID *dom_sid) fstring sid_str; int domlen = strlen(dom_name); + d_q->uni_dom_str_len = (domlen+1) * 2; d_q->uni_dom_max_len = domlen * 2; - d_q->uni_dom_str_len = domlen * 2; d_q->buffer_dom_name = domlen != 0 ? 1 : 0; /* domain buffer pointer */ d_q->buffer_dom_sid = dom_sid != NULL ? 1 : 0; /* domain sid pointer */ /* this string is supposed to be character short */ make_unistr2(&(d_q->uni_domain_name), dom_name, domlen); + d_q->uni_domain_name.uni_max_len++; sid_to_string(sid_str, dom_sid); make_dom_sid2(&(d_q->dom_sid), dom_sid); diff --git a/source/rpc_parse/parse_lsa.c b/source/rpc_parse/parse_lsa.c index 57c22e88cbd..596b1cb0457 100644 --- a/source/rpc_parse/parse_lsa.c +++ b/source/rpc_parse/parse_lsa.c @@ -105,6 +105,7 @@ static BOOL lsa_io_dom_r_ref(char *desc, DOM_R_REF *r_r, prs_struct *ps, int de { slprintf(t, sizeof(t) - 1, "dom_ref[%d] ", i); smb_io_unistr2(t, &(r_r->ref_dom[n].uni_dom_name), True, ps, depth); /* domain name unicode string */ + prs_align(ps); n++; } diff --git a/source/rpc_server/srv_lsa.c b/source/rpc_server/srv_lsa.c index 7bc5841cfc9..b1761219afc 100644 --- a/source/rpc_server/srv_lsa.c +++ b/source/rpc_server/srv_lsa.c @@ -88,14 +88,15 @@ static void make_dom_query(DOM_QUERY *d_q, char *dom_name, DOM_SID *dom_sid) fstring sid_str; int domlen = strlen(dom_name); + d_q->uni_dom_str_len = (domlen+1) * 2; d_q->uni_dom_max_len = domlen * 2; - d_q->uni_dom_str_len = domlen * 2; d_q->buffer_dom_name = domlen != 0 ? 1 : 0; /* domain buffer pointer */ d_q->buffer_dom_sid = dom_sid != NULL ? 1 : 0; /* domain sid pointer */ /* this string is supposed to be character short */ make_unistr2(&(d_q->uni_domain_name), dom_name, domlen); + d_q->uni_domain_name.uni_max_len++; sid_to_string(sid_str, dom_sid); make_dom_sid2(&(d_q->dom_sid), dom_sid); |