diff options
| author | Simo Sorce <idra@samba.org> | 2007-02-22 21:59:54 +0000 |
|---|---|---|
| committer | Simo Sorce <idra@samba.org> | 2007-02-22 21:59:54 +0000 |
| commit | fa1d01363160cb0bd6ecdd2a06e41ecf30a602da (patch) | |
| tree | 7cce5ae73e8ade1720a805294cd1c0d8662576e5 | |
| parent | 0a78fab6af73ce8042ebb11194c8a1ec78c34711 (diff) | |
| download | samba-fa1d01363160cb0bd6ecdd2a06e41ecf30a602da.tar.gz samba-fa1d01363160cb0bd6ecdd2a06e41ecf30a602da.tar.xz samba-fa1d01363160cb0bd6ecdd2a06e41ecf30a602da.zip | |
r21508: Fix memleak in new idmap_tdb, thanks Herb.
Jerry please check.
Simo.
| -rw-r--r-- | source/nsswitch/idmap_tdb.c | 16 |
1 files changed, 4 insertions, 12 deletions
diff --git a/source/nsswitch/idmap_tdb.c b/source/nsswitch/idmap_tdb.c index ef004daa3e2..c21c066fea1 100644 --- a/source/nsswitch/idmap_tdb.c +++ b/source/nsswitch/idmap_tdb.c @@ -1049,19 +1049,11 @@ static NTSTATUS idmap_tdb_remove_mapping(struct idmap_domain *dom, const struct /* Delete previous mappings. */ - data = tdb_fetch(ctx->tdb, ksid); - if (data.dptr) { - DEBUG(10, ("Deleting existing mapping %s -> %s\n", ksid.dptr, kid.dptr )); - tdb_delete(ctx->tdb, ksid); - SAFE_FREE(data.dptr); - } + DEBUG(10, ("Deleting existing mapping %s -> %s\n", ksid.dptr, kid.dptr )); + tdb_delete(ctx->tdb, ksid); - data = tdb_fetch(ctx->tdb, kid); - if (data.dptr) { - DEBUG(10,("Deleting existing mapping %s -> %s\n", kid.dptr, ksid.dptr )); - tdb_delete(ctx->tdb, kid); - SAFE_FREE(data.dptr); - } + DEBUG(10,("Deleting existing mapping %s -> %s\n", kid.dptr, ksid.dptr )); + tdb_delete(ctx->tdb, kid); tdb_chainunlock(ctx->tdb, ksid); ret = NT_STATUS_OK; |