diff options
| author | Volker Lendecke <vlendec@samba.org> | 2007-02-17 23:41:45 +0000 |
|---|---|---|
| committer | Volker Lendecke <vlendec@samba.org> | 2007-02-17 23:41:45 +0000 |
| commit | 3905e514434a619cadf5c034574d2852ee57c4b3 (patch) | |
| tree | c3e7292a4643cde7e3b3b06c438fc7c3ad58524b | |
| parent | b64468ffab57c250930c5977f80b84076aa2cf65 (diff) | |
| download | samba-3905e514434a619cadf5c034574d2852ee57c4b3.tar.gz samba-3905e514434a619cadf5c034574d2852ee57c4b3.tar.xz samba-3905e514434a619cadf5c034574d2852ee57c4b3.zip | |
r21412: The last patch also incremented the seqnum when tdb_store failed. Not as bad
as not doing it at all, but needs fixing. Also simplify the logic, I had
missed the "goto out" at the end of the function.
Volker
| -rw-r--r-- | source/tdb/common/tdb.c | 18 |
1 files changed, 10 insertions, 8 deletions
diff --git a/source/tdb/common/tdb.c b/source/tdb/common/tdb.c index 9760ceebf5d..248acb7374e 100644 --- a/source/tdb/common/tdb.c +++ b/source/tdb/common/tdb.c @@ -257,7 +257,7 @@ int tdb_store(struct tdb_context *tdb, TDB_DATA key, TDB_DATA dbuf, int flag) u32 hash; tdb_off_t rec_ptr; char *p = NULL; - int ret = 0; + int ret = -1; if (tdb->read_only || tdb->traverse_read) { tdb->ecode = TDB_ERR_RDONLY; @@ -277,8 +277,10 @@ int tdb_store(struct tdb_context *tdb, TDB_DATA key, TDB_DATA dbuf, int flag) } } else { /* first try in-place update, on modify or replace. */ - if (tdb_update_hash(tdb, key, hash, dbuf) == 0) - goto out; + if (tdb_update_hash(tdb, key, hash, dbuf) == 0) { + ret = 0; + goto fail; /* Well, not really failed */ + } if (tdb->ecode == TDB_ERR_NOEXIST && flag == TDB_MODIFY) { /* if the record doesn't exist and we are in TDB_MODIFY mode then @@ -328,15 +330,15 @@ int tdb_store(struct tdb_context *tdb, TDB_DATA key, TDB_DATA dbuf, int flag) goto fail; } - out: - tdb_increment_seqnum(tdb); + ret = 0; + fail: + if (ret == 0) { + tdb_increment_seqnum(tdb); + } SAFE_FREE(p); tdb_unlock(tdb, BUCKET(hash), F_WRLCK); return ret; -fail: - ret = -1; - goto out; } |