diff options
| author | Jeremy Allison <jra@samba.org> | 2006-03-13 23:58:58 +0000 |
|---|---|---|
| committer | Jeremy Allison <jra@samba.org> | 2006-03-13 23:58:58 +0000 |
| commit | 2376dc0bcf412ccfd202428ab48a3358bf34148a (patch) | |
| tree | 1802dcab0610c4ef4a11c9f70e94b9d3e4be4398 | |
| parent | acb31939bcb45e53af8665f88b643c182baa6755 (diff) | |
| download | samba-2376dc0bcf412ccfd202428ab48a3358bf34148a.tar.gz samba-2376dc0bcf412ccfd202428ab48a3358bf34148a.tar.xz samba-2376dc0bcf412ccfd202428ab48a3358bf34148a.zip | |
r14359: Try and fix Coverity #176 by making the pointer
aliasing clearer. This isn't a bug but a code
clarification.
Jeremy.
| -rw-r--r-- | source/client/client.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/source/client/client.c b/source/client/client.c index 1d42fd2995a..886af863e47 100644 --- a/source/client/client.c +++ b/source/client/client.c @@ -1336,15 +1336,15 @@ static struct file_list { Free a file_list structure. ****************************************************************************/ -static void free_file_list (struct file_list * list) +static void free_file_list (struct file_list *list_head) { - struct file_list *tmp; + struct file_list *list, *next; - while (list) { - tmp = list; - DLIST_REMOVE(list, list); - SAFE_FREE(tmp->file_path); - SAFE_FREE(tmp); + for (list = list_head; list; list = next) { + next = list->next; + DLIST_REMOVE(list_head, list); + SAFE_FREE(list->file_path); + SAFE_FREE(list); } } |