diff options
| author | Jeremy Allison <jra@samba.org> | 2003-05-09 01:06:43 +0000 |
|---|---|---|
| committer | Jeremy Allison <jra@samba.org> | 2003-05-09 01:06:43 +0000 |
| commit | a0688316ce0a9bad0b24cbb495f6e0a112227b50 (patch) | |
| tree | ddea8703dbf33f1bc89e5b5e86d0302062df6709 | |
| parent | b13046d95958995d9d05be977b8874df17fedb9b (diff) | |
| download | samba-a0688316ce0a9bad0b24cbb495f6e0a112227b50.tar.gz samba-a0688316ce0a9bad0b24cbb495f6e0a112227b50.tar.xz samba-a0688316ce0a9bad0b24cbb495f6e0a112227b50.zip | |
Fix nasty bug pointed out by samba-technical poster. If name is mangled
then we weren't always correctly detecting that it had a valid stat struct
and so might now return a 'file existed'. Finally realized this when installing
the W2K resource kit as a test case.
Jeremy.
| -rw-r--r-- | source/smbd/filename.c | 13 |
1 files changed, 12 insertions, 1 deletions
diff --git a/source/smbd/filename.c b/source/smbd/filename.c index ad707a2b9dd..9dd1523c73d 100644 --- a/source/smbd/filename.c +++ b/source/smbd/filename.c @@ -248,6 +248,16 @@ BOOL unix_convert(pstring name,connection_struct *conn,char *saved_last_componen return(False); } + if (!end) { + /* + * We just scanned for, and found the end of the path. + * We must return the valid stat struct. + * JRA. + */ + + *pst = st; + } + } else { pstring rest; @@ -373,7 +383,8 @@ BOOL unix_convert(pstring name,connection_struct *conn,char *saved_last_componen /* * If we ended up resolving the entire path then return a valid - * stat struct if we got one. + * stat struct if we got one. Note this doesn't catch mangled paths, + * but the check in the for loop above will do that. JRA. */ if (VALID_STAT(st) && (strlen(orig_path) == strlen(name))) |