From c192c1ae3e080597995b906d93cc7607ffc605c0 Mon Sep 17 00:00:00 2001 From: Petr Viktorin Date: Fri, 6 May 2016 18:12:02 +0200 Subject: ipaldap: Convert dict items to list before iterating In Python 3, dict.items() returns a view. When such a view is iterated over, the dict cannot change size. Part of the work for: https://fedorahosted.org/freeipa/ticket/4985 Reviewed-By: Martin Basti --- ipapython/ipaldap.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ipapython/ipaldap.py b/ipapython/ipaldap.py index 74add512a..9fb7fd3f5 100644 --- a/ipapython/ipaldap.py +++ b/ipapython/ipaldap.py @@ -456,7 +456,7 @@ class LDAPEntry(collections.MutableMapping): def __delitem__(self, name): name = self._get_attr_name(name) - for (altname, keyname) in self._names.items(): + for (altname, keyname) in list(self._names.items()): if keyname == name: del self._names[altname] -- cgit