From 299c91df9284510a131017c7fb44f555f2e2afc3 Mon Sep 17 00:00:00 2001
From: Simo Sorce <ssorce@redhat.com>
Date: Thu, 3 Nov 2011 13:21:59 -0400
Subject: Fix CID 11019: Resource leak

https://fedorahosted.org/freeipa/ticket/2037
---
 daemons/ipa-kdb/ipa_kdb.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/daemons/ipa-kdb/ipa_kdb.c b/daemons/ipa-kdb/ipa_kdb.c
index 6a6c20639..481b1f392 100644
--- a/daemons/ipa-kdb/ipa_kdb.c
+++ b/daemons/ipa-kdb/ipa_kdb.c
@@ -263,6 +263,13 @@ int ipadb_get_connection(struct ipadb_context *ipactx)
 
 done:
     ldap_msgfree(res);
+
+    ldap_value_free_len(vals);
+    for (i = 0; i < c && cvals[i]; i++) {
+        free(cvals[i]);
+    }
+    free(cvals);
+
     if (ret) {
         if (ipactx->lcontext) {
             ldap_unbind_ext_s(ipactx->lcontext, NULL, NULL);
@@ -274,12 +281,6 @@ done:
         return EIO;
     }
 
-    ldap_value_free_len(vals);
-    for (i = 0; i < c; i++) {
-        free(cvals[i]);
-    }
-    free(cvals);
-
     return 0;
 }
 
-- 
cgit