summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* host_del: update help for --updatedns optionMartin Basti2016-04-131-1/+2
| | | | | | | | Clarify that dns removes only A, AAAA, PTR, SSHFP records of the host(s) managed by IPA DNS. https://fedorahosted.org/freeipa/ticket/5675 Reviewed-By: Petr Spacek <pspacek@redhat.com>
* host_del: remove only A, AAAA, SSHFP, PTR recordsMartin Basti2016-04-131-21/+17
| | | | | | | | | only A, AAAA, SSHPF and PTR records are managed by IPA. The other records should be removed by user. https://fedorahosted.org/freeipa/ticket/5675 Reviewed-By: Petr Spacek <pspacek@redhat.com>
* host_del: split removing A/AAAA and PTR records to separate functionsMartin Basti2016-04-131-10/+14
| | | | | | | | | This change is needed because A/AAAA and PTR record will be handled separately. https://fedorahosted.org/freeipa/ticket/5675 Reviewed-By: Petr Spacek <pspacek@redhat.com>
* host_del: remove unneeded dnszone-show command callMartin Basti2016-04-131-18/+12
| | | | | | | | | This command has no effect in that block of code, dnsrecord_show is enough for detection if records exists. https://fedorahosted.org/freeipa/ticket/5675 Reviewed-By: Petr Spacek <pspacek@redhat.com>
* host_del: replace dns-record find command with showMartin Basti2016-04-131-12/+17
| | | | | | | | | Due the configuration of dnsrecord_find, it works as dnsrecord-show, thus it can be replaced. https://fedorahosted.org/freeipa/ticket/5675 Reviewed-By: Petr Spacek <pspacek@redhat.com>
* host_del: fix removal of host recordsMartin Basti2016-04-131-21/+10
| | | | | | | | | Originally only the first A/AAAA record is removed, and one other record. This commit fixes it and all records are removed. https://fedorahosted.org/freeipa/ticket/5675 Reviewed-By: Petr Spacek <pspacek@redhat.com>
* Fixed a failure in legacy_client testsOleg Fayans2016-04-131-1/+1
| | | | | | https://fedorahosted.org/freeipa/ticket/5800 Reviewed-By: Martin Babinsky <mbabinsk@redhat.com>
* Add missing pre_common_callback to stageuser_addMartin Basti2016-04-121-0/+2
| | | | | | | | | | This pre_callback contains method to preprocessing usercertificate that was not called during stageuser-add. This commit adds missing pre_common_callback call to stageuser_add. https://fedorahosted.org/freeipa/ticket/5759 Reviewed-By: Martin Babinsky <mbabinsk@redhat.com>
* Added 5 more tests to Replica Promotion testsuiteOleg Fayans2016-04-061-1/+131
| | | | | | | | | | | | | | The following testcases were automated: 1. Test one command replica installation 2. Test csreplica-manage-(del, connect, disconnect) are disabled in domain level 1 3. Client enrollment and replica promotion by an unprivileged user are prohibited 4. Replica uninstallation is prohibited if it disconnects a part of existing topology (is possible only with --ignore-topology-disconnect option) https://fedorahosted.org/freeipa/ticket/5723 Reviewed-By: Martin Babinsky <mbabinsk@redhat.com>
* Added a kdestroy call to clean ccache at master/client uninstallationOleg Fayans2016-04-061-0/+2
| | | | | | | https://fedorahosted.org/freeipa/ticket/5741 Reviewed-By: Martin Babinsky <mbabinsk@redhat.com> Reviewed-By: Rob Crittenden <rcritten@redhat.com>
* Refactor test_hostgroup_pluginFilip Skola2016-03-241-278/+101
| | | | Reviewed-By: Milan Kubik <mkubik@redhat.com>
* Refactor test_nesting, create HostGroupTrackerFilip Skola2016-03-244-627/+399
| | | | Reviewed-By: Milan Kubik <mkubik@redhat.com>
* otptoken-add: improve the robustness of QR code printingMartin Babinsky2016-03-242-7/+74
| | | | | | | | | | | The python-qrcode print_ascii() method does not work in terminals with non-UTF-8 encoding. When this is the case do not render QR code but print a warning instead. Also print a warning when the QR code size is greater that terminal width if the output is a tty. https://fedorahosted.org/freeipa/ticket/5700 Reviewed-By: Jan Cholasta <jcholast@redhat.com>
* Fixed a bug with prepare_host failing upon existing ipatests folderOleg Fayans2016-03-231-1/+5
| | | | | | https://fedorahosted.org/freeipa/ticket/5748 Reviewed-By: Martin Basti <mbasti@redhat.com>
* Reverted changes in mh fixture causing some tests to failOleg Fayans2016-03-231-0/+3
| | | | | | | | | | | Some integration tests expect the members of topology to have the testfolder. The testfolder however was created during master and client installations. In case the client is not intalled from the very beginning of the test execution, the test would complain about missing testfolder. https://fedorahosted.org/freeipa/ticket/5723 Reviewed-By: Martin Basti <mbasti@redhat.com>
* Look up HTTPD_USER's UID and GID during installation.David Kupka2016-03-232-3/+7
| | | | | | | | | Those values differ among distributions and there is no guarantee that they're reserved. It's better to look them up based on HTTPD_USER's name. https://fedorahosted.org/freeipa/ticket/5712 Reviewed-By: Martin Basti <mbasti@redhat.com>
* Fix stageuser-activate - managers testMartin Basti2016-03-233-31/+35
| | | | | | https://fedorahosted.org/freeipa/ticket/5481 Reviewed-By: David Kupka <dkupka@redhat.com>
* spec file: rename the python-polib dependency name to python2-polibMilan KubĂ­k2016-03-231-2/+4
| | | | | | | | | | | | | | Trying to install the package depending on python-polib breaks when the system has newer (and renamed) version python2-polib. *This patch is an workaround* for the issue described in [1]. If a renamed package's provides is equal to an older package's name, dnf tries to install the older package. When the newer package is in the system, this leads to a conflict. [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1096506 Reviewed-By: Martin Basti <mbasti@redhat.com>
* Fix kdc.conf.template to use ipaplatform.paths.Timo Aaltonen2016-03-233-6/+14
| | | | | | https://fedorahosted.org/freeipa/ticket/5343 Reviewed-By: David Kupka <dkupka@redhat.com>
* Use ODS_USER/ODS_GROUP in opendnssec_conf.templateTimo Aaltonen2016-03-232-2/+4
| | | | | | https://fedorahosted.org/freeipa/ticket/5343 Reviewed-By: David Kupka <dkupka@redhat.com>
* ipaplatform: Move remaining user/group constants to ipaplatform.constants.Timo Aaltonen2016-03-2311-57/+27
| | | | | | | | | Use ipaplatform.constants in every corner instead of importing other bits or calling some platform specific things, and remove most of the remaining hardcoded uid's. https://fedorahosted.org/freeipa/ticket/5343 Reviewed-By: David Kupka <dkupka@redhat.com>
* rewrite a misprocessed teardown_method method as a custom decoratorOleg Fayans2016-03-232-13/+26
| | | | | | | | | | | | | teardown_method is a standard pytest method used to put any code to be executed after each test method is executed. While treated correctly by our integration tests, this method is misinterpreted by in-tree tests in the following way: in-tree tests try to execute it even if all the test methods are skipped due to test resources being not configured. This causes the tests, that otherwise would have been skipped, to fail https://fedorahosted.org/freeipa/ticket/5723 Reviewed-By: Martin Basti <mbasti@redhat.com>
* ipa_restore: Import only FQDN from ipalib.constantsTimo Aaltonen2016-03-231-4/+5
| | | | | | https://fedorahosted.org/freeipa/ticket/5619 Reviewed-By: Martin Basti <mbasti@redhat.com>
* Resize topology graph canvas according to window sizePavel Vomacka2016-03-222-4/+57
| | | | | | | | | | The size of svg element is calculated when the topology graph facet is load and then every time when the window is resized. The resize event listener is removed after the topology graph facet emits hide event. https://fedorahosted.org/freeipa/ticket/5647 Reviewed-By: Petr Vobornik <pvoborni@redhat.com>
* Fix: catch Exception instead of more specific exception typesMartin Basti2016-03-222-4/+4
| | | | | | | | Regression caused by commit 491447cc5ab8c5eff2be57d609201cefb79f7053, ValueErrori and AttributeError are too much specific for these cases, multiple types of exception can be raised. Reviewed-By: Martin Babinsky <mbabinsk@redhat.com>
* Added copyright info to replica promotion testsOleg Fayans2016-03-221-0/+4
| | | | | | https://fedorahosted.org/freeipa/ticket/5723 Reviewed-By: Martin Basti <mbasti@redhat.com>
* ipa-replica-manage: print traceback on unexpected error when in verbose modeMartin Babinsky2016-03-221-5/+13
| | | | | | | | Print the traceback to stdout to maintain backwards compatibility. https://fedorahosted.org/freeipa/ticket/5380 Reviewed-By: Martin Basti <mbasti@redhat.com>
* Move user/group constants for PKI and DS into ipaplatformChristian Heimes2016-03-2212-37/+49
| | | | | | | https://fedorahosted.org/freeipa/ticket/5619 Reviewed-By: David Kupka <dkupka@redhat.com> Reviewed-By: Fraser Tweedale <ftweedal@redhat.com>
* SPEC: do not run upgrade when ipa server is not installedMartin Basti2016-03-221-7/+10
| | | | | | | | Running upgrade when IPA is not installed produces false positive errors https://fedorahosted.org/freeipa/ticket/5704 Reviewed-By: Martin Babinsky <mbabinsk@redhat.com>
* Pylint: enable invalid-name checkMartin Basti2016-03-221-1/+0
| | | | | | | | This check can be enabled, there is no errors in current code, and it should stay in that way. Reviewed-By: Petr Spacek <pspacek@redhat.com> Reviewed-By: Lukas Slebodnik <lslebodn@redhat.com>
* Pylint: remove unnecessary-semicolonMartin Basti2016-03-227-9/+8
| | | | | Reviewed-By: Petr Spacek <pspacek@redhat.com> Reviewed-By: Lukas Slebodnik <lslebodn@redhat.com>
* Pylint: import max one module per lineMartin Basti2016-03-227-7/+12
| | | | | Reviewed-By: Petr Spacek <pspacek@redhat.com> Reviewed-By: Lukas Slebodnik <lslebodn@redhat.com>
* Pylint: use list comprehension instead of iterationMartin Basti2016-03-222-5/+1
| | | | | | | | | Iteration over indexes without calling enumeration fuction is not pythonic and should not be used. In this case iteration can be replaced by list comprehension. Fixing this allows to enable pylint consider-using-enumerate check. Reviewed-By: Petr Spacek <pspacek@redhat.com> Reviewed-By: Lukas Slebodnik <lslebodn@redhat.com>
* Pylint: enable reimported checkMartin Basti2016-03-228-12/+3
| | | | | | | Fixes current reimports and enables pylint check for them Reviewed-By: Petr Spacek <pspacek@redhat.com> Reviewed-By: Lukas Slebodnik <lslebodn@redhat.com>
* Pylint: enable pointless-except checkMartin Basti2016-03-221-1/+0
| | | | | | | | This check can be enabled, there is no errors in current code, and it should stay in that way. Reviewed-By: Petr Spacek <pspacek@redhat.com> Reviewed-By: Lukas Slebodnik <lslebodn@redhat.com>
* Pylint: fix definition of global variablesMartin Basti2016-03-224-8/+8
| | | | | | | | | | Global variables should be defined in the outer space, not just marked as global inside functions. Removes unused global variables Reviewed-By: Petr Spacek <pspacek@redhat.com> Reviewed-By: Lukas Slebodnik <lslebodn@redhat.com>
* pylint: remove bare exceptMartin Basti2016-03-2225-57/+51
| | | | | | | Bare except should not be used. Reviewed-By: Petr Spacek <pspacek@redhat.com> Reviewed-By: Lukas Slebodnik <lslebodn@redhat.com>
* spec: require python-cryptography newer than 0.9Martin Babinsky2016-03-211-2/+2
| | | | | | | | | | | When generating keys for custodia service, the key material is stored in python-cryptography's OpenSSL backend encoded as DER. This only works in python-cryptography 0.9 and newer so we need to make sure this version pulled in during RPM build and install. https://fedorahosted.org/freeipa/ticket/5744 Reviewed-By: Martin Basti <mbasti@redhat.com>
* DS deadlock when memberof scopes topology plugin updatesThierry Bordaz2016-03-181-0/+2
| | | | | | | | | | | | | | | | | Topology plugin may merge (aka DEL) segments that would trigger internal search for groups owning that segment. The problem is that it is searching those groups into the full suffix and so need the schema compat map lock. If any other operation holding schema compat map lock need to access the page involved in the DEL, there is a deadlock. This fix is to prevent useless group searching if the target entry is a segment or is in compat tree. https://fedorahosted.org/freeipa/ticket/5637 Reviewed-By: Martin Basti <mbasti@redhat.com>
* sudo: Fix a typo in the --help output of sudocmdgroupJakub Hrozek2016-03-181-2/+2
| | | | Reviewed-By: Martin Basti <mbasti@redhat.com>
* spec: add conflict with bind-chroot to freeipa-server-dnsMartin Babinsky2016-03-181-0/+3
| | | | | | https://fedorahosted.org/freeipa/ticket/5696 Reviewed-By: Jan Cholasta <jcholast@redhat.com>
* client: enable ChallengeResponseAuthentication in sshd_configMartin Basti2016-03-181-0/+1
| | | | | | | | | | | | In order to enable SSSD smart prompting and allow it to ask for 1FA and 2FA separately, ChallengeResponseAuthentication should be set to yes. This change will enable better processing of the 2FA value and it will also enable other features, like allow SSSD to make the 2FA option in some cases and have a way of informing user that 2FA is optional. https://fedorahosted.org/freeipa/ticket/5703 Reviewed-By: Jan Cholasta <jcholast@redhat.com>
* spec: Add missing dependencies to python*-ipalib packageMartin Basti2016-03-181-0/+8
| | | | | | | | | Standalone instalation of python*-ipalib packages does not pull all required packages and results into import errors. https://fedorahosted.org/freeipa/ticket/5680 Reviewed-By: Jan Cholasta <jcholast@redhat.com>
* Fix broken trust warningsMartin Basti2016-03-161-1/+3
| | | | | | | | Warning should be shown only for parent entries of trust domain. Subdomains do not contain ipaNTSecurityIdentifier attribute at all. https://fedorahosted.org/freeipa/ticket/5737 Reviewed-By: Alexander Bokovoy <abokovoy@redhat.com>
* certdb: never use the -r option of certutilJan Cholasta2016-03-161-10/+8
| | | | | | | | | | | | | | | The -r option makes certutil output certificates in DER. If there are multiple certificates sharing the same nickname, certutil will output them concatenated into a single blob. The blob is not a valid DER anymore and causes failures further in the code. Use the -a option instead to output the certificates in PEM and convert them to DER on demand. https://fedorahosted.org/freeipa/ticket/5117 https://fedorahosted.org/freeipa/ticket/5720 Reviewed-By: David Kupka <dkupka@redhat.com>
* Use platform path constant for SSSD log dirMartin Basti2016-03-162-1/+2
| | | | | | | The path to SSSD log directory is platform specific and should be in ipaplatform module. Reviewed-By: David Kupka <dkupka@redhat.com>
* Remove redundant parameters from CS.cfg in dogtaginstanceMartin Basti2016-03-161-8/+0
| | | | | | | | | | Bind DN is not used for client certificate authentication so they can be safely removed. https://fedorahosted.org/freeipa/ticket/5298 Reviewed-By: Fraser Tweedale <ftweedal@redhat.com> Reviewed-By: Jan Cholasta <jcholast@redhat.com>
* stageuser-activate: Normalize manager valueMartin Basti2016-03-161-10/+11
| | | | | | | | | Manager(s) were returned as list od DN, this commit fixes behavior and managers are returned as list of logins. https://fedorahosted.org/freeipa/ticket/5481 Reviewed-By: David Kupka <dkupka@redhat.com>
* only search for Kerberos SRV records when autodiscovery was requestedMartin Babinsky2016-03-141-3/+7
| | | | | | | | | | | When a list of servers is passed to ipa-client-{install,automount} the search of Kerberos and LDAP SRV records should be suppressed and the specified hostnames used directly as LDAP servers/KDCs. We thus should not performed search for KDCs when the autodiscovery was actually not requested. https://fedorahosted.org/freeipa/ticket/4305 Reviewed-By: Martin Basti <mbasti@redhat.com>
* Workaround for ticket 5627Oleg Fayans2016-03-111-0/+5
| | | | | | https://fedorahosted.org/freeipa/ticket/5723 Reviewed-By: Martin Basti <mbasti@redhat.com>