diff options
author | Petr Viktorin <pviktori@redhat.com> | 2014-06-02 17:31:48 +0200 |
---|---|---|
committer | Martin Kosek <mkosek@redhat.com> | 2014-06-04 10:10:08 +0200 |
commit | a2aca68f63c2e442dc9e103ae31ba0c67d606186 (patch) | |
tree | 40acc5a527c058ebc106e92ac7cfbc4cdba48c60 /ipalib | |
parent | c123d950844dac6088c5a0f31e618184943c0162 (diff) | |
download | freeipa-a2aca68f63c2e442dc9e103ae31ba0c67d606186.tar.gz freeipa-a2aca68f63c2e442dc9e103ae31ba0c67d606186.tar.xz freeipa-a2aca68f63c2e442dc9e103ae31ba0c67d606186.zip |
ipalib.aci: Fix bugs in comparison
- regression in be6edef6e48224e74344f48d25876b09cd263674:
The __ne__ special method was named incorrectly
- regression in 1ea6def129aa459ecc3d176a3b6aebdf75de2eb7:
The targetattr operator was never compared
Include some new comparison tests.
Reviewed-By: Martin Kosek <mkosek@redhat.com>
Diffstat (limited to 'ipalib')
-rwxr-xr-x | ipalib/aci.py | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/ipalib/aci.py b/ipalib/aci.py index cea61a9c4..a55732bf1 100755 --- a/ipalib/aci.py +++ b/ipalib/aci.py @@ -238,8 +238,8 @@ class ACI: if set(self.target.get('targetattr', {}).get('expression', ())) != set(b.target.get('targetattr',{}).get('expression', ())): return False - if self.target.get('targetattr',{}).get('operator') != b.target.get('targetattr',{}).get('operator'): - return False + if self.target.get('targetattr',{}).get('operator') != b.target.get('targetattr',{}).get('operator'): + return False if self.target.get('target',{}).get('expression') != b.target.get('target',{}).get('expression'): return False @@ -255,5 +255,5 @@ class ACI: __eq__ = isequal - def __neq__(self, b): + def __ne__(self, b): return not self == b |