diff options
| author | Tomas Babej <tbabej@redhat.com> | 2014-01-23 13:33:59 +0100 |
|---|---|---|
| committer | Petr Viktorin <pviktori@redhat.com> | 2014-02-10 10:36:50 +0100 |
| commit | 02a79e56b30bb0d1bb3979ad933492dfecfc640c (patch) | |
| tree | 271386f115f2134542c1c25111f7289c91f5c188 | |
| parent | 04381623d5af38db1ec5c83d2ca5317af1af73cb (diff) | |
| download | freeipa-02a79e56b30bb0d1bb3979ad933492dfecfc640c.tar.gz freeipa-02a79e56b30bb0d1bb3979ad933492dfecfc640c.tar.xz freeipa-02a79e56b30bb0d1bb3979ad933492dfecfc640c.zip | |
ipatests: Perform a connection test before preparing the client
When the host is down, the preparation of the host fails. This
produces misleading errors, since the test framework reports that
the actual command being executed failed, when in fact (in case
of SSHTransport), the cause of failure was unability to establish
a SSH session.
https://fedorahosted.org/freeipa/ticket/4132
Reviewed-By: Nathaniel McCallum <npmccallum@redhat.com>
| -rw-r--r-- | ipatests/test_integration/tasks.py | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/ipatests/test_integration/tasks.py b/ipatests/test_integration/tasks.py index 893ce529c..37db9561c 100644 --- a/ipatests/test_integration/tasks.py +++ b/ipatests/test_integration/tasks.py @@ -42,6 +42,10 @@ log = log_mgr.get_logger(__name__) def prepare_host(host): if isinstance(host, Host): env_filename = os.path.join(host.config.test_dir, 'env.sh') + + # First we try to run simple echo command to test the connection + host.run_command(['true'], set_env=False) + host.collect_log(env_filename) host.transport.mkdir_recursive(host.config.test_dir) host.put_file_contents(env_filename, env_to_script(host.to_env())) |