From 889e07426f879ee8c999692a298f48221805ec06 Mon Sep 17 00:00:00 2001 From: Noriko Hosoi Date: Fri, 23 Jul 2010 11:17:37 -0700 Subject: 610281 - fix coverity Defect Type: Control flow issues https://bugzilla.redhat.com/show_bug.cgi?id=610281 11792 DEADCODE Triaged Unassigned Bug Minor Fix Required acl__match_handlesFromCache() ds/ldap/servers/plugins/acl/acl.c Comment: Looks like a simple copy & paste bug. Replaced the macro to compare ACLPB_HAS_ACLCB_EVALCONTEXT with ACLPB_EVALCONTEXT_ACLCB. --- ldap/servers/plugins/acl/acl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'ldap/servers/plugins/acl/acl.c') diff --git a/ldap/servers/plugins/acl/acl.c b/ldap/servers/plugins/acl/acl.c index 43b289e9..a96a34b2 100644 --- a/ldap/servers/plugins/acl/acl.c +++ b/ldap/servers/plugins/acl/acl.c @@ -3748,7 +3748,7 @@ acl__match_handlesFromCache ( Acl_PBlock *aclpb, char *attr, int access) aclpb->aclpb_state &= ~ACLPB_MATCHES_ALL_ACLS; aclpb->aclpb_state |= ACLPB_UPD_ACLCB_CACHE; /* Did not match */ - if ( context_type == ACLPB_HAS_ACLCB_EVALCONTEXT ) { + if ( context_type == ACLPB_EVALCONTEXT_ACLCB ) { aclpb->aclpb_state &= ~ACLPB_HAS_ACLCB_EVALCONTEXT; } else { aclpb->aclpb_state |= ACLPB_COPY_EVALCONTEXT; -- cgit