From 470e2c70338440f69b0ab8fc02128fe5f204af3e Mon Sep 17 00:00:00 2001 From: Nathan Kinder Date: Wed, 15 Sep 2010 11:45:56 -0700 Subject: Bug 630097 - (cov#11938) NULL dereference in mmldif There is a chance that a can be NULL, which we then dereference within the else block. We should not execute the else block if a is NULL. --- ldap/servers/slapd/tools/mmldif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ldap/servers/slapd/tools/mmldif.c b/ldap/servers/slapd/tools/mmldif.c index 665452cb..b364a19c 100644 --- a/ldap/servers/slapd/tools/mmldif.c +++ b/ldap/servers/slapd/tools/mmldif.c @@ -1108,7 +1108,7 @@ addmodified(FILE * edf3, attrib1_t * attrib, record_t * first) } while (num_b <= tot_b && stricmp(attribname(b), attrname) == 0); fprintf(edf3, "-\n"); continue; - } else { + } else if (a != NULL) { /* a == b */ int nmods = 0; attrib_t *begin_b = b; -- cgit