| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
improper use of ldap_get_next.
|
| |
|
|
| |
certain changes to not get synched.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bug Description: ./ns-slapd crashes on bind containing invalid dn and password
Reviewed by: Noriko (Thanks!)
Branch: HEAD
Fix Description: It's really crashing on the search request. The problem is that the server assumes all strings are encoded in utf8 format, since that is the only encoding allowed by the LDAP standards. Non-utf8 works in most places except the function slapi_utf8StrToLower(), which returns NULL given a string of non-utf8 bytes. The fix for this particular problem is to check for a NULL return value and handle accordingly.
The real solution to this problem would be for the server to check for valid utf8 strings in _all_ LDAP data, according to the syntax of the attribute (e.g. for binary or octet string syntax data, and other binary formats, all bets are off, but then we shouldn't be doing strtolower on these blobs either).
And, while we're at it, add data validation based on syntax for _all_ attributes e.g. in a pre-op.
Platforms tested: RHEL4
Flag Day: no
Doc impact: no
QA impact: should be covered by regular nightly and manual testing
New Tests integrated into TET: none
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Bug Description: slapd crashes during SASL authentication
Reviewed by: Noriko (Thanks!)
Branch: HEAD
Fix Description: I could not reproduce the crash. I tried several different ways - no password in entry, empty password in entry, SSHA hashed password in entry - no crashes. No useful information from the FDS bug reporter either. In fact I found that SASL Digest-MD5 was not working at all. We needed to use the SASL_AUX_PASSWORD_PROP define instead of hardcoding "userpassword" - I guess sasl is case sensitive. I also fixed some missing new lines in log messages.
Platforms tested: RHEL4
Flag Day: no
Doc impact: no
QA impact: should be covered by regular nightly and manual testing
New Tests integrated into TET: none
|
| |
|
|
|
|
|
|
| |
1) Eliminated SLAPD_MODUTIL_TREE_THREASHHOLD from attr.c as well as valueset.c.
With this change, if an attribute has more than 1 value to add/replace/delete,
it creates an AVL tree to check the duplicates.
2) Replace was not checking the duplicated value at all. Added a code to put
the attribute values into the AVL tree as being done for add and delete.
|
| |
|
|
|
|
| |
By default, it dumps the entire entry. (it used to be truncated at the BUFSIZ
size). In case no need to dump the entire entry, introduced the truncate option
"-t".
|
| |
|
|
| |
access of memory which sometimes resulted in crashing.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Bug Description: Daily Acceptance: Directory Install failed to register Directory server as a Red Hat server (81)
Reviewed by: Nathan (Thanks!)
Fix Description: The index code, in the replace case, was not checking to see if there were
actually any values to delete before attempting to delete them. This fix just
checks to see if there are any values to delete.
Platforms tested: RHEL3
Flag Day: no
Doc impact: no
QA impact: should be covered by regular nightly and manual testing with the new indexing tests
New Tests integrated into TET: none
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
| |
Bug Description: Directory Server crashes when deleting a view
Reviewed by: Nathan (Thanks!)
Fix Description: Needed to pass in the _address_ of theCache.pCacheViews to views_cache_add_ll_entry. Yet another lesson in using the compiler to catch type errors rather than casting to void*.
Platforms tested: RHEL3
Flag Day: no
Doc impact: no
QA impact: should be covered by regular nightly and manual testing
New Tests integrated into TET: none
|
| |
|
|
|
|
|
|
|
|
|
| |
Bug Description: Adding multiple attributes using a single ldapmodify crashes ns-slapd
Reviewed by: Nathan (Thanks!)
Fix Description: In C, the array '[]' dereference operator takes precedence over the '*' deref operator. In this case, I needed to put parentheses around the pointer dereference to avoid having array dereferenced first. modary is a pointer to an array, not an array, so I can't dereference it with the array operator until I first dereference the pointer.
Platforms tested: RHEL3
Flag Day: no
Doc impact: no
QA impact: should be covered by regular nightly and manual testing
New Tests integrated into TET: none
|
| |
|
|
| |
subtrees that the operation applies to
|
| |
|
|
|
| |
in a critical section. This fix creates a mutex at init time and uses that
mutex to create a critical section around all PAM API access.
|
| |
|
|
| |
returning SUCCESS.
|
| |
|
|
|
|
|
| |
Coding done by David Irving, Fred Brittain, and Aaron Gagnon
Reviewed by Rich Megginson - minor changes to md5_pwd.c
Tested on RHEL3 with FDS post-7.1
Does not include the OpenLDAP migration script - that will be handled separately
|
| |
|
|
| |
Plus fixed branding/version number.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
| |
Bug Description: Reliab 05: chaining backend test core dumped on HPUX backend
Reviewed by: Noriko (Thanks!)
Fix Description: This is a 64 bit issue. For ber_scanf, the "i" and "e" flags require a pointer to a long. There were a couple of places in the chaining backend code where we were passing in an int instead. This works fine on 32 bit where ints and longs are both 32 bits. I did a quick check through the code - these were the only places not using longs. The only way you would see this bug is in a "hub" chaining backend - one that gets requests from a mux and chains them to another farm server, or possibly on a mux in certain conditions.
Platforms tested: HP-UX 11.i 64 bit
Flag Day: no
Doc impact: no
QA impact: rerun chaining tests
New Tests integrated into TET: none
|
| |
|
|
| |
replication. Add an error string returned to clients if an illegal attribute is configured
|
| |
|
|
| |
the acquire process has been successful thus far.
|
| |
|
|
| |
failed when it failed due to attempting to do fractional replication to another master.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
| |
Bug Description: RL16: Server core dumped while configuring replication agreements
Reviewed by: David (Thanks!)
Fix Description: The code for handling bad agreements was wrong. It was not returning the correct error code. The result of this is that the client did not receive an appropriate error code/message from the server. The reason for the core dump was that, even though the agreement was not created, the DSE entry was still there, causing the server to become very confused. Returning the correct error code causes the server to refuse to create the bad DSE entry.
Platforms tested: RHEL3
Flag Day: no
Doc impact: no
QA impact: should be covered by regular nightly and manual testing
New Tests integrated into TET: none
|
| |
|
|
| |
Pass these build variables to gmake: NO_MDUPDATE=1 NS_USE_GCC=1
|
| |
|
|
| |
with 'streetaddress'
|
| |
|
|
| |
on Windows.
|
| |
|
|
| |
agreements
|
| | |
|
| | |
|
| | |
|
