summaryrefslogtreecommitdiffstats
path: root/ldap/servers/slapd
Commit message (Collapse)AuthorAgeFilesLines
...
* Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-201-3/+3
| | | | | | | | | 11892 - 11939 https://bugzilla.redhat.com/show_bug.cgi?id=613056 Resolves: bug 613056 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939 description: Catch possible NULL pointer in ldbm_back_archive2ldbm() and ldbm_back_ldbm2archive().
* Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-201-9/+14
| | | | | | | | | 11892 - 11939 https://bugzilla.redhat.com/show_bug.cgi?id=613056 Resolves: bug 613056 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939 description: Catch possible NULL pointer in handle_handshake_done().
* Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093Endi S. Dewata2010-08-191-3/+1
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=617630 Resolves: bug 617630 Bug description: fix coverify Defect Type: Resource leaks issues CID 12093, 12094. description: Fixed resource leaks in ldbm_back_ldbm2ldif().
* Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093Endi S. Dewata2010-08-191-2/+6
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=617630 Resolves: bug 617630 Bug description: fix coverify Defect Type: Resource leaks issues CID 12080. description: Fixed resource leaks in ldbm_instance_config_add_index_entry().
* Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093Endi S. Dewata2010-08-191-6/+9
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=617630 Resolves: bug 617630 Bug description: fix coverify Defect Type: Resource leaks issues CID 12070. description: The idl_old_store_block() has been modified to release the master_block when an error occurs.
* Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093Endi S. Dewata2010-08-191-2/+2
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=617630 Resolves: bug 617630 Bug description: fix coverify Defect Type: Resource leaks issues CID 12090. description: The entry_add_present_values_wsi() has been modified to release valuestoadd before returning.
* Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093Endi S. Dewata2010-08-191-20/+27
| | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=617630 Resolves: bug 617630 Bug description: fix coverify Defect Type: Resource leaks issues CID 12086, 12091, 12092. description: The vlv_build_idl() has been modified to release idl when an error occurs. The "if (idl)" near the end of the function is unnecessary because at that point idl cannot be NULL. The "if (candidate)" has been inverted to catch NULL pointer. The vlv_filter_candidates() and the vlv_trim_candidates() have been modified to check for NULL filteredCandidates in the beginning to avoid resource leaks.
* Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093Endi S. Dewata2010-08-191-4/+6
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=617630 Resolves: bug 617630 Bug description: fix coverify Defect Type: Resource leaks issues CID 12084, 12085. description: range_candidates() has been modified to release highs if an error occurs.
* Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093Endi S. Dewata2010-08-191-4/+3
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=617630 Resolves: bug 617630 Bug description: fix coverify Defect Type: Resource leaks issues CID 12083. description: plugin_enabled() has been modified to use slapi_entry_attr_has_syntax_value() to avoid resource leaks.
* Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093Endi S. Dewata2010-08-191-9/+22
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=617630 Resolves: bug 617630 Bug description: fix coverify Defect Type: Resource leaks issues CID 12079. description: ldbm_instance_create() has been modified to release inst when an error occurs.
* Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093Endi S. Dewata2010-08-191-3/+14
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=617630 Resolves: bug 617630 Bug description: fix coverify Defect Type: Resource leaks issues CID 12078 description: index_addordel_values_ext_sv() has been modified to release keys before going out of scope. index_buffer_init_internal() has been modified to release handle when error occurs.
* Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093Endi S. Dewata2010-08-191-6/+10
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=617630 Resolves: bug 617630 Bug description: fix coverify Defect Type: Resource leaks issues CID 12077 description: id2entry_add_ext() has been modified to release resources properly.
* Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093Endi S. Dewata2010-08-191-14/+14
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=617630 Resolves: bug 617630 Bug description: fix coverify Defect Type: Resource leaks issues CID 12075, 12076. description: import_merge_make_new_queue_entry() and import_merge_one_file() have been modified to release resources when error occurs.
* Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093Endi S. Dewata2010-08-191-3/+7
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=617630 Resolves: bug 617630 Bug description: fix coverify Defect Type: Resource leaks issues CID 12073, 12074. description: normalize_path() has been modified so that resources are released properly.
* Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093Endi S. Dewata2010-08-191-5/+16
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=617630 Resolves: bug 617630 Bug description: fix coverify Defect Type: Resource leaks issues CID 12072, 12088, 12089. description: dse_conf_verify_core() has been modified to release estr before continuing the loop. import_worker() has been modified to release substring_key_buffer before returning. upgradedn_producer() has been modified to release the older data.data and ecopy before reallocating the new ones and before returning.
* Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093Endi S. Dewata2010-08-191-12/+12
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=617630 Resolves: bug 617630 Bug description: fix coverify Defect Type: Resource leaks issues CID 12071. description: perfctrs_init() has been modified to release unused resources when error occurs.
* Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053Endi S. Dewata2010-08-191-0/+2
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=619122 Resolves: bug 619122 Bug description: fix coverify Defect Type: Resource leaks issues CID 12037. description: The csngen_free() has been modified to release gen before it returns.
* Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053Endi S. Dewata2010-08-191-12/+5
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=619122 Resolves: bug 619122 Bug description: fix coverify Defect Type: Resource leaks issues CID 12001. description: The slapi_vattrspi_register_internal() has been modified to remove unnecessary NULL checking.
* Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053Endi S. Dewata2010-08-191-0/+2
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=619122 Resolves: bug 619122 Bug description: fix coverify Defect Type: Resource leaks issues CID 12000. description: The plugin_setup() has been modified to release value properly.
* Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053Endi S. Dewata2010-08-191-0/+2
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=619122 Resolves: bug 619122 Bug description: fix coverify Defect Type: Resource leaks issues CID 11998. description: The str2entry_fast() has been modified to release maxcsn before returning.
* Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053Endi S. Dewata2010-08-191-5/+11
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=619122 Resolves: bug 619122 Bug description: fix coverify Defect Type: Resource leaks issues CID 11997. description: The str2entry_fast() has been modified to release attributedeletioncsn before returning.
* Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053Endi S. Dewata2010-08-191-0/+2
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=619122 Resolves: bug 619122 Bug description: fix coverify Defect Type: Resource leaks issues CID 11996. description: The str2entry_dupcheck() has been modified to release unused maxcsn.
* Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053Endi S. Dewata2010-08-191-0/+11
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=619122 Resolves: bug 619122 Bug description: fix coverify Defect Type: Resource leaks issues CID 11995. description: The str2entry_dupcheck() has been modified to release attributedeletioncsn properly.
* Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053Endi S. Dewata2010-08-191-0/+1
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=619122 Resolves: bug 619122 Bug description: fix coverify Defect Type: Resource leaks issues CID 11986. description: The log__open_auditlogfile() has been modified to release log when an error occurs.
* Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053Endi S. Dewata2010-08-191-1/+1
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=619122 Resolves: bug 619122 Bug description: fix coverify Defect Type: Resource leaks issues CID 11984. description: The mtn_get_referral_from_entry() has been modified to avoid leaking the referral object.
* Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053Endi S. Dewata2010-08-191-1/+1
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=619122 Resolves: bug 619122 Bug description: fix coverify Defect Type: Resource leaks issues CID 11983. description: The pw_rever_encode() has been modified to release pwsp at the end of each loop iteration.
* Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053Endi S. Dewata2010-08-191-1/+1
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=619122 Resolves: bug 619122 Bug description: fix coverify Defect Type: Resource leaks issues CID 11982. description: The check_trivial_words() has been modified to check for NULL smods first before allocating smod to avoid resource leak.
* Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053Endi S. Dewata2010-08-191-0/+1
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=619122 Resolves: bug 619122 Bug description: fix coverify Defect Type: Resource leaks issues CID 11980. description: The log__open_accesslogfile() has been modified to release log when an error occurs.
* Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053Endi S. Dewata2010-08-191-0/+1
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=619122 Resolves: bug 619122 Bug description: fix coverify Defect Type: Resource leaks issues CID 11978. description: The slapi_register_object_extension() has been modified to release fe when an error occurs.
* Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-191-21/+19
| | | | | | | | | | | 11846 - 11891 https://bugzilla.redhat.com/show_bug.cgi?id=614511 Resolves: bug 614511 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 description: Catch possible NULL pointer in slapi_vattr_list_attrs(), slapi_vattrspi_regattr(), and vattr_map_entry_new(). Replaced PR_smprintf() and PR_smprintf_free() with slapi_ch_calloc() and slapi_ch_free().
* Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-191-18/+51
| | | | | | | | | 11846 - 11891 https://bugzilla.redhat.com/show_bug.cgi?id=614511 Resolves: bug 614511 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 description: Catch possible NULL pointer in slapi_pblock_get().
* Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-191-1/+5
| | | | | | | | | 11846 - 11891 https://bugzilla.redhat.com/show_bug.cgi?id=614511 Resolves: bug 614511 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 description: Catch possible NULL pointer in addlenstr().
* Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-191-1/+5
| | | | | | | | | 11846 - 11891 https://bugzilla.redhat.com/show_bug.cgi?id=614511 Resolves: bug 614511 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 description: Catch possible NULL pointer in filter_compute_hash().
* Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-191-4/+10
| | | | | | | | | 11846 - 11891 https://bugzilla.redhat.com/show_bug.cgi?id=614511 Resolves: bug 614511 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 description: Catch possible NULL pointer in slapi_dn_normalize_ext() and slapi_sdn_done().
* Bug 610281 - fix coverity Defect Type: Control flow issues - ↵Rich Megginson2010-08-161-6/+5
| | | | | | | | | | | | | | | | daemon.c:write_function() https://bugzilla.redhat.com/show_bug.cgi?id=610281 Resolves: bug 610281 Bug Description: fix coverity Defect Type: Control flow issues - daemon.c:write_function() Reviewed by: nhosoi (Thanks!) Branch: master Fix Description: sentbytes < count is ok in the non error case - it just means we need to send some more data. Move the checking to the error case so we can print the number of bytes sent and expected. Platforms tested: RHEL5 x86_64, Fedora 14 x86_64 Flag Day: no Doc impact: no
* Bug 623118 - Simplepaged results going in infinite loopNoriko Hosoi2010-08-111-0/+4
| | | | | | | | | | | if a sub suffix exists in the domain https://bugzilla.redhat.com/show_bug.cgi?id=623118 Description: When paging is done on a backend, and if there are more sub backends to be searched and paged, simple paged code is supposed to set the next backend to connection->c_current_be. The setting was missing.
* Bug 622903 - fix coverity Defect Type: Code maintainability issuesNoriko Hosoi2010-08-111-1/+1
| | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=622903 Comment: Pointer "slapdFrontendConfig" returned by "init_config" is never used (line 244).
* Bug 622903 - fix coverity Defect Type: Code maintainability issuesNoriko Hosoi2010-08-111-2/+0
| | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=622903 Comment: Calling slapi_sdn_get_dn and assigning the return value to base is not needed.
* Bug 622903 - fix coverity Defect Type: Code maintainability issuesNoriko Hosoi2010-08-111-4/+3
| | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=622903 Comment: The "p" assignments on line 260, 264, and 268 can be removed because they are not needed.
* Bug 622903 - fix coverity Defect Type: Code maintainability issuesNoriko Hosoi2010-08-111-5/+0
| | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=622903 Comment: Pointer "log_dir" returned by "dblayer_get_home_dir" is never used (line 1492). Removing the unnecessary else clause.
* Bug 622628 - fix coverity Defect Type: Integer handling issuesNoriko Hosoi2010-08-111-3/+4
| | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=622628 Comment: There is a suspicious implicit sign extension. Instead of direct bit shifting, use ntohl to decode buffer length.
* Bug 622628 - fix coverity Defect Type: Integer handling issuesNoriko Hosoi2010-08-101-1/+1
| | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=622628 Comment: slapd_system_strerror does not cover the return codes from the libdb functions. Instead, use dblayer_strerror for describing error number.
* Bug 622628 - fix coverity Defect Type: Integer handling issuesNoriko Hosoi2010-08-101-1/+3
| | | | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=622628 Comment: This is a typo where a bitwise AND was used instead of a logical AND on line 2185. The issue is not serious, as it only affect the "number of operations" counter for ldclt. The second half of the condition is not even needed in fact, since we are guaranteed that "(ret == LDAP_ALREADY_EXISTS)" is true at line 2185. Fix Description: Based upon the comment, removing the unnecessary second half of the condition.
* Bug 194531 - db2bak is too noisyNoriko Hosoi2010-08-104-18/+28
| | | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=194531 Description: Introduced "-q" option to suppress the backing up/ restoring message for each db file. Usage: db2bak [archivedir] [-q] [-h] Usage: bak2db archivedir [-n backendname] [-q] | [-h] If "-q" is specified, the verbose messages are not prited to the standard error, but just to the errors log. In addition, new log level SLAPI_LOG_BACKLDBM/LDAP_DEBUG_BACKLDBM has been introduced.
* 621928 - Unable to enable replica (rdn problem?) on 1.2.6 rc6Noriko Hosoi2010-08-092-13/+271
| | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=621928 Description: RUV (nsuniqueid=ffffffff-ffffffff-ffffffff-ffffffff,<suffix>) needs to be allowed to add to the DB before <suffix> is added. To allow it, entryrdn prepares the rdn exception list (rdn_exceptions). If the to-be-added entry (in this case RUV; and currently only RUV is in the list) is in the list, <suffix> is added to the entryrdn index with the temporary entry ID 0 (note: not to the primary db file id2entry.db#). When the suffix is indeed added to the DB, the temporary ID 0 is replaced with the given real ID.
* 513166 - Simple Paged result doesn't provide the server's estimateNoriko Hosoi2010-08-048-6/+81
| | | | | | | | | | | | | | | | | of the total number of entries https://bugzilla.redhat.com/show_bug.cgi?id=513166 Description: By definition, the first integer of the response control is for the estimated search result set size. This fix sets the estimated result set size. * controlType = LDAP_CONTROL_PAGEDRESULTS; * criticality = n/a; * controlValue: * realSearchControlValue ::= SEQUENCE { * size INTEGER (0..maxInt), * -- result set size estimate from server * cookie OCTET STRING
* Bug 617862 - Replication: Unable to delete tombstone errorsRich Megginson2010-08-031-1/+1
| | | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=617862 Resolves: bug 617862 Bug Description: Replication: Unable to delete tombstone errors Reviewed by: nhosoi (Thanks!) Branch: master Fix Description: In the case of deletion of a tombstone entry, the target entry 'e' is the tombstone entry. 'tombstone' is not used for this purpose. Platforms tested: RHEL5 x86_64 Flag Day: no Doc impact: no (cherry picked from commit 84e6cc2ffd7a3aa684959d22e6fc2ab3a15791de)
* 619595 - Upgrading sub suffix under non-normalized suffix disappearsNoriko Hosoi2010-07-291-42/+28
| | | | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=619595 Fix Description: The cause of this problem is the config attribute nsslapd-parent-suffix was not defined as an attribute of DN syntax. Because of the missing definition, the value is not the target of the DN normalization and the match fails after upgraded. Adding the attribute to the schema solves this problem. Plus upgradedb does backup the DB before upgrade, and if it fails it restores from the backed up DB. Use dblayer_restore instead of copying DB files one by one.
* 616608 - SIGBUS in RDN index reads on platforms with strict alignmentsNoriko Hosoi2010-07-274-91/+126
| | | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=616608 Fix description: Use the marshall/unmarshall technique for the entryrdn index data. Introduced sizeushort_internal_to_stored/sizeushort_stored_to_internal for the size data to store in 2 bytes. Entryrdn related functions in the dbscan utility are also modified to support marshalled data. Reviewed by ulf.weltman@hp.com and fixed bugs found by him.
* 610281 - fix coverity Defect Type: Control flow issuesNoriko Hosoi2010-07-231-65/+61
| | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=610281 11958 NO_EFFECT Triaged Unassigned Bug Moderate Fix Required do_bind() ds/ldap/servers/slapd/bind.c Comment: slapi_dn_normalize_ext() may return a negative value but rc is of type ber_tag_t which is an unsigned int. Introducing "ber_tag_t ber_rc" just for ber functions and "int rc" for the rest.