summaryrefslogtreecommitdiffstats
path: root/ldap/servers/slapd/back-ldbm
Commit message (Collapse)AuthorAgeFilesLines
...
* Bug 611790 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-231-0/+2
| | | | | | | | | 11940 - 12166 https://bugzilla.redhat.com/show_bug.cgi?id=611790 Resolves: bug 611790 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166 Fix description: Catch possible NULL pointer in dblayer_sys_pages().
* Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues ↵Noriko Hosoi2010-08-231-14/+31
| | | | | | | | | | 12167 - 12199 https://bugzilla.redhat.com/show_bug.cgi?id=610119 Resolves: bug 610119 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199 Fix description: Catch possible NULL pointer in ldbm_instance_index_config_modify_callback() and ldbm_instance_config_add_index_entry().
* Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues ↵Noriko Hosoi2010-08-231-14/+17
| | | | | | | | | 12167 - 12199 https://bugzilla.redhat.com/show_bug.cgi?id=610119 Resolves: bug 610119 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199 Fix description: Catch possible NULL pointer in index_range_read().
* Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-231-4/+12
| | | | | | | | | 12167 - 12199 https://bugzilla.redhat.com/show_bug.cgi?id=610119 Resolves: bug 610119 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199 Fix description: Catch possible NULL pointer in vlv_init().
* Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues ↵Noriko Hosoi2010-08-232-16/+24
| | | | | | | | | | | 12167 - 12199 https://bugzilla.redhat.com/show_bug.cgi?id=610119 Resolves: bug 610119 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199 Fix description: Catch possible NULL pointer in ldbm_back_ldbm2ldif(), ldbm_back_upgradedb(), upgradedb_copy_logfiles(). coverity ID: 12190
* Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-231-3/+8
| | | | | | | | | 12167 - 12199 https://bugzilla.redhat.com/show_bug.cgi?id=610119 Resolves: bug 610119 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199 Fix description: Catch possible NULL pointer in ldbm_back_modify().
* Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-231-5/+22
| | | | | | | | | | 12167 - 12199 https://bugzilla.redhat.com/show_bug.cgi?id=610119 Resolves: bug 610119 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199 Fix description: Catch possible NULL pointer in ldbm_instance_config_load_dse_info() and ldbm_instance_modify_config_entry_callback().
* Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-231-0/+9
| | | | | | | | | 12167 - 12199 https://bugzilla.redhat.com/show_bug.cgi?id=610119 Resolves: bug 610119 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199 Fix description: Catch possible NULL pointer in ldbm_config_load_dse_info().
* Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues ↵Noriko Hosoi2010-08-231-6/+2
| | | | | | | | | | | | 12167 - 12199 https://bugzilla.redhat.com/show_bug.cgi?id=610119 Resolves: bug 610119 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199 Fix description: Remove unnecessary NULL pointer checking in attrcrypt_keymgmt_store_key(). coverity ID: 12168
* Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-231-1/+6
| | | | | | | | | 12167 - 12199 https://bugzilla.redhat.com/show_bug.cgi?id=610119 Resolves: bug 610119 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199 Fix description: Catch possible NULL pointer in import_grok_db_stats().
* Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-231-4/+12
| | | | | | | | | | 12167 - 12199 https://bugzilla.redhat.com/show_bug.cgi?id=610119 Resolves: bug 610119 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199 Fix description: Catch possible NULL pointer in import_producer(), upgradedn_producer(), bulk_import_queue(), and dse_conf_backup_core().
* Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-231-28/+44
| | | | | | | | | 12167 - 12199 https://bugzilla.redhat.com/show_bug.cgi?id=610119 Resolves: bug 610119 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199 Fix description: Catch possible NULL pointer in check_entry_for_referral().
* Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-231-2/+10
| | | | | | | | | 12167 - 12199 https://bugzilla.redhat.com/show_bug.cgi?id=610119 Resolves: bug 610119 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199 Fix description: Catch possible NULL pointer in dblayer_copy_file_keybykey() and dblayer_copy_file_resetlsns().
* Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues 11892Noriko Hosoi2010-08-201-6/+21
| | | | | | | | | | - 11939 https://bugzilla.redhat.com/show_bug.cgi?id=613056 Resolves: bug 613056 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939 description: Catch possible NULL pointer in vlv_create_key() and vlv_trim_candidates(). coverity ID: 11926
* Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues ↵Noriko Hosoi2010-08-201-4/+8
| | | | | | | | | | 11892 - 11939 https://bugzilla.redhat.com/show_bug.cgi?id=613056 Resolves: bug 613056 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939 description: Catch possible NULL pointer in index_producer() and upgradedn_producer(). coverity ID: 11919
* Bug 616500 - fix coverify Defect Type: Resource leaks issues CID 12094 - 12136Endi S. Dewata2010-08-201-0/+3
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=616500 Resolves: bug 616500 Bug description: fix coverify Defect Type: Resource leaks issues CID 12095, 12096, 12097. description: Fixed resource leaks in vlv_AddSearchEntry(), vlv_init_index_entry(), and vlv_init_search_entry().
* Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-201-1/+1
| | | | | | | | | 11892 - 11939 https://bugzilla.redhat.com/show_bug.cgi?id=613056 Resolves: bug 613056 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939 description: Catch possible NULL pointer in vlvSearch_removefromlist().
* Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-201-1/+1
| | | | | | | | | 11892 - 11939 https://bugzilla.redhat.com/show_bug.cgi?id=613056 Resolves: bug 613056 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939 description: Catch possible NULL pointer in ldbm_back_upgradedb().
* Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-201-0/+1
| | | | | | | | | 11892 - 11939 https://bugzilla.redhat.com/show_bug.cgi?id=613056 Resolves: bug 613056 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939 description: Catch possible NULL pointer in ldbm_config_get().
* Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-201-1/+1
| | | | | | | | | 11892 - 11939 https://bugzilla.redhat.com/show_bug.cgi?id=613056 Resolves: bug 613056 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939 description: Catch possible NULL pointer in ldbm_instance_attrcrypt_config_delete_callback().
* Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-201-0/+7
| | | | | | | | | 11892 - 11939 https://bugzilla.redhat.com/show_bug.cgi?id=613056 Resolves: bug 613056 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939 description: Catch possible NULL pointer in attr_index_config().
* Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues ↵Noriko Hosoi2010-08-201-4/+28
| | | | | | | | | | 11892 - 11939 https://bugzilla.redhat.com/show_bug.cgi?id=613056 Resolves: bug 613056 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939 description: The index_index2prefix() has been modified to return NULL when indextype is NULL. All callers have been modified to handle NULL return value.
* Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-201-0/+5
| | | | | | | | | 11892 - 11939 https://bugzilla.redhat.com/show_bug.cgi?id=613056 Resolves: bug 613056 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939 description: Catch possible NULL pointer in import_monitor_threads().
* Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-201-1/+5
| | | | | | | | | 11892 - 11939 https://bugzilla.redhat.com/show_bug.cgi?id=613056 Resolves: bug 613056 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939 description: Catch possible NULL pointer in ava_candidates().
* Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-201-15/+20
| | | | | | | | | 11892 - 11939 https://bugzilla.redhat.com/show_bug.cgi?id=613056 Resolves: bug 613056 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939 description: Catch possible NULL pointer in _dblayer_delete_instance_dir().
* Bug 613056 - fix coverify Defect Type: Null pointer dereferences issues ↵Endi S. Dewata2010-08-201-3/+3
| | | | | | | | | 11892 - 11939 https://bugzilla.redhat.com/show_bug.cgi?id=613056 Resolves: bug 613056 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11892 - 11939 description: Catch possible NULL pointer in ldbm_back_archive2ldbm() and ldbm_back_ldbm2archive().
* Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093Endi S. Dewata2010-08-191-3/+1
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=617630 Resolves: bug 617630 Bug description: fix coverify Defect Type: Resource leaks issues CID 12093, 12094. description: Fixed resource leaks in ldbm_back_ldbm2ldif().
* Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093Endi S. Dewata2010-08-191-2/+6
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=617630 Resolves: bug 617630 Bug description: fix coverify Defect Type: Resource leaks issues CID 12080. description: Fixed resource leaks in ldbm_instance_config_add_index_entry().
* Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093Endi S. Dewata2010-08-191-6/+9
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=617630 Resolves: bug 617630 Bug description: fix coverify Defect Type: Resource leaks issues CID 12070. description: The idl_old_store_block() has been modified to release the master_block when an error occurs.
* Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093Endi S. Dewata2010-08-191-20/+27
| | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=617630 Resolves: bug 617630 Bug description: fix coverify Defect Type: Resource leaks issues CID 12086, 12091, 12092. description: The vlv_build_idl() has been modified to release idl when an error occurs. The "if (idl)" near the end of the function is unnecessary because at that point idl cannot be NULL. The "if (candidate)" has been inverted to catch NULL pointer. The vlv_filter_candidates() and the vlv_trim_candidates() have been modified to check for NULL filteredCandidates in the beginning to avoid resource leaks.
* Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093Endi S. Dewata2010-08-191-4/+6
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=617630 Resolves: bug 617630 Bug description: fix coverify Defect Type: Resource leaks issues CID 12084, 12085. description: range_candidates() has been modified to release highs if an error occurs.
* Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093Endi S. Dewata2010-08-191-9/+22
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=617630 Resolves: bug 617630 Bug description: fix coverify Defect Type: Resource leaks issues CID 12079. description: ldbm_instance_create() has been modified to release inst when an error occurs.
* Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093Endi S. Dewata2010-08-191-3/+14
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=617630 Resolves: bug 617630 Bug description: fix coverify Defect Type: Resource leaks issues CID 12078 description: index_addordel_values_ext_sv() has been modified to release keys before going out of scope. index_buffer_init_internal() has been modified to release handle when error occurs.
* Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093Endi S. Dewata2010-08-191-6/+10
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=617630 Resolves: bug 617630 Bug description: fix coverify Defect Type: Resource leaks issues CID 12077 description: id2entry_add_ext() has been modified to release resources properly.
* Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093Endi S. Dewata2010-08-191-14/+14
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=617630 Resolves: bug 617630 Bug description: fix coverify Defect Type: Resource leaks issues CID 12075, 12076. description: import_merge_make_new_queue_entry() and import_merge_one_file() have been modified to release resources when error occurs.
* Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093Endi S. Dewata2010-08-191-5/+16
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=617630 Resolves: bug 617630 Bug description: fix coverify Defect Type: Resource leaks issues CID 12072, 12088, 12089. description: dse_conf_verify_core() has been modified to release estr before continuing the loop. import_worker() has been modified to release substring_key_buffer before returning. upgradedn_producer() has been modified to release the older data.data and ecopy before reallocating the new ones and before returning.
* Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093Endi S. Dewata2010-08-191-12/+12
| | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=617630 Resolves: bug 617630 Bug description: fix coverify Defect Type: Resource leaks issues CID 12071. description: perfctrs_init() has been modified to release unused resources when error occurs.
* Bug 622903 - fix coverity Defect Type: Code maintainability issuesNoriko Hosoi2010-08-111-2/+0
| | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=622903 Comment: Calling slapi_sdn_get_dn and assigning the return value to base is not needed.
* Bug 622903 - fix coverity Defect Type: Code maintainability issuesNoriko Hosoi2010-08-111-4/+3
| | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=622903 Comment: The "p" assignments on line 260, 264, and 268 can be removed because they are not needed.
* Bug 622903 - fix coverity Defect Type: Code maintainability issuesNoriko Hosoi2010-08-111-5/+0
| | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=622903 Comment: Pointer "log_dir" returned by "dblayer_get_home_dir" is never used (line 1492). Removing the unnecessary else clause.
* Bug 622628 - fix coverity Defect Type: Integer handling issuesNoriko Hosoi2010-08-101-1/+1
| | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=622628 Comment: slapd_system_strerror does not cover the return codes from the libdb functions. Instead, use dblayer_strerror for describing error number.
* Bug 194531 - db2bak is too noisyNoriko Hosoi2010-08-101-17/+17
| | | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=194531 Description: Introduced "-q" option to suppress the backing up/ restoring message for each db file. Usage: db2bak [archivedir] [-q] [-h] Usage: bak2db archivedir [-n backendname] [-q] | [-h] If "-q" is specified, the verbose messages are not prited to the standard error, but just to the errors log. In addition, new log level SLAPI_LOG_BACKLDBM/LDAP_DEBUG_BACKLDBM has been introduced.
* 621928 - Unable to enable replica (rdn problem?) on 1.2.6 rc6Noriko Hosoi2010-08-092-13/+271
| | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=621928 Description: RUV (nsuniqueid=ffffffff-ffffffff-ffffffff-ffffffff,<suffix>) needs to be allowed to add to the DB before <suffix> is added. To allow it, entryrdn prepares the rdn exception list (rdn_exceptions). If the to-be-added entry (in this case RUV; and currently only RUV is in the list) is in the list, <suffix> is added to the entryrdn index with the temporary entry ID 0 (note: not to the primary db file id2entry.db#). When the suffix is indeed added to the DB, the temporary ID 0 is replaced with the given real ID.
* 513166 - Simple Paged result doesn't provide the server's estimateNoriko Hosoi2010-08-041-0/+17
| | | | | | | | | | | | | | | | | of the total number of entries https://bugzilla.redhat.com/show_bug.cgi?id=513166 Description: By definition, the first integer of the response control is for the estimated search result set size. This fix sets the estimated result set size. * controlType = LDAP_CONTROL_PAGEDRESULTS; * criticality = n/a; * controlValue: * realSearchControlValue ::= SEQUENCE { * size INTEGER (0..maxInt), * -- result set size estimate from server * cookie OCTET STRING
* Bug 617862 - Replication: Unable to delete tombstone errorsRich Megginson2010-08-031-1/+1
| | | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=617862 Resolves: bug 617862 Bug Description: Replication: Unable to delete tombstone errors Reviewed by: nhosoi (Thanks!) Branch: master Fix Description: In the case of deletion of a tombstone entry, the target entry 'e' is the tombstone entry. 'tombstone' is not used for this purpose. Platforms tested: RHEL5 x86_64 Flag Day: no Doc impact: no (cherry picked from commit 84e6cc2ffd7a3aa684959d22e6fc2ab3a15791de)
* 619595 - Upgrading sub suffix under non-normalized suffix disappearsNoriko Hosoi2010-07-291-42/+28
| | | | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=619595 Fix Description: The cause of this problem is the config attribute nsslapd-parent-suffix was not defined as an attribute of DN syntax. Because of the missing definition, the value is not the target of the DN normalization and the match fails after upgraded. Adding the attribute to the schema solves this problem. Plus upgradedb does backup the DB before upgrade, and if it fails it restores from the backed up DB. Use dblayer_restore instead of copying DB files one by one.
* 616608 - SIGBUS in RDN index reads on platforms with strict alignmentsNoriko Hosoi2010-07-273-76/+100
| | | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=616608 Fix description: Use the marshall/unmarshall technique for the entryrdn index data. Introduced sizeushort_internal_to_stored/sizeushort_stored_to_internal for the size data to store in 2 bytes. Entryrdn related functions in the dbscan utility are also modified to support marshalled data. Reviewed by ulf.weltman@hp.com and fixed bugs found by him.
* 610281 - fix coverity Defect Type: Control flow issuesNoriko Hosoi2010-07-231-9/+9
| | | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=610281 11829 DEADCODE Triaged Unassigned Bug Minor Fix Required ldbm_back_start() ds/ldap/servers/slapd/back-ldbm/start.c Comment: The code meant the autosized cache should be reduced 25% if the calculated size was less than 500MB for the overhead of libdb. If larger than 500MB, the overhead is relatively small and can be ignored. The code should have calculated the size before comparing it to 500MB.
* 610281 - fix coverity Defect Type: Control flow issuesNoriko Hosoi2010-07-231-1/+1
| | | | | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=610281 11826 DEADCODE Triaged Unassigned Bug Minor Fix Required ldbm_back_search() ds/ldap/servers/slapd/back-ldbm/ldbm_search.c Comment: On this path, the condition "abandoned" cannot be true. 504 return ldbm_back_search_cleanup(pb, li, sort_control, 505 (abandoned?-1:LDAP_PROTOCOL_ERROR), 506 "Sort Response Control", -1, 507 &basesdn, &vlv_request_control); Line 505 should be 505 LDAP_PROTOCOL_ERROR,
* 610281 - fix coverity Defect Type: Control flow issuesNoriko Hosoi2010-07-231-8/+1
| | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=610281 11825 DEADCODE Triaged Unassigned Bug Minor Fix Required ldbm_back_modrdn() ds/ldap/servers/slapd/back-ldbm/ldbm_modrdn.c Comment: It was checking if (parententry && parententry->ep_entry) in the if ( parententry == NULL ) clause. Removed the unnecessary code.