summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Bug 630094 - (cov#15455) Remove deadcode in attr_index_config()Nathan Kinder2010-09-091-128/+128
| | | | | | | | | If the index types (argv[1]) are not specified, attr_index_config() bails. We can remove some dead code where we check if "argc == 1" later in the function since that case can never happen. Additionally, we need to check if argc is 0, or if argv is NULL before attempting to parse the list of attributes to be indexed.
* Bug 630094 - (cov#15454) Fix deadcode issue in mapping tree codeNathan Kinder2010-09-091-1/+2
| | | | | | | | | | There is no chance for next_node to be anything other than NULL in the final return statement due to the return in the "if (next_node)" block immediately before the final return. We can remove the return inside of the "if (next_node)" block since the final return statement already deals with returning the proper value if next_node is non-NULL.
* Bug 630094 - (cov#15453) Eliminate NULL check for local_newentryNathan Kinder2010-09-091-1/+1
| | | | | | | | There is no chance for local_newentry to be anything other than NULL when we check it in the call to slapi_log_error() since the check only happens after we're verified that newparent and local_origsdn are not NULL. Since we are guaranteed that local_newentry is NULL, we can just eliminate this check and use the string "local entry" in the message that we print.
* Bug 630094 - (cov#15452) Remove NULL checking for op_stringNathan Kinder2010-09-091-26/+27
| | | | | | | | | | | There is no chance for op_string to be NULL if "rc == LDAP_SUCCESS" since op_string is set for all operation types in the switch statement, which is the only place that rc can be set to something other that the value of -1 that it is initialized to. We can just skip the NULL checking for op_string in the calls to slapi_log_error(). I also fixed the indentation to help me read the code easier.
* Bug 630094 - (cov#15451) Get rid of unreachable free statementsNathan Kinder2010-09-091-9/+0
| | | | | | | | | We need to remove the last "if (dnParts)" condition since it will never be true. The last frees of newDN, sval, and newvalue are also unnecessary since they are only set in the non subtree rename case, where they are already freed as well.
* Bug 630094 - (cov#11818) Fix unreachable return in snmp subagentNathan Kinder2010-09-091-17/+33
| | | | | | | | | | | | The return statement at the end of agt_mopen_stats() is unreachable according to coverity. This return was removed before to fix the coverity defect, but it was added back to fix a compiler warning. We can satisfy both the compiler and coverity by adding a rc variable to hold the return code. We can then return rc at the end of the function. This also allows us to clean up all of the return calls in this function by having all of them set rc and jump to a label at the function end.
* Bug 630090 - (cov#15445) Fix illegal free in archive codeNathan Kinder2010-09-091-1/+2
| | | | | | | | | | | The directory variable points to a dynamically allocated string returned by rel2abspath(). We are changing directory to point to a string constant if we are unable to parse the directory. This not only leaks memory, but it can cause us to attempt to free the string constant. We should free the string before we overwrite it, and we should dynamically allocate a new string instead of using a string constant.
* Bug 630090 - (cov#11974) Remove unused ACL functionsNathan Kinder2010-09-094-657/+3
| | | | | | | | | | | | | Coverity flagged a memory corruption issue in an old unused ACL function. It is best to just remove these unused functions. The functions removed are: ACL_ParseFile ACL_WriteFile ACL_WriteString ACL_Decompose acl_to_str_* acl_decompose_*
* Bug 630096 - (cov#15447) - Check return value of idl_append_extend()Nathan Kinder2010-09-081-2/+13
| | | | | | | | | | | We should check the return type of idl_append_extend(), though it does not seem possible that the return type will be anything other than 0. The only time idl_append_extend() returns anything other than 0 is when it is unable to allocate memory. Since the underlying allocation function is slapi_ch_calloc(), the server will just exit if it runs out of memory, which means we will never return up through idl_append_extend(). The right thing to do from a code standpoint is to still check for the return value though.
* Bug 630096 - (cov#15448) Check return value of cache_replace()Nathan Kinder2010-09-081-1/+6
| | | | | | | | | | | We need to check the return value of cache_replace() in id2entry_add_ext(). The only possible error that can be returned is when the entry we are trying to replace is not found in the cache. This should not occur since we are told that the entry already exists by CACHE_ADD() just prior to this call. If we run into this situation, we will just log an error without adding the entry to the cache. This shouldn't be a big deal since the entry will get added to the cache next time it is accessed.
* Bug 630096 - (cov#15449,15450) Check return value of stat()Nathan Kinder2010-09-082-4/+8
| | | | | | We were not checking the return value of stat() before attempting to access the structure that stat fille in in the protect_db code. This patch checks the return value first.
* Bug 630096 - (cov#15446) check return value of ber_scanf()Nathan Kinder2010-09-081-1/+4
| | | | | | | We were not checking the return value of ber_scanf in the DNA plug-in when parsing the range transfer response. This checks the return value and sets the return code to LDAP_PROTOCOL_ERROR if we were unable to parse the range transfer response.
* Bug 630096 - (cov#11778) check return value of ldap_parse_resultNathan Kinder2010-09-081-2/+15
| | | | | | | | | We were not checking the return value of ldap_parse_result in the windows_check_user_password() function. The old code was a bit unclear about setting rc when we encountered errors from ldap_result(). It also was calling ldap_parse_result() even if ldap_result() encountered an error. I fixed this code to be a bit more straightforward.
* Bug 630093 - (cov#15518) Need to intialize fd in ldbm2ldif codeNathan Kinder2010-09-081-4/+3
| | | | | | | | | | | Currently, the ldbm_back_ldbm2ldif() function could bail due to an error before fd is set. We then attempt to close the file that fd refers to. We should initialize fd to STDOUT_FILENUM, as we skip calling close() if fd is set to STDOUT_FILENUM. Additionally, I noticed that we could call close() when fd is negative or if it is STDERR or STDIN. I fixed this so close() is not called in those cases.
* Bug 630093 - (cov#15511) Don't use unintialized search_results in refint pluginNathan Kinder2010-09-081-64/+63
| | | | | | | | | | | The refint plug-in code currently looks as if it could use the search_result variable when it is uninitialized. I don't believe that this is possible since it would require the filter variable to be NULL, which should not occur since slapi_ch_smprintf() would make the process exit if it failed to allocate memory. Even so, the correct thing to do from a code cleanliness standpoint is to move all code that assumes we performed a search into the "if (filter)" block.
* Have to explicitly set protocol version to 3Rich Megginson2010-09-031-0/+5
| | | | | openldap requires that the protocol version be explicitly set to 3 mozldap defaults to 3, but it doesn't hurt to set it again
* Bug 630098 - fix coverity Defect Type: Code maintainability issuesNathan Kinder2010-09-031-2/+0
| | | | | (cov#15521) The oldndn variable was unused in the dncache_replace() function. This patch removes the unused variable.
* Bug 630098 - fix coverity Defect Type: Code maintainability issuesNathan Kinder2010-09-031-2/+0
| | | | | (cov#15521) The newndn variable was unused in the dncache_replace() function. This patch removes the unused variable.
* use slapi_mods_init_passin/get_ldapmods_passout if modifying the smodsRich Megginson2010-09-031-2/+2
| | | | | | | When using slapi_mods_init_byref/get_ldapmods_byref, the slapi_mods code expects the Slapi_Mods to be read-only. Since the usn code adds a mod to the list, it needs to use the slapi_mods_init_passin/get_ldapmods_passout APIs. This avoids an assertion when using --enable-debug.
* Bug 629710 - escape_string does not check '\<HEX><HEX>'Noriko Hosoi2010-09-021-16/+30
| | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=629710 Resolves: 629710 Description: do_escape_string (core of escape_string) converts '\\ (backslash)' to '\5C' even if the following 2 characters are hex digits. That is, the character is already escaped. This patch checks the case and if it is, it does not escape it further.
* Bug 627738 - The cn=monitor statistics entries for the dnentry cacheNoriko Hosoi2010-09-021-3/+4
| | | | | | | | | | | | | do not change or change very rarely https://bugzilla.redhat.com/show_bug.cgi?id=627738 Description: Change made in this commit: cc36301a7cae6737d9f8a0e53bed653a52130a1d for the following bug introduced a missing-cache-return bug: id2entry_add_ext replaces an dn instance in the dn cache even if the DN value is identical. Replace it only when they don't match. Thanks to andrey.ivanov@polytechnique.fr for finding it out: https://bugzilla.redhat.com/show_bug.cgi?id=627738#c5
* fix compiler warnings - unused vars/funcs, invalid castsRich Megginson2010-09-0130-382/+36
| | | | | | | | | This commit fixes many compiler warnings, mostly for things like unused variables, functions, goto labels. One place was using csngen_free instead of csn_free. A couple of places were using casts incorrectly, and several places needed some casts added. Tested on: RHEL5 x86_64, Fedora 14 x86_64 Reviewed by: nkinder (Thanks!)
* bug 614511 - fix coverity null reference - revert macro aci $dn logicRich Megginson2010-09-011-4/+6
| | | | | | instead of changing the logic to catch matched_val == NULL, make the code work like it does in earlier releases, but add an explicit check for matched_val == NULL to avoid using it.
* pass the string copy to slapi_dn_normalize_originalRich Megginson2010-09-011-2/+2
| | | | | | slapi_dn_normalize_original can modify the argument string, so we cannot pass in a const char *rawdn to that function - instead, pass in a copy created by slapi_ch_strdup
* use slapi_pblock_set to set the ldap result code for the be postop pluginsRich Megginson2010-09-012-2/+2
| | | | | use slapi_pblock_set to set the ldap result code for the be postop plugins instead of slapi_pblock_get
* Bug 612264 - ACI issue with (targetattr='userPassword')Nathan Kinder2010-09-011-5/+10
| | | | | | | | | | | | | | If an ACI has a targetattr of userPassword and uses the USERDN keyword, the ACI may not be evaluated correctly for password change operations. This is caused by the fact that we use a dummy target entry to check if the pasword change is allowed early in the operation. This dummy entry will not have any attributes that the ACI may use. The fix is to actually fetch the target entry with all of it's attributes. We still create a dummy entry if the target doesn't exist to prevent returning a no such entry error when we should be returning an access denied or insufficient access error.
* DN normalizer should check the invalid typeNoriko Hosoi2010-08-311-0/+4
| | | | | | | File: ldap/servers/slapd/dn.c Description: slapi_dn_normalize_ext failed to check a typical invald DN (e.g., "bogus,dc=example,dc=com"), in which RDN does not have the type=value format. The problem is fixed.
* implement slapi_ldap_explode_dn and slapi_ldap_explode_rdnRich Megginson2010-08-3116-42/+306
| | | | | | | | | | | | The DS has some problems with the openldap versions of these functions: 1) They are deprecated - should use the str2[r]dn and [r]dn2str and the bv versions of those functions instead 2) They escape utf-8 and other values in the strings - the mozldap functions do not do this 3) They handle double quoted strings, but they remove the quotes - our code expects the quotes to be left in place Until we fix our DN handling, and get rid of the double quoted DNs, we just use the mozldap versions of these functions.
* do not un-null-terminate normalized DN until new url is constructedRich Megginson2010-08-311-27/+21
| | | | | | rawdn may be normalized in place - if we add back the '?' to the URL before we construct the new URL with the normalized DN, we will create a bogus URL string - so delay that until we construct the new URL
* use slapi_ldap_url_parse in the acl codeRich Megginson2010-08-311-8/+33
| | | | | I missed a couple of places in the acl code that should use slapi_ldap_url_parse - I also added some more debugging
* check src < *out only; only check for \nspace if src < *out - 2Rich Megginson2010-08-311-2/+2
| | | | | | | *out will never be NULL here, so we only need to check that src < *out as the loop condition when looking for a continuation line, make sure there are two characters in *out to check
* move the out pointer back if continuation lines were removedRich Megginson2010-08-311-0/+1
| | | | | | when putting ldif data with the no wrap option, if we removed some continuation lines, we have to move the output data pointer back since the continuation line markers are removed in place
* convert mozldap host list to openldap uri listRich Megginson2010-08-311-4/+77
| | | | | | | | mozldap accepts hostnames in the form host1[:port1] ... hostN[:portN] in the ldap_init argument and in ldap urls/uris. DS code uses ldap_initialize() which takes a list of uris in the form ldap[s]://host1[:port1]/ ldap[s]://host2[:port2]/ ... We have to convert the host:port list into a list of LDAP uris
* slapi_ldap_url_parse must handle multiple host:port in urlRich Megginson2010-08-311-5/+94
| | | | | | | mozldap supports a non-standard URL extension which allows multiple host:port combinations - openldap does not support this - fake out openldap by converting spaces to %20 and all but the last colon to %3A before calling ldap_url_parse, then unescape ludp->lud_host before returning
* do not terminate unwrapped LDIF line with another newlineRich Megginson2010-08-311-1/+0
| | | | | The function ldif_sput already terminates the line with a newline character - we do not need to add another one when unwrapping a wrapped line.
* openldap_read_function needs to set EWOULDBLOCK if the buffer is emptyRich Megginson2010-08-311-0/+8
| | | | | | If the openldap_read_function has returned all of the buffered data, it needs to set errno to EWOULDBLOCK to let the code know that it needs to read more data into the buffer.
* have to use LDAP_OPT_X_TLS_NEVER to defeat cert hostname checkingRich Megginson2010-08-311-1/+1
| | | | | | | Even though the ldap.conf man page is not really clear about this, looking at the code in libraries/libldap/tls2.c:ldap_int_tls_start() if you don't specify LDAP_OPT_X_TLS_REQUIRE_CERT as LDAP_OPT_X_TLS_NEVER it will check the hostname
* openldap ldapsearch returns empty line at end of LDIF outputRich Megginson2010-08-313-3/+3
| | | | | | The script was looking for 1 and only 1 line returned by the ldapsearch to see if the given entry is a role. openldap ldapsearch returns an empty line as the last line. So just change the check to look for 1 or more lines.
* add ldaptool_opts for the non BUNDLE case in Makefile.amRich Megginson2010-08-312-0/+2
| | | | forgot to add ldaptool_opts for the non BUNDLE case in Makefile.am
* openldap ldapsearch uses -LLL to suppress # version: NRich Megginson2010-08-3110-7/+21
| | | | | mozldap uses -1 but openldap uses -LLL to suppress printing the in ldapsearch output - add a flag for this
* fix the url_parse logic when looking for a missing suffix DNRich Megginson2010-08-312-2/+5
| | | | | | The logic looking for a missing suffix DN in a parsed URL was incorrect. In addition, since passthru requires a suffix DN, pass the require_dn flag.
* ber_printf 'o' cannot handle NULL bv_valRich Megginson2010-08-311-2/+2
| | | | | | The value passed to the char * argument to ber_printf 'o' must not be a NULL, even if the bv_len argument is 0. An empty string "" must be passed instead.
* use strcasecmp with ptype and type->bv_valRich Megginson2010-08-311-1/+1
| | | | both ptype and type->bv_val are properly null terminated strings
* fix some compiler warningsRich Megginson2010-08-313-2/+1
|
* document slapi wrappers for openldap/mozldap functions that differRich Megginson2010-08-315-13/+101
| | | | | | | There are slapi wrappers that hide differences between the openldap and mozldap ldap and ldif API code. These are now doxygen documented. Reviewed by: nkinder (Thanks!) Platforms tested: Fedora 14 (rawhide)
* use the mozldap versions of the proxy auth control create functionRich Megginson2010-08-311-4/+9
| | | | | | Since these functions are present in mozldap, just use them directly Reviewed by: nkinder (Thanks!) Platforms tested: Fedora 14 (rawhide)
* port client tools to use openldap APIRich Megginson2010-08-312-14/+71
| | | | | | | | | There are some differences between the mozldap and the openldap apis: openldap has deprecated ldap_init in favor of ldap_initialize openldap has deprecated the regular ldap op functions in favor of their _ext alternatives Reviewed by: nkinder (Thanks!) Platforms tested: Fedora 14 (rawhide)
* openldap - add support for missing controls, add ldif api, fix NSS usageRich Megginson2010-08-3112-283/+401
| | | | | | | | | | | Added proxy auth control creation - mozldap has a function to do that but not openldap Do not use mozldap filter create function - just create one using slapi_smprintf Fix usage of TLS/SSL with new NSS functionality Created ldif parse wrapper - changed code to use it Reviewed by: nkinder (Thanks!) Platforms tested: Fedora 14 (rawhide)
* Add -x option to ldap tools when using openldapRich Megginson2010-08-3131-21040/+31485
| | | | | | | | | | We have many scripts that use ldapsearch, ldapmodify, etc. All of these currently use simple auth. When using the openldap versions of these scripts, we have to pass the -x argument to use simple auth. A new configure parameter ldaptool_opts is used to pass this down into the scripts. Reviewed by: nkinder (Thanks!) Platforms tested: Fedora 14 (rawhide)
* fix memleak in ldbm_config_read_instance_entriesRich Megginson2010-08-311-0/+1
| | | | | | need to free basedn after use by the internal search Reviewed by: nkinder (Thanks!) Platforms tested: Fedora 14 (rawhide)
generated by cgit (git 2.34.1) at 2025-09-03 22:55:46 +0000