summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNoriko Hosoi <nhosoi@redhat.com>2010-08-25 23:19:02 -0700
committerNoriko Hosoi <nhosoi@redhat.com>2010-08-25 23:27:39 -0700
commit50aff5657fb42d2b4b97e19eefcaa70d2464c694 (patch)
tree7a826c8c55abb750cdc499eedea6e133f00c66b2
parentd6f0a9eb0af247fbbbdbda6761c655158373a557 (diff)
downloadds-50aff5657fb42d2b4b97e19eefcaa70d2464c694.tar.gz
ds-50aff5657fb42d2b4b97e19eefcaa70d2464c694.tar.xz
ds-50aff5657fb42d2b4b97e19eefcaa70d2464c694.zip
Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093
https://bugzilla.redhat.com/show_bug.cgi?id=617630 Bug description: CID 12090 was a false positive description: Undo the commit e23c8bd9994d5592738cb44e1c2b426aba7fbd4a
-rw-r--r--ldap/servers/slapd/entrywsi.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/ldap/servers/slapd/entrywsi.c b/ldap/servers/slapd/entrywsi.c
index 4892732d..01c160c2 100644
--- a/ldap/servers/slapd/entrywsi.c
+++ b/ldap/servers/slapd/entrywsi.c
@@ -475,6 +475,7 @@ entry_add_present_values_wsi(Slapi_Entry *e, const char *type, struct berval **b
/* Append the pending values to a->a_present_values */
valuearray_update_csn (valuestoadd,CSN_TYPE_VALUE_UPDATED,csn);
valueset_add_valuearray_ext(&a->a_present_values, valuestoadd, SLAPI_VALUE_FLAG_PASSIN);
+ slapi_ch_free ( (void **)&valuestoadd );
/*
* Now delete non-RDN values from a->a_present_values; and
@@ -521,11 +522,10 @@ entry_add_present_values_wsi(Slapi_Entry *e, const char *type, struct berval **b
}
valuearray_update_csn(valuestoadd,CSN_TYPE_VALUE_UPDATED,csn);
retVal= attr_add_valuearray(a, valuestoadd, slapi_entry_get_dn_const(e));
+ valuearray_free(&valuestoadd);
}
a->a_flags = a_flags_orig;
}
-
- valuearray_free(&valuestoadd);
return(retVal);
}