summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEndi S. Dewata <edewata@redhat.com>2010-08-03 23:10:05 -0500
committerNoriko Hosoi <nhosoi@redhat.com>2010-08-19 17:01:47 -0700
commit65d3c8f1a2bafa9c06b4cb3b5376db6a661e7709 (patch)
treecb744e685592fdeace4945b361cb294c61a64e8b
parent0ebfd2fd75c4fb202cd91c41ccc7af3bf0b3709a (diff)
downloadds-65d3c8f1a2bafa9c06b4cb3b5376db6a661e7709.tar.gz
ds-65d3c8f1a2bafa9c06b4cb3b5376db6a661e7709.tar.xz
ds-65d3c8f1a2bafa9c06b4cb3b5376db6a661e7709.zip
Bug 617630 - fix coverify Defect Type: Resource leaks issues CID 12052 - 12093
https://bugzilla.redhat.com/show_bug.cgi?id=617630 Resolves: bug 617630 Bug description: fix coverify Defect Type: Resource leaks issues CID 12093, 12094. description: Fixed resource leaks in ldbm_back_ldbm2ldif().
-rw-r--r--ldap/servers/slapd/back-ldbm/ldif2ldbm.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/ldap/servers/slapd/back-ldbm/ldif2ldbm.c b/ldap/servers/slapd/back-ldbm/ldif2ldbm.c
index ae59a773..64c910c1 100644
--- a/ldap/servers/slapd/back-ldbm/ldif2ldbm.c
+++ b/ldap/servers/slapd/back-ldbm/ldif2ldbm.c
@@ -1194,7 +1194,6 @@ ldbm_back_ldbm2ldif( Slapi_PBlock *pb )
if ((( dblayer_get_id2entry( be, &db )) != 0) || (db == NULL)) {
LDAPDebug( LDAP_DEBUG_ANY, "Could not open/create id2entry\n",
0, 0, 0 );
- ldbm_back_free_incl_excl(include_suffix, exclude_suffix);
return_value = -1;
goto bye;
}
@@ -1217,7 +1216,6 @@ ldbm_back_ldbm2ldif( Slapi_PBlock *pb )
LDAPDebug2Args(LDAP_DEBUG_ANY,
"Failed to get cursor for db2ldif; %s (%d)\n",
dblayer_strerror(return_value), return_value);
- ldbm_back_free_incl_excl(include_suffix, exclude_suffix);
return_value = -1;
goto bye;
}
@@ -1517,7 +1515,6 @@ ldbm_back_ldbm2ldif( Slapi_PBlock *pb )
}
dblayer_release_id2entry( be, db );
- ldbm_back_free_incl_excl(include_suffix, exclude_suffix);
if (fd != FD_STDOUT) {
close(fd);
@@ -1543,6 +1540,7 @@ ldbm_back_ldbm2ldif( Slapi_PBlock *pb )
}
bye:
+ ldbm_back_free_incl_excl(include_suffix, exclude_suffix);
idl_free(eargs.pre_exported_idl);
if (inst != NULL) {
PR_Lock(inst->inst_config_mutex);