diff options
| author | Endi S. Dewata <edewata@redhat.com> | 2010-07-02 00:20:16 -0500 |
|---|---|---|
| committer | Noriko Hosoi <nhosoi@redhat.com> | 2010-08-23 11:06:00 -0700 |
| commit | 387ace29a50ac1a4c8c8958c71250b7bb7082ea5 (patch) | |
| tree | 136183c41bbd570687f6014fdfb18482352a2c6e | |
| parent | ca2f99b78387c0e5f5f91c7c1951958cdf3b6c09 (diff) | |
| download | ds-387ace29a50ac1a4c8c8958c71250b7bb7082ea5.tar.gz ds-387ace29a50ac1a4c8c8958c71250b7bb7082ea5.tar.xz ds-387ace29a50ac1a4c8c8958c71250b7bb7082ea5.zip | |
Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199
https://bugzilla.redhat.com/show_bug.cgi?id=610119
Resolves: bug 610119
Bug description: Fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199
Fix description: Catch possible NULL pointer in readAttrValue().
| -rw-r--r-- | ldap/servers/slapd/tools/ldclt/scalab01.c | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/ldap/servers/slapd/tools/ldclt/scalab01.c b/ldap/servers/slapd/tools/ldclt/scalab01.c index 397099aa..c0437b08 100644 --- a/ldap/servers/slapd/tools/ldclt/scalab01.c +++ b/ldap/servers/slapd/tools/ldclt/scalab01.c @@ -703,11 +703,19 @@ readAttrValue ( */ attrs[0] = attname; attrs[1] = NULL; + filter = (char *)malloc((4+strlen(attname))*sizeof(char)); + if (NULL == filter) + { + printf ("ldclt[%d]: %s: Out of memory\n", mctx.pid, ident); + fflush (stdout); + return (-1); + } + sprintf(filter, "(%s=*)", attname); ret = ldap_search_ext_s (ldapCtx, dn, LDAP_SCOPE_BASE, filter, attrs, 0, NULL, NULL, NULL, -1, &res); - if (filter != NULL) free(filter); + free(filter); if (ret != LDAP_SUCCESS) { printf ("ldclt[%d]: %s: Cannot ldap_search (%s in %s), error=%d (%s)\n", |