ds.git/lib, branch warnings

fix compiler warnings - unused vars/funcs, invalid casts

2010-09-01T17:50:05+00:00

This commit fixes many compiler warnings, mostly for things like unused
variables, functions, goto labels.
One place was using csngen_free instead of csn_free.  A couple of places
were using casts incorrectly, and several places needed some casts added.

implement slapi_ldap_explode_dn and slapi_ldap_explode_rdn

2010-08-31T19:35:55+00:00

The DS has some problems with the openldap versions of these functions:
1) They are deprecated - should use the str2[r]dn and [r]dn2str and the
bv versions of those functions instead
2) They escape utf-8 and other values in the strings - the mozldap functions
do not do this
3) They handle double quoted strings, but they remove the quotes - our
code expects the quotes to be left in place
Until we fix our DN handling, and get rid of the double quoted DNs, we just
use the mozldap versions of these functions.

Bug 611790 - fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166

2010-08-24T00:08:55+00:00

https://bugzilla.redhat.com/show_bug.cgi?id=611790
Resolves: bug 611790
Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166
Fix description: Catch possible NULL pointer in ResHashCreate().

Bug 611790 - fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166

2010-08-24T00:08:48+00:00

https://bugzilla.redhat.com/show_bug.cgi?id=611790
Resolves: bug 611790
Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166
Fix description: Catch possible NULL pointer in ldapu_cert_mapfn_default().

Bug 611790 - fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166

2010-08-23T23:38:53+00:00

https://bugzilla.redhat.com/show_bug.cgi?id=611790
Resolves: bug 611790
Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166
Fix description: Use the right pointer in LASIpAddPattern().
coverity ID: 11945

Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199

2010-08-23T18:07:37+00:00

https://bugzilla.redhat.com/show_bug.cgi?id=610119
Resolves: bug 610119
Bug description: Fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199
Fix description: Catch possible NULL pointer in acl_usr_cache_insert().

Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199

2010-08-23T18:07:31+00:00

https://bugzilla.redhat.com/show_bug.cgi?id=610119
Resolves: bug 610119
Bug description: Fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199
Fix description: Catch possible NULL pointer in LASDnsBuild().

Bug 616500 - fix coverity Defect Type: Resource leaks issues

2010-08-20T21:55:12+00:00

CID 12094 - 12136

https://bugzilla.redhat.com/show_bug.cgi?id=616500

coverity 12125
Comment:
This function (ldapu_certinfo_save) is not used - just get rid of it
Removing unused functions from lib/ldaputil/certmap.c
  ldapu_certinfo_save, ldapu_certinfo_modify, ldapu_certinfo_delete
Also, removing obsolete test codes: lib/ldaputil/utest.

Bug 616500 - fix coverity Defect Type: Resource leaks issues CID 12094 - 12136

2010-08-20T20:07:37+00:00

https://bugzilla.redhat.com/show_bug.cgi?id=616500

coverity ID 12135
Comment: Getting rid of unused functions fopen_l and fclose_l
from lib/libadmin/util.c.

Bug 616500 - fix coverity Defect Type: Resource leaks issues CID 12094 - 12136

2010-08-20T20:07:01+00:00

https://bugzilla.redhat.com/show_bug.cgi?id=616500

coverity ID 12131
Comment: ACL_AuthInfoSetDbname(lib/libaccess/register.cpp) --
free dbtype in the error cases.