ds.git/lib/libaccess, branch warnings Unnamed repository; edit this file to name it for gitweb. fix compiler warnings - unused vars/funcs, invalid casts 2010-09-01T17:50:05+00:00 Rich Megginson rmeggins@redhat.com 2010-09-01T03:17:30+00:00 e89048c403090ad87ff0ee963f09865945196dbc This commit fixes many compiler warnings, mostly for things like unused variables, functions, goto labels. One place was using csngen_free instead of csn_free. A couple of places were using casts incorrectly, and several places needed some casts added. 
This commit fixes many compiler warnings, mostly for things like unused
variables, functions, goto labels.
One place was using csngen_free instead of csn_free.  A couple of places
were using casts incorrectly, and several places needed some casts added.
Bug 611790 - fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166 2010-08-23T23:38:53+00:00 Noriko Hosoi nhosoi@redhat.com 2010-08-23T23:38:53+00:00 a3c4404cf6e1873a47d9e7c86b113bb6b91708b1 https://bugzilla.redhat.com/show_bug.cgi?id=611790 Resolves: bug 611790 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166 Fix description: Use the right pointer in LASIpAddPattern(). coverity ID: 11945 
https://bugzilla.redhat.com/show_bug.cgi?id=611790
Resolves: bug 611790
Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11940 - 12166
Fix description: Use the right pointer in LASIpAddPattern().
coverity ID: 11945
Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199 2010-08-23T18:07:37+00:00 Endi S. Dewata edewata@redhat.com 2010-07-02T05:31:44+00:00 c606cfcecb3d3403dfd3d1a90bd1d2b061eb3b6e https://bugzilla.redhat.com/show_bug.cgi?id=610119 Resolves: bug 610119 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199 Fix description: Catch possible NULL pointer in acl_usr_cache_insert(). 
https://bugzilla.redhat.com/show_bug.cgi?id=610119
Resolves: bug 610119
Bug description: Fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199
Fix description: Catch possible NULL pointer in acl_usr_cache_insert().
Bug 610119 - fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199 2010-08-23T18:07:31+00:00 Endi S. Dewata edewata@redhat.com 2010-07-07T00:18:19+00:00 9020d0a1ba5766ae40d0aefe8b4b46e0e6903ee6 https://bugzilla.redhat.com/show_bug.cgi?id=610119 Resolves: bug 610119 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199 Fix description: Catch possible NULL pointer in LASDnsBuild(). 
https://bugzilla.redhat.com/show_bug.cgi?id=610119
Resolves: bug 610119
Bug description: Fix coverify Defect Type: Null pointer dereferences issues 12167 - 12199
Fix description: Catch possible NULL pointer in LASDnsBuild().
Bug 616500 - fix coverity Defect Type: Resource leaks issues CID 12094 - 12136 2010-08-20T20:07:01+00:00 Noriko Hosoi nhosoi@redhat.com 2010-08-18T19:06:48+00:00 38310cc46336c4a3c238f1c3c43d80610111cd01 https://bugzilla.redhat.com/show_bug.cgi?id=616500 coverity ID 12131 Comment: ACL_AuthInfoSetDbname(lib/libaccess/register.cpp) -- free dbtype in the error cases. 
https://bugzilla.redhat.com/show_bug.cgi?id=616500

coverity ID 12131
Comment: ACL_AuthInfoSetDbname(lib/libaccess/register.cpp) --
free dbtype in the error cases.
Bug 619122 - fix coverify Defect Type: Resource leaks issues CID 11975 - 12053 2010-08-19T21:20:53+00:00 Endi S. Dewata edewata@redhat.com 2010-07-28T17:26:33+00:00 aa86616ef8fa462a064573d1708cbd7202496592 https://bugzilla.redhat.com/show_bug.cgi?id=619122 Resolves: bug 619122 Bug description: fix coverify Defect Type: Resource leaks issues CID 11976. description: The ACLEvalBuildContext() has been modified to release curauthplist when an error occurs. 
https://bugzilla.redhat.com/show_bug.cgi?id=619122
Resolves: bug 619122
Bug description: fix coverify Defect Type: Resource leaks issues CID 11976.
description: The ACLEvalBuildContext() has been modified to release curauthplist when an error occurs.
Bug 622903 - fix coverity Defect Type: Code maintainability issues 2010-08-11T17:48:37+00:00 Noriko Hosoi nhosoi@redhat.com 2010-08-11T17:48:37+00:00 ae1b507266e49ebc2d5bc472b8fc017b2c492b79 https://bugzilla.redhat.com/show_bug.cgi?id=622903 Comment: The result of PR_HashTableAdd() should be checked for NULL value. Applied the change to all the PR_HashTableAdd calls in this file lib/libaccess/register.cpp. 
https://bugzilla.redhat.com/show_bug.cgi?id=622903

Comment:
The result of PR_HashTableAdd() should be checked for NULL value.
Applied the change to all the PR_HashTableAdd calls in this file
lib/libaccess/register.cpp.
609255 - fix coverity Defect Type: Memory - illegal accesses issues 2010-07-08T00:17:19+00:00 Noriko Hosoi nhosoi@redhat.com 2010-07-01T18:39:47+00:00 e9a26dca776e3d812ae634fb6d3f2836499d7356 https://bugzilla.redhat.com/show_bug.cgi?id=609255 12241 Triaged Unassigned Bug Minor Fix Required delete_acl_from_file(char *, char *…) ds/lib/libaccess/acltools.cpp 12242 UNINIT Triaged Unassigned Bug Minor Fix Required get_acl_from_file(char *, char *, ACLListHandle **…) ds/lib/libaccess/acltools.cpp 12243 UNINIT Triaged Unassigned Bug Minor Fix Required ACL_FileGetNameList() ds/lib/libaccess/acltools.cpp 12244 UNINIT Triaged Unassigned Bug Minor Fix Required ACL_FileGetNameList() ds/lib/libaccess/acltools.cpp 12245 UNINIT Triaged Unassigned Bug Minor Fix Required rename_acl_in_file(char *, char *, char *…) ds/lib/libaccess/acltools.cpp 12246 UNINIT Triaged Unassigned Bug Minor Fix Required append_acl_to_file(char *, char *, char *…) ds/lib/libaccess/acltools.cpp 12247 UNINIT Triaged Unassigned Bug Minor Fix Required append_acl_to_file(char *, char *, char *…) ds/lib/libaccess/acltools.cpp Comment: ACL_FileRenameAcl, ACL_FileDeleteAcl, ACL_FileGetAcl, ACL_FileSetAcl, ACL_FileMergeAcl, ACL_FileMergeFile and their helper functions are not used. These functions and their helper functions plus libaccess test programs under the directory ./utest are eliminated. 
https://bugzilla.redhat.com/show_bug.cgi?id=609255

12241 Triaged Unassigned Bug Minor Fix Required
delete_acl_from_file(char *, char *…) ds/lib/libaccess/acltools.cpp

12242 UNINIT Triaged Unassigned Bug Minor Fix Required
get_acl_from_file(char *, char *, ACLListHandle **…) ds/lib/libaccess/acltools.cpp

12243 UNINIT Triaged Unassigned Bug Minor Fix Required
ACL_FileGetNameList() ds/lib/libaccess/acltools.cpp

12244 UNINIT Triaged Unassigned Bug Minor Fix Required
ACL_FileGetNameList() ds/lib/libaccess/acltools.cpp

12245 UNINIT Triaged Unassigned Bug Minor Fix Required
rename_acl_in_file(char *, char *, char *…) ds/lib/libaccess/acltools.cpp

12246 UNINIT Triaged Unassigned Bug Minor Fix Required
append_acl_to_file(char *, char *, char *…) ds/lib/libaccess/acltools.cpp

12247 UNINIT Triaged Unassigned Bug Minor Fix Required
append_acl_to_file(char *, char *, char *…) ds/lib/libaccess/acltools.cpp

Comment:
ACL_FileRenameAcl, ACL_FileDeleteAcl, ACL_FileGetAcl, ACL_FileSetAcl,
ACL_FileMergeAcl, ACL_FileMergeFile and their helper functions are
not used.  These functions and their helper functions plus libaccess
test programs under the directory ./utest are eliminated.
609255 - fix coverity Defect Type: Memory - illegal accesses issues 2010-07-08T00:15:38+00:00 Noriko Hosoi nhosoi@redhat.com 2010-06-29T20:33:34+00:00 56c057e2559cec6acf845cb3196eabb1c7363f7e https://bugzilla.redhat.com/show_bug.cgi?id=609255 12300 USE_AFTER_FREE Triaged Unassigned Bug Minor Fix Required append_acl_to_file(char *, char *, char *…) ds/lib/libaccess/acltools.cpp Comment: this code is not used any more. The fix is to have open_file_buf set *buf to NULL after freeing 
https://bugzilla.redhat.com/show_bug.cgi?id=609255

12300 USE_AFTER_FREE Triaged Unassigned Bug Minor Fix Required
append_acl_to_file(char *, char *, char *…) ds/lib/libaccess/acltools.cpp

Comment:
this code is not used any more. The fix is to have open_file_buf set
*buf to NULL after freeing
Bug 611850 - fix coverity Defect Type: Error handling issues 2010-07-06T23:41:20+00:00 Rich Megginson rmeggins@redhat.com 2010-07-06T22:47:45+00:00 85eb9216d5d4163139a90432084452cf81c8444e https://bugzilla.redhat.com/show_bug.cgi?id=611850 Resolves: bug 611850 Bug Description: fix coverity Defect Type: Error handling issues Reviewed by: nhosoi (Thanks!) Branch: HEAD Fix Description: Check the error return from the functions. In some cases, I was able to figure out that the calling function should perform additional error handling (return early, goto error label), but in general the code just logs an appropriate error message and continues. I was able to get rid of some more libacl code. I removed an unused variable from modify.c Platforms tested: RHEL5 x86_64 Flag Day: no Doc impact: no 
https://bugzilla.redhat.com/show_bug.cgi?id=611850
Resolves: bug 611850
Bug Description: fix coverity Defect Type: Error handling issues
Reviewed by: nhosoi (Thanks!)
Branch: HEAD
Fix Description: Check the error return from the functions.  In some cases,
I was able to figure out that the calling function should perform additional
error handling (return early, goto error label), but in general the code
just logs an appropriate error message and continues.  I was able to get
rid of some more libacl code.  I removed an unused variable from modify.c
Platforms tested: RHEL5 x86_64
Flag Day: no
Doc impact: no