ds.git, branch warnings Unnamed repository; edit this file to name it for gitweb. fix compiler warnings - unused vars/funcs, invalid casts 2010-09-01T17:50:05+00:00 Rich Megginson rmeggins@redhat.com 2010-09-01T03:17:30+00:00 e89048c403090ad87ff0ee963f09865945196dbc This commit fixes many compiler warnings, mostly for things like unused variables, functions, goto labels. One place was using csngen_free instead of csn_free. A couple of places were using casts incorrectly, and several places needed some casts added. 
This commit fixes many compiler warnings, mostly for things like unused
variables, functions, goto labels.
One place was using csngen_free instead of csn_free.  A couple of places
were using casts incorrectly, and several places needed some casts added.
use slapi_pblock_set to set the ldap result code for the be postop plugins 2010-09-01T17:49:24+00:00 Rich Megginson rmeggins@redhat.com 2010-09-01T17:49:24+00:00 481ed4a2b5ccd8da5fdff445d36389a546593297 use slapi_pblock_set to set the ldap result code for the be postop plugins instead of slapi_pblock_get 
use slapi_pblock_set to set the ldap result code for the be postop plugins
instead of slapi_pblock_get
Bug 612264 - ACI issue with (targetattr='userPassword') 2010-09-01T17:15:41+00:00 Nathan Kinder nkinder@redhat.com 2010-09-01T17:13:13+00:00 e873a84559ad23cec56370b3d8511f658d476d99 If an ACI has a targetattr of userPassword and uses the USERDN keyword, the ACI may not be evaluated correctly for password change operations. This is caused by the fact that we use a dummy target entry to check if the pasword change is allowed early in the operation. This dummy entry will not have any attributes that the ACI may use. The fix is to actually fetch the target entry with all of it's attributes. We still create a dummy entry if the target doesn't exist to prevent returning a no such entry error when we should be returning an access denied or insufficient access error. 
If an ACI has a targetattr of userPassword and uses the USERDN
keyword, the ACI may not be evaluated correctly for password
change operations.  This is caused by the fact that we use a
dummy target entry to check if the pasword change is allowed early
in the operation.  This dummy entry will not have any attributes
that the ACI may use.

The fix is to actually fetch the target entry with all of it's
attributes.  We still create a dummy entry if the target doesn't
exist to prevent returning a no such entry error  when we should be
returning an access denied or insufficient access error.
DN normalizer should check the invalid type 2010-08-31T20:57:04+00:00 Noriko Hosoi nhosoi@redhat.com 2010-08-31T20:57:04+00:00 bc7df12bbdeade5ba5115e5ea900d16ddd23c046 File: ldap/servers/slapd/dn.c Description: slapi_dn_normalize_ext failed to check a typical invald DN (e.g., "bogus,dc=example,dc=com"), in which RDN does not have the type=value format. The problem is fixed. 
File: ldap/servers/slapd/dn.c
Description: slapi_dn_normalize_ext failed to check a typical
invald DN (e.g., "bogus,dc=example,dc=com"), in which RDN does
not have the type=value format.  The problem is fixed.
implement slapi_ldap_explode_dn and slapi_ldap_explode_rdn 2010-08-31T19:35:55+00:00 Rich Megginson rmeggins@redhat.com 2010-08-27T17:55:29+00:00 8a943175138bbfec0b398ea4ffd24f3047df3951 The DS has some problems with the openldap versions of these functions: 1) They are deprecated - should use the str2[r]dn and [r]dn2str and the bv versions of those functions instead 2) They escape utf-8 and other values in the strings - the mozldap functions do not do this 3) They handle double quoted strings, but they remove the quotes - our code expects the quotes to be left in place Until we fix our DN handling, and get rid of the double quoted DNs, we just use the mozldap versions of these functions. 
The DS has some problems with the openldap versions of these functions:
1) They are deprecated - should use the str2[r]dn and [r]dn2str and the
bv versions of those functions instead
2) They escape utf-8 and other values in the strings - the mozldap functions
do not do this
3) They handle double quoted strings, but they remove the quotes - our
code expects the quotes to be left in place
Until we fix our DN handling, and get rid of the double quoted DNs, we just
use the mozldap versions of these functions.
do not un-null-terminate normalized DN until new url is constructed 2010-08-31T19:35:55+00:00 Rich Megginson rmeggins@redhat.com 2010-08-25T21:31:43+00:00 219b8af89283faae5fb408beb74f082ff7265d34 rawdn may be normalized in place - if we add back the '?' to the URL before we construct the new URL with the normalized DN, we will create a bogus URL string - so delay that until we construct the new URL 
rawdn may be normalized in place - if we add back the '?' to the URL
before we construct the new URL with the normalized DN, we will create
a bogus URL string - so delay that until we construct the new URL
use slapi_ldap_url_parse in the acl code 2010-08-31T19:35:55+00:00 Rich Megginson rmeggins@redhat.com 2010-08-25T18:45:11+00:00 eec41e2fc71addeef503fd6e2294e723e68bf263 I missed a couple of places in the acl code that should use slapi_ldap_url_parse - I also added some more debugging 
I missed a couple of places in the acl code that should use
slapi_ldap_url_parse - I also added some more debugging
check src < *out only; only check for \nspace if src < *out - 2 2010-08-31T19:35:55+00:00 Rich Megginson rmeggins@redhat.com 2010-08-24T19:35:33+00:00 685cb4c361452a26394c897ddaa0b6c2d8040e1d *out will never be NULL here, so we only need to check that src < *out as the loop condition when looking for a continuation line, make sure there are two characters in *out to check 
*out will never be NULL here, so we only need to check that src < *out as
the loop condition
when looking for a continuation line, make sure there are two characters
in *out to check
move the out pointer back if continuation lines were removed 2010-08-31T19:35:54+00:00 Rich Megginson rmeggins@redhat.com 2010-08-24T16:16:36+00:00 ef3d90459a0f43c8e3692cb7ea2cfafe73eb3ba9 when putting ldif data with the no wrap option, if we removed some continuation lines, we have to move the output data pointer back since the continuation line markers are removed in place 
when putting ldif data with the no wrap option, if we removed some
continuation lines, we have to move the output data pointer back since
the continuation line markers are removed in place
convert mozldap host list to openldap uri list 2010-08-31T19:35:54+00:00 Rich Megginson rmeggins@redhat.com 2010-08-23T21:07:51+00:00 b4e420b76d9f3189d3c79476177fadfd02421261 mozldap accepts hostnames in the form host1[:port1] ... hostN[:portN] in the ldap_init argument and in ldap urls/uris. DS code uses ldap_initialize() which takes a list of uris in the form ldap[s]://host1[:port1]/ ldap[s]://host2[:port2]/ ... We have to convert the host:port list into a list of LDAP uris 
mozldap accepts hostnames in the form host1[:port1] ... hostN[:portN]
in the ldap_init argument and in ldap urls/uris.  DS code uses
ldap_initialize() which takes a list of uris in the form
ldap[s]://host1[:port1]/ ldap[s]://host2[:port2]/ ...
We have to convert the host:port list into a list of LDAP uris