From 270daae52b6a96b4d05cbe03e0b31a0b2e4ac1ae Mon Sep 17 00:00:00 2001
From: "Richard W.M. Jones" <rjones@redhat.com>
Date: Thu, 8 Mar 2012 14:49:23 +0000
Subject: inspect_apps: Avoid double-close on error path (found by Coverity)
 (RHBZ#801298).

Error: USE_AFTER_FREE:
/builddir/build/BUILD/libguestfs-1.16.5/src/inspect_apps.c:392: freed_arg: "fclose" frees "fp".
/builddir/build/BUILD/libguestfs-1.16.5/src/inspect_apps.c:404: deref_arg: Calling "fclose" dereferences freed pointer "fp".
---
 src/inspect_apps.c | 1 +
 1 file changed, 1 insertion(+)

(limited to 'src')

diff --git a/src/inspect_apps.c b/src/inspect_apps.c
index 603e25d4..0ee39546 100644
--- a/src/inspect_apps.c
+++ b/src/inspect_apps.c
@@ -392,6 +392,7 @@ list_applications_deb (guestfs_h *g, struct inspect_fs *fs)
 
   if (fclose (fp) == -1) {
     perrorf (g, "fclose: %s", status);
+    fp = NULL;
     goto out;
   }
   fp = NULL;
-- 
cgit