From 109d3ad34aac8d50a1c02437928a64d9bad9f1a6 Mon Sep 17 00:00:00 2001 From: "Richard W.M. Jones" Date: Thu, 8 Mar 2012 10:51:02 +0000 Subject: Dead code: 'lvs' cannot be true here (found by Coverity). Remove dead code; however only comment it out since if we change the preceeding code we may need this line again. Error: DEADCODE: /builddir/build/BUILD/libguestfs-1.16.5/src/listfs.c:107: dead_error_condition: On this path, the condition "lvs" cannot be true. /builddir/build/BUILD/libguestfs-1.16.5/src/listfs.c:54: const: After this line, the value of "lvs" is equal to 0. /builddir/build/BUILD/libguestfs-1.16.5/src/listfs.c:91: const: After this line, the value of "lvs" is equal to 0. /builddir/build/BUILD/libguestfs-1.16.5/src/listfs.c:54: assignment: Assigning: "lvs" = "NULL". /builddir/build/BUILD/libguestfs-1.16.5/src/listfs.c:91: new_values: Noticing condition "lvs == NULL". /builddir/build/BUILD/libguestfs-1.16.5/src/listfs.c:107: dead_error_line: Execution cannot reach this statement "guestfs___free_string_list(...". --- src/listfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/listfs.c') diff --git a/src/listfs.c b/src/listfs.c index 0aef4f99..5ddd1de5 100644 --- a/src/listfs.c +++ b/src/listfs.c @@ -104,7 +104,7 @@ guestfs__list_filesystems (guestfs_h *g) if (devices) guestfs___free_string_list (devices); if (partitions) guestfs___free_string_list (partitions); if (mds) guestfs___free_string_list (mds); - if (lvs) guestfs___free_string_list (lvs); + //if (lvs) guestfs___free_string_list (lvs); if (ret) guestfs___free_string_list (ret); return NULL; } -- cgit