From 138e2dcff07013ef76e9f82fc32369fe91afd05e Mon Sep 17 00:00:00 2001
From: "Richard W.M. Jones" <rjones@redhat.com>
Date: Thu, 8 Mar 2012 13:23:15 +0000
Subject: daemon: debug: Close fd along error path (found by Coverity).

Error: RESOURCE_LEAK:
/builddir/build/BUILD/libguestfs-1.16.5/daemon/debug.c:469: open_fn: Calling opening function "open".
/builddir/build/BUILD/libguestfs-1.16.5/daemon/debug.c:469: var_assign: Assigning: "fd" =  handle returned from "open("/proc/sys/kernel/core_pattern", 1)".
/builddir/build/BUILD/libguestfs-1.16.5/daemon/debug.c:474: noescape: Variable "fd" is not closed or saved in function "write".
/builddir/build/BUILD/libguestfs-1.16.5/daemon/debug.c:476: leaked_handle: Handle variable "fd" going out of scope leaks the handle.
(cherry picked from commit 3b3d9ca4e1fa0a4f566cb2a8008540ee640b738b)
---
 daemon/debug.c | 1 +
 1 file changed, 1 insertion(+)

(limited to 'daemon/debug.c')

diff --git a/daemon/debug.c b/daemon/debug.c
index 522012f2..4036af68 100644
--- a/daemon/debug.c
+++ b/daemon/debug.c
@@ -473,6 +473,7 @@ debug_core_pattern (const char *subcmd, int argc, char *const *const argv)
   }
   if (write (fd, pattern, pattern_len) < (ssize_t) pattern_len) {
     reply_with_perror ("write: " CORE_PATTERN);
+    close (fd);
     return NULL;
   }
   if (close (fd) == -1) {
-- 
cgit