From 3dc9386af003157e3627f4889361e362f0722423 Mon Sep 17 00:00:00 2001
From: "Richard W.M. Jones" <rjones@redhat.com>
Date: Thu, 8 Mar 2012 14:36:25 +0000
Subject: dbdump: Avoid double-close on error path (found by Coverity).

Error: USE_AFTER_FREE:
/builddir/build/BUILD/libguestfs-1.16.5/src/dbdump.c:132: freed_arg: "pclose" frees "pp".
/builddir/build/BUILD/libguestfs-1.16.5/src/dbdump.c:142: deref_arg: Calling "pclose" dereferences freed pointer "pp".
(cherry picked from commit 3f3b08a6bc610ca0886e02972257dfcb633a9d40)
---
 src/dbdump.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/dbdump.c b/src/dbdump.c
index ca035db1..8242dee2 100644
--- a/src/dbdump.c
+++ b/src/dbdump.c
@@ -131,6 +131,7 @@ guestfs___read_db_dump (guestfs_h *g,
   /* Catch errors from the db_dump command. */
   if (pclose (pp) != 0) {
     perrorf (g, "pclose: %s", cmd);
+    pp = NULL;
     goto out;
   }
   pp = NULL;
-- 
cgit