From 2c73bdb66b25f6cb00fbdd83e95b78776897057d Mon Sep 17 00:00:00 2001 From: "Richard W.M. Jones" Date: Thu, 15 Mar 2012 10:32:27 +0000 Subject: sparsify: Use zero-device instead of dd if=/dev/zero to zero device. zero-device is more efficient in general, and avoids writing to blocks which are already zero. (cherry picked from commit 8c9f6a64be9840a955e481e932f13d005c0de0de) --- sparsify/sparsify.ml | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/sparsify/sparsify.ml b/sparsify/sparsify.ml index ff2ac5b5..a891beaa 100644 --- a/sparsify/sparsify.ml +++ b/sparsify/sparsify.ml @@ -246,11 +246,9 @@ let () = (* XXX Don't have lvcreate -l 100%FREE. Fake it. *) g#lvresize_free lvdev 100; - (* This command is expected to fail. *) - (try g#dd "/dev/zero" lvdev with _ -> ()); - - g#sync (); - g#lvremove lvdev + g#zero_device lvdev; + g#sync (); + g#lvremove lvdev ) ) ) vgs -- cgit