summaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* inspect: Check /etc/lsb-release is not too large before calling head on it.Richard W.M. Jones2010-11-181-1/+16
| | | | (cherry picked from commit 35afe0cb33c986bf595585a716ff259cf3415a1f)
* inspect: Add function to read the first line of a file, with safety checks.Richard W.M. Jones2010-11-181-14/+42
| | | | (cherry picked from commit a4448956e9a815aff59cac3d98caf80f620fc4c4)
* inspect: Abstract the wrapper that sets up Augeas.Richard W.M. Jones2010-11-181-32/+49
| | | | | | This is just code motion. Cherry picked from commit 61cfe13ec49f1d1e9d6124f0ee98520aab720087.
* inspect: Centralize all file downloads through a single function.Richard W.M. Jones2010-11-181-32/+52
| | | | Cherry picked from commit 8a3a4c25d3bb63674c9ccf8483d9bfd89085fe47.
* filearch: Refuse to download initrd if it is huge.Richard W.M. Jones2010-11-181-0/+8
| | | | (cherry picked from commit b943d06466724df39b7261ce75e43b0201ed7372)
* inspect: Refuse to download software hive if it is huge.Richard W.M. Jones2010-11-181-0/+8
| | | | (cherry picked from commit e44cf42f362d793c47d892a18a6853d88abd6ecb)
* inspect: Refuse to parse /etc/fstab if it is huge.Richard W.M. Jones2010-11-181-0/+8
| | | | (cherry picked from commit 692f127447d399db21c2e93026d4d2b0ac1839d1)
* Abstract out check_architecture and check_fstab_aug_open functions.Richard W.M. Jones2010-11-181-8/+29
| | | | | | This is part of the development commit 79b202ca26226e0a95e3f04ac7ff91e9eb918b48 excluding the new FreeBSD feature.
* inspect: Fix error out path if minor_version parsing fails.Richard W.M. Jones2010-11-181-1/+1
| | | | (cherry picked from commit 9674a73c08e128d8a7a39a6be6140c373c0e61f0)
* lib: Make some error strings localizable.Richard W.M. Jones2010-11-181-3/+3
| | | | (cherry picked from commit 528cd8f64176ca50f5b82db5682b0ee31833b162)
* lib: Add match3 function.Richard W.M. Jones2010-11-182-0/+27
| | | | (cherry picked from commit 55e6ccb23e0b1f954107b4d0284d3d41f7a4e7b8)
* lib: Add safe_asprintf function.Richard W.M. Jones2010-11-182-0/+19
| | | | (cherry picked from commit a48ab78dc8272675caf7bebf17d2112aaaf6332f)
* docs: Add a section on security.Richard W.M. Jones2010-11-181-1/+154
| | | | (cherry picked from commit cd96cca38cea638a6db76afceeed76babc9e763c)
* docs: Rearrange guestfs(3) sections.Richard W.M. Jones2010-11-181-254/+254
| | | | | | | | | | | | This rearranges the sections into a more logical order: - synopsis and introduction - API-related overview sections - (security will go here, see next commit) - API in detail - architecture and other internals - usual end sections (cherry picked from commit 35dbedb1b18157b2329e0e55d0b5355f26431814)
* Fix small typo in a comment in src/Makefile.am.Richard W.M. Jones2010-11-181-1/+1
| | | | (cherry picked from commit 4a3726d5ed0dd3174b46ec574eaf4f4140cb193b)
* lib: Make pcre, libmagic and hivex libraries optional.Richard Jones2010-11-186-427/+647
| | | | | | | | | | | | | | | | | This change makes these libraries optional. If they are not available at compile time then certain core API features will be disabled (see below). This also changes PCRE detection to use pkg-config instead of the ad hoc autoconf checks. The large inspect.c file has been split out into separate function-specific files. file-architecture: requires pcre & libmagic inspection: requires pcre & hivex Cherry picked from commit a0b4caa0821b759de01361b7019c9c9c9607027d.
* inspect: win64 regexp was dead code.Richard Jones2010-11-181-2/+0
| | | | (cherry picked from commit 8ac9575b204a8ac85f9030500cb6eabbf6aa3226)
* lib: Augeas (client side) is not needed by the library.Richard Jones2010-11-181-2/+1
| | | | | | However it is used by the daemon. Cherry picked from commit b52183b5491748d9e979d30e55db6d648b102416.
* supermin: If disabled, don't compile in supermin code or check for supermin.Richard W.M. Jones2010-11-181-5/+11
| | | | | | | | | | | | | If supermin is disabled at compile time and the user just wants to use the ordinary appliance, there is no need to compile in all the supermin code, and in particular there is no need to check for the supermin appliance (which involves running febootstrap-supermin-helper that probably doesn't exist). This fixes a warning message observed under Debian w/o supermin: sh: febootstrap-supermin-helper: command not found (cherry picked from commit 4e656a61d40ff51e63aa06d857c40c14ff31ddb9)
* Include <stdarg.h> in public header.Guido Günther2010-11-051-0/+1
| | | | | | Public headers use va_list, and this gives an error unless <stdarg.h> had been included before the header. (cherry picked from commit 7fc338690f385c2495b7ba5f98346a5c057991ea)
* docs: Clarify no additional error available from guestfs_create.Richard W.M. Jones2010-11-051-0/+6
| | | | (cherry picked from commit 5d6a91844520d07f9477e2ddca4caf8f040ef8a1)
* docs: Clarify default error handler.Richard W.M. Jones2010-11-051-1/+25
| | | | Cherry picked from commit 01d613ae957431d65c700a34e369ef4c06dd6d8f.
* docs: Error strings are in fact localized, documentation was wrong.Richard W.M. Jones2010-11-051-4/+0
| | | | Cherry picked from commit 6a218092812783eaea43919674eb8d1c74a80b33.
* docs: Clarify, not every function that returns int returns -1 for errors.Richard W.M. Jones2010-11-051-2/+3
| | | | Cherry picked from commit aae5bebe6878c01803653fae166c58b7217b6100.
* Define internal safe_calloc shorthand.Richard W.M. Jones2010-11-051-0/+1
| | | | (cherry picked from commit 6b8d05438cc0309f762fabf2f3cc7ae4bf5521c1)
* inspect: Add support for MeeGo.stable-1.6Richard W.M. Jones2010-11-022-0/+11
|
* inspect: Add support for Ubuntu.Richard Jones2010-10-292-1/+76
|
* inspect: Add detection of Gentoo.Richard Jones2010-10-292-0/+11
|
* inspect: Add detection of Arch Linux.Richard Jones2010-10-292-0/+9
|
* inspect: Add detection of Pardus.Richard Jones2010-10-292-0/+11
|
* inspect: Generic parsing of MAJOR.MINOR in product names.Richard Jones2010-10-291-16/+26
|
* inspect: Generic parsing of release files.Richard Jones2010-10-291-26/+25
|
* inspect: Ignore Pardus "/.swap" swapfile.Richard W.M. Jones2010-10-291-4/+5
|
* Ensure atomic creation of a cached applianceMatthew Booth2010-10-281-13/+92
| | | | | | | | | | | | | | | | | | | | Cached appliances are discovered by their predictable path. Previously we were creating a cached appliance directly in this predictable path. This had at least 2 undesirable effects: * Interrupting appliance creation would leave a corrupt appliance * 2 processes could simultaneously attempt to create the same appliance, causing corruption. This patch causes the cached appliance to be created in a temporary directory, and then renamed to the predictable path. As rename is an atomic operation, this makes the whole creation atomic. This patch also changes the predictable path to have a prefix of 'guestfs.'. This will make it simpler for system administrators to clean up old cached appliances. This patch resolves RHBZ#639405
* Call febootstrap-supermin-helper using the new -u and -g optionsMatthew Booth2010-10-281-37/+34
| | | | | | | | | | | | | | Use febootstrap-supermin-helper's new -u and -g command line options to setuid, rather than doing it in libguestfs. This resolves an issue with the generation of the cached appliance checksum. The checksum was being generated by a call to febootstrap-supermin-helper through popen(). Unfortunately, a bash misfeature meant that euid would be reset to uid, and the checksum was generated for uid, not euid. When virt-v2v is writing to a RHEV target, uid == 0 and euid == 36, which resulted in a cached appliance being created for root with permissions for uid 36. Note this requires febootstrap 2.10.
* Log the febootstrap-supermin-helper command lineMatthew Booth2010-10-281-26/+29
| | | | | | A side-effect of change 17e7cb9937a63ed8f9bb0fb6ac7302758be76846 was the the febootstrap-supermin-helper was no longer logged. This change adds it back using the new guestfs___print_timestamped_argv internal function.
* New internal function guestfs___print_timestamped_argvMatthew Booth2010-10-282-24/+25
| | | | | | | This function generalises the existing print_cmdline used to output the qemu command line to output any given command line, and exports it to other modules. It also adds a timestamp to the old print_cmdline output for consistency with guestfs___print_timestamped_message.
* New API: inspect-get-windows-systemroot to get systemroot.Richard W.M. Jones2010-10-282-23/+31
| | | | | | We are already using heuristics in the C inspection code to determine the Windows %SYSTEMROOT% directory. This change just exposes this information through the API.
* doc: Warn about security implications of running commands.Richard W.M. Jones2010-10-281-0/+16
|
* appliance: Remove repo from appliance filename (RHBZ#638901).Richard W.M. Jones2010-10-271-2/+2
| | | | | | | There's no need to have the appliance filename contain the repository name it was built from, and this change gives downstream users more freedom to mix and match libraries and appliances if they want to.
* inspection: Ignore floppy disks and CD-ROM drives (RHBZ#642929).Richard W.M. Jones2010-10-271-0/+7
|
* Enable autosync by default.Richard W.M. Jones2010-10-272-0/+4
|
* /dev/mapper paths should not be returned from C inspection APIs (RHBZ#638899).Richard W.M. Jones2010-10-271-17/+32
| | | | | | | | | | | | | | | | With this patch, /dev/mapper paths do not appear in the output of guestfs_inspect_os, as you can see from this example: Welcome to guestfish, the libguestfs filesystem interactive shell for editing virtual machine filesystems. Type: 'help' for a list of commands 'man' to read the manual 'quit' to quit the shell Operating system: Fedora release 13 (Goddard) /dev/vg_f13x64/lv_root mounted on / <--- NB /dev/vda1 mounted on /boot
* New API: lvm-canonical-lv-name: make LV name canonical.Richard W.M. Jones2010-10-271-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When logical volume names appear in places like /etc/fstab files they can have the form "/dev/mapper/foo-bar". This function takes such names and makes them canonical. Note that this operation cannot be performed using the current API, because 'guestfs_stat' does not work on device names, and we don't really want to make a 'stat-device' call since that exposes too much non-useful detail about the appliance. With this patch you can do this: ><fs> debug ll /dev/mapper total 8 drwxrwxr-x 2 root root 4096 Oct 25 12:51 . drwxr-xr-x 16 root root 4096 Oct 25 12:51 .. crw------- 1 root root 10, 62 Oct 25 12:51 control lrwxrwxrwx 1 root root 7 Oct 25 12:51 vg_f13x64-lv_root -> ../dm-0 lrwxrwxrwx 1 root root 7 Oct 25 12:51 vg_f13x64-lv_swap -> ../dm-1 ><fs> lvm-canonical-lv-name /dev/mapper/vg_f13x64-lv_root /dev/vg_f13x64/lv_root ><fs> lvm-canonical-lv-name /dev/mapper/vg_f13x64-lv_swap /dev/vg_f13x64/lv_swap ><fs> lvm-canonical-lv-name /dev/mapper/foo libguestfs: error: lvm_canonical_lv_name: lvm_canonical_lv_name_stub: /dev/mapper/foo: No such file or directory ><fs> lvm-canonical-lv-name /dev/mapper/control libguestfs: error: lvm_canonical_lv_name: /dev/mapper/control: not a logical volume ><fs> lvm-canonical-lv-name /dev/vg_f13x64/lv_root /dev/vg_f13x64/lv_root
* Don't use kernel module whitelist with ext2-based appliance.Richard W.M. Jones2010-10-271-6/+0
| | | | | | | | | Since the ext2-based appliance is cached, and since it is not all loaded into memory (as with the initrd), we might as well put all the kernel modules in there. Note the kmod.whitelist.in file is still used for building the ordinary appliance.
* Fix networking in the appliance.Matthew Booth2010-10-271-1/+1
| | | | | | | | | | Commit 4963be85 re-introduced networking to the appliance, but didn't configure the custom network the appliance expects since we switched to link local addressing. This patch configures QEMU to use the custom network again. Note that you still need to use guestfs_set_network (g, 1) to enable user networking.
* Don't include control characters in BufferIn trace output (RHBZ#646822).Matthew Booth2010-10-262-0/+30
| | | | | | | | | | | | The example below shows what the output looks like for a large random buffer. $ guestfish -N fs -m /dev/sda1 -x -- \ touch /test : \ pwrite /test "$(dd if=/dev/urandom bs=128k count=1)" 0 [...] pwrite "/test" "\x7f\xa0/\xb3\x80\xd3\xbc\xc3\xc3.\xb1\xe0\x1b\xafC\x06\xd5;\x0ajJ[o\xc1\xdd\xae\x1f\xce\xb2\x8d\xb3\xd0\x11\xcc$%\xe6<\xc7\xc7\xe7BU*\xc4l%\xaa\xea\xe9\x1an\xda]\xc6I\x0eC\xf9;\xec\x12a\x1f\xeaRH\xb2P\xd6+\xc4\xe6\xa5bW\x99\\x9d\xc8\x9bJ\xef\x99-\x16:h5\xe2\x0f\xa2\xa08\x9bU\x0b$\x138\xcf\xd4j\x9b\x83{%\xac0\xdaa1Xx\xbd`\x8e\xdd\x82\x87\x07\x98\xd2\x9ed\x8bq\xd0\x1f5\x8f\xab\xad4z1\xda\xc4b\xc1\xbc\x0f\xaa\xea\xc1\x15(\xfd1\xc2\x0bF\xe6\x9e\xb0+/g\\xab\xb0b\xde_\xca\xf9\xad\xe1?%\x17\xad\x98\xa4e\xc1\xe0f'\x89\xe9>\xff\xadhYi\xe7\x8c]%\xef\xe0\xa1R\xe5\xd5\x03K\xefI\xdf\xad\xd3\x82\xdb\x0f\xdd\xc3\x8f"\xf1G\xea\xf9r\xdd\xff\x88\x81\xb7\xf2\x0e\x0f\x1d;:\xf2F1\xdb\xb5D\xa1^\x928\xf5\x8e)\xab\xc4\xc3H(\xd0ol\xc6\xe4\xd6\xa3L\x1c\x06\xf4"<truncated, original size 130567 bytes> 0 [...]
* generator: Optional arguments, add-drive-opts (RHBZ#642934,CVE-2010-3851).Richard W.M. Jones2010-10-222-41/+232
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This large commit changes the generator so that optional arguments can be supported for functions. The model for arguments (known as the "style") is changed from (ret, args) to (ret, args, optargs) where optargs is a more limited list of arguments. One function has been added which takes optional arguments, it is "add-drive-opts", modelled as: (RErr, [String "filename"], #required [Bool "readonly"; String "format"; String "iface"]) #optional Note that this function is processed in the library (does not go over the RPC protocol to the daemon). This has allowed us to simplify the current implementation by omitting changes related to RPC or the daemon, although we plan to add these at some point in the future. From C this function can be called in 3 different ways as in these examples: guestfs_add_drive_opts (g, filename, GUESTFS_ADD_DRIVE_OPTS_READONLY, 1, GUESTFS_ADD_DRIVE_OPTS_FORMAT, "raw", -1); (the argument(s) between 'filename' and '-1' are the optional ones). guestfs_add_drive_opts_va (g, filename, args); where 'args' is a va_list. This works like the first version. struct guestfs_add_drive_opts_argv optargs = { .bitmask = GUESTFS_ADD_DRIVE_OPTS_READONLY_BITMASK, .readonly = 1, } guestfs_add_drive_opts_argv (g, filename, &optargs); This last form lets you construct lists of optional arguments, and is used by guestfish and the language bindings. In guestfish optional arguments are used like this: add-drive-opts filename readonly:true In OCaml these are mapped naturally to OCaml optional arguments, eg: g#add_drive_opts ~readonly:true filename; In Perl these are mapped to extra arguments, eg: $g->add_drive_opts ($filename, readonly => 1); In Python these are mapped to optional arguments, eg: g.add_drive_opts ("file", readonly = 1, format = "qcow2") In Ruby these are mapped to a final hash argument, eg: g.add_drive_opts("file", {}) g.add_drive_opts("file", :readonly => 1) g.add_drive_opts("file", :readonly => 1, :iface => "virtio") In PHP these are mapped to extra parameters. This is not quite accurate since you cannot omit arbitrary optional parameters, but there's not much than can be done within the limitations of PHP as a language. Unimplemented in: Haskell, C#, Java.
* New API: pread-device, partial read for devices.Richard W.M. Jones2010-09-271-1/+1
|
* New API: pwrite-deviceRichard W.M. Jones2010-09-261-1/+1
| | | | | This is the same as the existing 'pwrite' API call, but allows you to write to a device.