summaryrefslogtreecommitdiffstats
path: root/src/guestfs.c
Commit message (Collapse)AuthorAgeFilesLines
...
* Remove main loop.Richard Jones2009-09-141-883/+478
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit removes the external main loop, which never worked and caused a number of bugs. Requests are now done synchronously, and if the user wants to have requests issued in the background or to have a responsive GUI, then they'll just have to use threads. The big change is to push all reads and writes through two functions called send_to_daemon (for writes) and recv_from_daemon (for reads) which operate synchronously. These functions read/write whole messages, and also handle checking for EOF (ie. daemon died) and asynchronous log message events from qemu (eg. from debug / dmesg printed by the guest). A more complete description of how these work can be found in the code. This code passes a complete run of the tests. Bugs believed to be fixed by this commit: https://bugzilla.redhat.com/show_bug.cgi?id=501888 internal error: reply callback called twice https://bugzilla.redhat.com/show_bug.cgi?id=504418 In virt-inspector: "download: guestfs_download reply failed, see earlier error messages" I have tried to avoid reintroducing this: https://bugzilla.redhat.com/show_bug.cgi?id=508713 libguestfs: error: write: Broken pipe (guestfish only) One other benefit of this is that 'set_busy/end_busy' calls no longer appear in traces.
* Add command trace functionality.Richard Jones2009-09-141-0/+17
| | | | | Enable this by calling guestfs_trace (handle, 1) or by setting the LIBGUESTFS_TRACE=1 environment variable.
* Non-daemon actions indirect through generated code.Richard Jones2009-09-141-32/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously non-daemon actions were called directly by user code, eg: /* Non-generated */ int guestfs_set_verbose (guestfs_h *g, int v) { g->verbose = !!v; return 0; } This changes these actions so they go indirectly via some generated code, eg: /* Generated */ int guestfs_set_verbose (guestfs_h *g, int verbose) { return guestfs__set_verbose (g, verbose); } /* Non-generated */ int guestfs__set_verbose (guestfs_h *g, int v) { g->verbose = !!v; return 0; } The aim is to have a place in the generated code where we can add debug or tracing information for these non- daemon calls.
* maint: guestfs.c: remove unnecessary initializationJim Meyering2009-08-311-1/+1
| | | | | * src/guestfs.c (guestfs__receive_file_sync): Don't set "r", only to ignore it.
* build: don't define _GNU_SOURCE manuallyJim Meyering2009-08-241-1/+0
| | | | | | | | | | | | Now that we're using gnulib in earnest, any manual definition would provoke a redefinition warning. * fish/fish.c (_GNU_SOURCE): Don't define. * fish/destpaths.c (_GNU_SOURCE): Likewise. * src/guestfs.c (_GNU_SOURCE): Likewise. * bootstrap (modules): Add asprintf, strchrnul, strerror, strndup and vasprintf. * fish/fish.c (main): Set argv[0] to sanitized program_name, so functions like getopt_long that use argv[0] use the clean name.
* Add waitpid along guestfs_close path (RHBZ#518747).Richard Jones2009-08-221-0/+4
|
* guestfs_launch: Correct checks for dup failure.Richard Jones2009-08-191-7/+7
|
* build: Comment out some unused macros.Richard Jones2009-08-191-3/+3
| | | | | GCC 4.4.1 warns about some unused macros. Comment these out while they are not used.
* suppress warnings from -Wmissing-noreturnJim Meyering2009-08-181-0/+2
| | | | | | | Even though these functions are marked as "not implemented yet", and they will surely return a value once implemented, ... * src/guestfs.c (select_add_timeout): Declare with noreturn attribute. (select_remove_timeout): Likewise.
* suppress a warning from -Wswitch-defaultJim Meyering2009-08-181-0/+2
| | | | * src/guestfs.c (guestfs_end_busy): Add a "default:" label.
* suppress signed/unsigned-comparison warningsJim Meyering2009-08-181-2/+2
| | | | | * src/guestfs.c [struct guestfs_h] (msg_in_size, msg_in_allocated): (msg_out_size, msg_out_allocated): Change type from int to unsigned int.
* build: don't perform arithmetic on void* pointersJim Meyering2009-08-181-3/+5
| | | | * src/guestfs.c (receive_file_data_sync, xread, xwrite): Use char*.
* build: suppress an ignored-dup-return-value warningJim Meyering2009-08-181-2/+9
| | | | * src/guestfs.c (guestfs_launch): Handle dup failure.
* build: suppress an ignored-write-return-value warningJim Meyering2009-08-181-1/+2
| | | | | | | | | * bootstrap (modules): Add ignore-value. * src/guestfs.c: Include "ignore-value.h". (stdout_event): Ignore failure to write to stderr. Also, prefer STDERR_FILENO over the literal "2". * src/Makefile.am (libguestfs_la_CPPFLAGS): Include gnulib's .h files. (libprotocol_la_CFLAGS): Remove -Wall -Wno-unused.
* add_drive: Don't use cache=off if not supported by underlying filesystem.Richard W.M. Jones2009-08-131-6/+23
| | | | | | | | | | | | | | | | | | If you use the guestfs_add_drive function, then currently it generates a qemu command line element like: -drive ...,cache=off,... This causes qemu to try to open the device with O_DIRECT. Unfortunately some filesystems don't support this flag, notably tmpfs, which means you can't use libguestfs in conjunction with tmpfs. On some systems /tmp is a tmpfs filesystem. This patch fixes this so that if the filesystem doesn't support O_DIRECT, then we omit the cache=off parameter. This seems reasonable from a reliability point of view, because if you're using tmpfs then you probably didn't expect reliability in the case where your system suddenly powers off.
* Allow selinux=? kernel flag to be controlled.Richard Jones2009-08-121-5/+24
| | | | Adds new API calls to set and get this flags.
* Debug: Improve the way the qemu command line is printed.Richard Jones2009-08-071-7/+31
| | | | | | | | | | | | | | | | Change the way the qemu command is displayed to look like this: /usr/bin/qemu-kvm \ -drive file=/tmp/test.img,cache=off,if=virtio \ -m 500 \ -no-reboot \ -kernel /tmp/libguestfsHBJHRh/kernel \ -initrd /tmp/libguestfsHBJHRh/initrd \ [...] This allows the command line to be copied and pasted directly into the shell, and also makes it simpler to read.
* Allow network interface to be configured.Richard Jones2009-08-071-1/+1
| | | | | | | | Add ./configure --with-net-if=(virtio|ne2k_pci) option. This lets you workaround the following virtio_net bug: https://bugzilla.redhat.com/show_bug.cgi?id=516022
* Add ne2k-pci driver to the appliance.Richard Jones2009-08-061-1/+1
| | | | | This allows people to use the ne2k-pci network driver, for those situations where the virtio_net driver is broken (cough 516022 cough).
* Make user network numbering explicit.Richard Jones2009-08-061-2/+2
| | | | | | Use: -net user,vlan=0,net=10.0.2.0/8 just to make the (already implicit) 10.0.2.x network explicit.
* Convert all TABs-as-indentation to spaces.Jim Meyering2009-08-031-113/+113
| | | | | | | | | | | Do it by running this command: [exempted files are matched via .x-sc_TAB_in_indentation] git ls-files \ | pcregrep -vf .x-sc_TAB_in_indentation \ | xargs pcregrep -l '^ *\t' \ | xargs perl -MText::Tabs -ni -le \ '$m=/^( *\t[ \t]*)(.*)/; print $m ? expand($1) . $2 : $_'
* guestfs: fix typo in my recent changeJim Meyering2009-08-031-3/+3
| | | | | * src/guestfs.c (guestfs_perrorf): Rename former err to errnum, to avoid compilation error.
* guestfs: don't fault upon failed vasprintfJim Meyering2009-08-031-1/+3
| | | | * src/guestfs.c (guestfs_perrorf): Handle failed vasprintf.
* lib: Add selinux=0 to default kernel command line.Richard W.M. Jones2009-07-311-1/+2
| | | | | | | | | | | SELinux exists in a very disturbed state if it is enabled at boot time, but no policy is loaded. In particular, it messes up the security.selinux extended attributes on files in a not-very-useful way. We can't enable SELinux because we don't know what policy can or should be loaded. Therefore it's best to disable it completely.
* Pass cgroup_disable=memory, saves ~ 5MB of RAM.Richard Jones2009-07-241-1/+2
|
* Revert "Add 'set-kernel'/'get-kernel'/LIBGUESTFS_KERNEL to override ↵Richard Jones2009-07-221-24/+1
| | | | | | appliance kernel." This reverts commit 34d2df41626f1ee4172a6d40b06d72d6ed9d6348.
* Add 'set-kernel'/'get-kernel'/LIBGUESTFS_KERNEL to override appliance kernel.Richard Jones2009-07-221-1/+24
| | | | | This allows you to override the appliance kernel with an easy command or environment variable.
* Add commented-out support for alternate guestfwd syntax.Richard W.M. Jones2009-07-211-9/+32
| | | | | | This commit just moves code around. The new support is not enabled because it doesn't work. See qemu-devel, subject "guestfwd option doesn't allow supplementary ,server,nowait"
* Library: Pass more options on the Linux kernel command line.Richard W.M. Jones2009-07-211-1/+8
| | | | | | | Always pass: noapic (APIC causes problems for lots of people) udevtimeout=300 (for very slow qemu using softemu) acpi=off (ACPI is troublesome and unnecessary, so turn it off)
* Allow TMPDIR to override directory used for temporary files (RHBZ#512905).Richard W.M. Jones2009-07-211-1/+11
|
* Add 'version' call to get true library version number.Richard Jones2009-07-101-0/+13
| | | | | | This patch also changes the way that the version is specified in configure.ac. It is now made out of four parts (major, minor, release and extra) and constructed for AC_INIT.
* Properly close fds and unregister handlers in guestfs_close.Richard Jones2009-07-101-0/+19
| | | | | | | | | This caused a segfault if you tried to repeatedly open and close a guestfs handle in the same program. The reason is that the old handler remained registered (not always - it was racey). This adds proper cleanup to the guestfs_close path, also for file descriptors.
* Generate structs and struct lists generically.Richard Jones2009-07-071-38/+0
| | | | | | | | | | | This modifies the way that struct and struct lists are generated (for return values) so that there is no need to add an explicit new type when adding a new structure. All tests pass, and the C API should be compatible. I have also inspected the changes that are made to the generated code by hand.
* Add a debug message to the library cancellation path.Richard Jones2009-07-061-0/+4
|
* Add 'get-pid' command.Richard Jones2009-07-061-0/+11
| | | | | This is used to get the PID of the qemu subprocess, mainly for debugging and testing purposes.
* use safe_malloc and safe_calloc in generated codeJim Meyering2009-07-031-1/+38
| | | | | | | | | | * src/generator.ml (safe_malloc): Define to guestfs_safe_malloc. (safe_calloc): Define to guestfs_safe_calloc. [most generated code]: Fail immediately upon failure of otherwise- unchecked malloc and calloc calls. * src/guestfs.c: Include <stddef.h>. (xalloc_oversized): Define. * src/guestfs.h (guestfs_safe_calloc): Declare.
* Add ./configure --with-drive-if=(ide|scsi|virtio)Richard W.M. Jones2009-07-021-2/+2
| | | | | | | | With this flag the packager can decide to default to a particular qemu drive model. The current default is 'ide', however note that we intend to change this in future to 'virtio' once some upstream regressions are fixed. Packagers can force a particular drive model if they wish.
* Add 'readdir' call.Richard W.M. Jones2009-07-021-0/+7
| | | | | | | | | | | | This adds a readdir call (mostly intended for programs). The return value is a list of guestfs_dirent structures. This adds the new types 'struct guestfs_dirent' and 'struct guestfs_dirent_list', along with all the code to return these in the different language bindings. Also includes additional tests for OCaml and Perl bindings to test this.
* Change to use virtio_blk (virtio block device) by default.Richard W.M. Jones2009-07-011-2/+2
| | | | | | | | | | | | | virtio_blk is the fast, virt-native block device driver supported by qemu and KVM. Note that virtio_blk device names are called /dev/vd*. Existing scripts should continue working because device name translation will silently change device names of the form /dev/sd* to /dev/vd* as required. See also: http://libguestfs.org/guestfs.3.html#block_device_naming
* Don't dereference or free undefined "msg" upon OOM.Jim Meyering2009-07-011-1/+3
| | | | * src/guestfs.c (guestfs_error): Handle failing vasprintf.
* Add 'set_memsize'/'get_memsize' calls.Richard W.M. Jones2009-06-301-11/+33
| | | | | | Allow the qemu memory size to be specified either by API calls or by setting the LIBGUESTFS_MEMSIZE environment variable.
* Fix for 'broken pipe' error when qemu dies (RHBZ#508713).Richard W.M. Jones2009-06-291-2/+5
|
* Bump up default guest size to 500M.Richard W.M. Jones2009-06-231-1/+1
|
* Command line argument handling.Richard W.M. Jones2009-06-231-3/+106
|
* '-no-kqemu' option is no longer necessary to avoid a warning.Richard W.M. Jones2009-06-231-3/+0
|
* Rename guestfs-supermin-helper -> libguestfs-supermin-helper.Richard Jones2009-06-181-1/+1
|
* Fix build_supermin_appliance to return kernel / initrd names.Richard Jones2009-06-161-3/+12
|
* Experimental implementation of the supermin appliance (passes most tests).Richard Jones2009-06-151-28/+145
|
* Add 'add_drive_ro' call. Fix up documentation. Plus a couple of minor code ↵Richard Jones2009-06-021-0/+21
| | | | improvements in the tests.
* Correctly handle malloc/realloc(0)Richard W.M. Jones2009-05-291-2/+2
| | | | | - malloc and realloc(0) are valid requests. Some implementations may return NULL for these, which would not indicate an error.
generated by cgit (git 2.34.1) at 2025-09-01 22:58:50 +0000