summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Use STRPREFIX instead of STREQLEN.Richard Jones2009-11-221-2/+2
|
* generator: second parameter to upload is Dev_or_Path, not String.Richard Jones2009-11-221-1/+1
|
* build: Add missing dependencies in perl directoryMatthew Booth2009-11-212-1/+17
| | | | | | | | make all in the perl directory was missing a check that the library had been built. make check in the perl directory was missing a check that the appliance and test images had been built.
* build: Ensure building appliance depends on guestfsdMatthew Booth2009-11-211-1/+1
| | | | | | | Previously, only the update.sh rule checked the daemon had been built. update.sh is called directly from within make.sh, so in that path the dependency was never checked. This adds the daemon dependency explicitly to the rebuild-from-scratch path.
* build: Don't re-check generator.ml for each generator_built in daemon directoryMatthew Booth2009-11-211-1/+2
|
* build: Rebuild the daemon as necessary from other directoriesMatthew Booth2009-11-211-0/+4
| | | | | This change ensure that making the appliance will always rebuild the daemon if required.
* Update TODO file.Richard Jones2009-11-211-1/+15
|
* perl: Add Sys::Guestfs::Lib::feature_availableRichard Jones2009-11-201-3/+29
| | | | | | | This is a nicer Perl wrapper around $g->available call. Update the other code in Sys::Guestfs::Lib to use it before using LVM, Augeas.
* availability: Skip tests when functions are not available.Richard Jones2009-11-202-18/+23
|
* availability: Add optional groups and implement guestfs_available call.Richard Jones2009-11-2020-151/+388
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The current groups are defined very conservatively using the following criteria: (a) Would be impossible to implement on Windows because of sheer architectural differences (eg: mknod). (b) Already optional (augeas, inotify). (c) Not currently optional but not implemented on older RHEL and Debian releases (ntfs-3g.probe, scrub, zerofree). The optional groups I've defined according to these criteria are: . augeas . inotify . linuxfsuuid . linuxmodules . linuxxattrs . lvm2 . mknod . ntfs3g . scrub . selinux . zerofree (Note that these choices don't prevent us from adding more optional groups in future. On the other hand to avoid breaking ABIs we would not wish to change the above groups). The rest of this large commit is really just implementation: Each optional function is classified using Optional "group" flag in the generator. The daemon has to implement a function int optgroup_<name>_available (void); for each optional group. Some of these functions are fixed at compile time, and some do simple run-time tests. The do_available implementation in the daemon looks up the correct function in a table and runs it. We document the optional groups in the guestfs(3) man page. Also: I added a NOT_AVAILABLE macro in order to unify all the existing places where we had a message equivalent to "function __func__ is not available".
* availability: Add guestfs_available.Richard Jones2009-11-205-2/+101
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Start a new API allowing groups of functions to be tested for availability. There are two reasons for this: (1) If libguestfs is built with missing dependencies (eg. no Augeas lib) then the corresponding functions are disabled in the appliance. Up till now there has been no way to test for this except to speculatively issue commands and check for errors. (2) When we port the daemon to Win32 it is likely that major pieces of functionality won't be available (eg. LVM support). This API gives a way to test for that. There is no change for existing clients: you still have to check for errors from individual API calls. For new clients, you will be able to test for availability of particular APIs. Usage scenario (A): An LVM editing tool which requires both the LVM API and inotify in order to function at all: char *apis[] = { "inotify", "lvm2", NULL }; r = guestfs_available (g, apis); if (r == -1) { /* print an error and exit */ } Usage scenario (B): A general purpose tool which optionally provides configuration file editing, but this can be disabled, the result merely being reduced functionality: char *apis[] = { "augeas", NULL }; r = guestfs_available (g, apis); enable_config_edit_menus = r == 0;
* daemon/Win32: Use gnulib modules for first porting to Win32.Richard Jones2009-11-206-14/+44
|
* build: Add missing dependency libguestfs.la->guestfs_protocol.hMatthew Booth2009-11-201-0/+1
|
* build: correct sed transformation to work also on .git-module-statusJim Meyering2009-11-202-2/+4
| | | | | | | | | | | | | | | | My patch was wrong. I kept the sed transformation the same in the two places, but it wasn't strict enough to also work on the file contents. Sorry about that. This fixes it. >From 93927cc7b9f63c414e5bfeb7eba393fde3295601 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering@redhat.com> Date: Fri, 20 Nov 2009 16:23:17 +0100 Subject: [PATCH libguestfs] build: correct sed transformation to work also on .git-module-status * autogen.sh: Use a more strict sed transformation so it works also on the contents of .git-module-status, which has no prefix. * cfg.mk (_submodule_hash): Use a stricter sed regexp.
* build: make autogen.sh update .git-module-status, as it shouldJim Meyering2009-11-201-1/+1
| | | | | | | | | | | | | | | | | | I ran autogen.sh, but then make was always failing like this: $ make cfg.mk:141: *** gnulib update required; run ./autogen.sh first. Stop. Here's the fix: >From f743f32079fea2e8a17c7f5b59305e584c75dba0 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering@redhat.com> Date: Fri, 20 Nov 2009 14:29:55 +0100 Subject: [PATCH libguestfs] build: make autogen.sh update .git-module-status, as it should * autogen.sh: Without this, "make" would always say "gnulib update required; run ./autogen.sh first", even after you'd run autogen.sh successfully.
* maint: use EXIT_* symbol (not constant, 2) to indicate key/path not foundJim Meyering2009-11-201-2/+4
| | | | | * hivex/hivexget.c (EXIT_NOT_FOUND): Define. (main): Use exit (EXIT_NOT_FOUND), not "exit (2)".
* maint: use EXIT_SUCCESS and EXIT_FAILURE, not 0 and 1 in "usage", tooJim Meyering2009-11-202-4/+4
| | | | | | | | | | Convert by running these commands: perl -pi -e 's/\b(usage ?)\(1\)/$1(EXIT_FAILURE)/' \ fish/fish.c fuse/guestmount.c perl -pi -e 's/\b(usage ?)\(0\)/$1(EXIT_SUCCESS)/' \ fish/fish.c fuse/guestmount.c * fish/fish.c (main): Replace 0/1 with EXIT_SUCCESS/EXIT_FAILURE. * fuse/guestmount.c (main): Likewise.
* maint: use EXIT_SUCCESS and EXIT_FAILURE, not 0 and 1 to exitJim Meyering2009-11-2016-174/+176
| | | | | | | | | | | | | | | Convert all uses automatically, via these two commands: git grep -l '\<exit *(1)' \ | grep -vEf .x-sc_prohibit_magic_number_exit \ | xargs --no-run-if-empty \ perl -pi -e 's/\b(exit ?)\(1\)/$1(EXIT_FAILURE)/' git grep -l '\<exit *(0)' \ | grep -vEf .x-sc_prohibit_magic_number_exit \ | xargs --no-run-if-empty \ perl -pi -e 's/\b(exit ?)\(0\)/$1(EXIT_SUCCESS)/' * .x-sc_prohibit_magic_number_exit: New file. Edit (RWMJ): Don't change Java code.
* maint: remove unnecessary include of openat.hJim Meyering2009-11-201-2/+0
| | | | * daemon/realpath.c: Don't include "openat.h". not used.
* build: update gnulib submodule to latestRichard Jones2009-11-203-0/+18
|
* daemon/gnulib: Include glob module.Richard Jones2009-11-202-1/+18
|
* daemon/Win32: Don't include missing headers.Richard Jones2009-11-201-3/+15
| | | | | This is a partial fix for code in guestfsd.c where many of these header files are missing on Win32.
* daemon/Win32: make some functions and fields optional.Richard Jones2009-11-205-4/+98
| | | | | | | | | | | | inotify: Make this optional on platforms that don't have this interface. mknod, mkfifo etc.: Make these optional on non-Unix platforms. readdir: If d_type field is missing on the platform, set the corresponding field to 'u'. stat: st_blocks and st_blksize are missing on non-Unix platforms, so set these fields to -1 in the corresponding structures.
* daemon/Win32: NAME_MAX does not exist on Windows, use FILENAME_MAX instead.Richard Jones2009-11-201-0/+5
|
* daemon: Missing #includes revealed by cross-compiling.Richard Jones2009-11-204-0/+4
|
* daemon/Win32: Ignore mingw32-config.cache.Richard Jones2009-11-201-0/+1
| | | | | The Fedora Windows cross-compiler 'mingw32-configure' script always uses a configure cache. Ignore that file.
* generator: open Unix module by default.Richard Jones2009-11-191-22/+23
| | | | | | | | | | | | | | Add: open Unix at the top of the generator, which means that we don't need to prefix any 'Unix.foo' symbols (we can just use 'foo' instead). Unfortunately the Unix module shadows one symbol in Pervasives (the Pervasives module is opened by default in OCaml code). That symbol is 'stdout'. So we replace this with 'Pervasives.stdout' in two places. Still a net reduction in code size.
* syntax-check: Fix tab-vs-space issue in the generator.Richard Jones2009-11-191-4/+4
|
* Update PO files.Richard Jones2009-11-192-14/+14
|
* Update TODO file.Richard Jones2009-11-191-0/+21
|
* build: Fix parallel build of haskell bindingsMatthew Booth2009-11-191-7/+13
| | | | | | | ghc isn't clever enough not to stomp on itself when building dependencies. This change makes the 1 dependency explicit. It also adds a dependency on src/libguestfs.la.
* build: Fix inter-directory dependenciesMatthew Booth2009-11-1920-47/+171
| | | | | | | | | | | | | | | | | | | | | | | | | | | This change adds an explicit dependency on generator.ml for every file it generates, except java files. Java is left for another time because it's considerably trickier. It also adds a build rule for src/libguestfs.la so it can be rebuilt as required from other directories. It does this by creating a top level make file, subdir-rules.mk, which can be included from sub-directories. sub-directories need to define 'generator_built' to include local files which are built by generator.ml, and they will be updated automatically. This fixes parallel make, and will automatically re-create generated files when make is run from any directory. It also fixes the problem which efad4f53 was targetting. Specifically, src/guestfs_protocol.(c|h) had an erroneous dependency on stamp-generator, and therefore generator.ml, despite not being directly created by it. This caused them to be recreated every time generator.ml ran rather than only when src/guestfs_protocol.x was updated, which cascaded into a daemon and therefore appliance update. This patch also changes the contents of the distribution tarball by including files created by rpcgen.
* generator: Acquire lock to prevent two parallel runs of the generator.Richard Jones2009-11-191-6/+27
| | | | | | | | | | | | | This commit acquires a lock on a file to prevent two parallel runs of the generator from stomping on each other. The second run will wait for the first to complete before starting. The lock is acquired on the "HACKING" file because it's convenient -- we are already checking this file exists to make sure that we don't start off in the wrong directory. Tested by adding some artificial sleeps in the code to observe locking behaviour between two parallel runs.
* syntax-check: expand TABs in generator.mlJim Meyering2009-11-192-25/+25
| | | | | | | | | | | | | | | | | | | | | | Jim Meyering wrote: >>From 6f128e90afb055f9899011c4a592eb289e678936 Mon Sep 17 00:00:00 2001 > From: Jim Meyering <meyering@redhat.com> > Date: Thu, 19 Nov 2009 11:39:10 +0100 > Subject: [PATCH libguestfs] syntax-check: expand TABs in generator.ml > > * src/generator.ml: Expand leading TABs to spaces. That was incomplete. Please use the following instead. With it, now, "make syntax-check" now passes once again. >From 716a30d0b692972aac8fbea1fb7ad3318ab3a0d8 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering@redhat.com> Date: Thu, 19 Nov 2009 11:39:10 +0100 Subject: [PATCH libguestfs] syntax-check: expand leading TABs * src/generator.ml: Expand leading TABs to spaces. * fuse/test-fuse.sh: Likewise.
* syntax-check: exempt *.pod from no-trailing-blank prohibitionJim Meyering2009-11-191-0/+1
| | | | * .x-sc_trailing_blank: Exempt *.pod.
* BUILT_SOURCES now depends on running the generator.Richard Jones2009-11-181-1/+1
| | | | This completely reverts commit efad4f53923dcca94613e193d6383bd032e70498.
* daemon/RHEL: Choose correct udev settle script.Richard Jones2009-11-181-1/+21
| | | | | | | | | On RHEL/CentOS 5.4, udevadm settle command does not work. This didn't affect us before, but now that we're using parted for partitioning, we *do* need to wait for udev to settle (because parted isn't waiting for this, unlike sfdisk). This commit chooses the correct program to run.
* fuse/RHEL: Don't require UTIME_{NOW,OMIT} to be defined.Richard Jones2009-11-181-0/+8
| | | | | These macros don't exist on RHEL/CentOS 5.4. If the feature is missing then just don't implement it in the FUSE layer.
* appliance: Print uptime.Richard Jones2009-11-181-2/+4
| | | | | Print the uptime just before the init script runs the daemon, so we have a good idea of how long the kernel boot + init script takes to run.
* recipes: Fix git URL.1.0.79Richard Jones2009-11-181-1/+1
|
* Prepare for version 1.0.79.Richard Jones2009-11-183-722/+730
|
* fuse: Add test-fuse.sh to EXTRA_DIST.Richard Jones2009-11-181-1/+1
|
* generator: Fix API of functions that return RBufferOutRichard Jones2009-11-182-16/+38
| | | | | | | | | | | | | | | | | | | | | (NB: The API / ABI doesn't actually change here - it's just made much simpler to use). The API for RBufferOut functions was unexpectedly hard to use in the case where a zero-length buffer might be returned. For discussion on this see: https://www.redhat.com/archives/libguestfs/2009-November/thread.html#00115 This commit ensures that in the zero-length buffer case, the return value is never NULL. Thus code is now able to just check if the return value == NULL to indicate an error, which is simpler for all concerned. The implementation of this is, however, more complex because we have to be careful about this case inside both the daemon and the library code, which is what this commit does. This has passed a full round of tests.
* fuse: Add tests for guestmount.Richard Jones2009-11-172-0/+226
| | | | | This script contains non-exhaustive tests for the system calls implemented by guestmount.
* fuse: Fix read for empty files.Richard Jones2009-11-171-1/+7
| | | | | Error handling for the guestfs_pread call was incorrect, which meant that empty files could produce spurious error messages.
* fish: Improve output of guestfish -h cmdRichard Jones2009-11-172-4/+6
| | | | | | Display this output like a short manual page. Don't put <..> around the parameters to the command.
* New API call: fill - fill a file with octetsRichard Jones2009-11-175-1/+92
|
* fuse: Fix cache invalidation in rename operation.Richard Jones2009-11-171-0/+1
| | | | | We need to invalidate both parameters, otherwise the old (moved) file can appear that it still exists after the move.
* fuse: Fix hard link creation.Richard Jones2009-11-171-1/+2
| | | | | The parameters were swapped. We also need to invalidate the cache for both parameters.
* fuse: Fix symlink creation (RHBZ#538069).Richard Jones2009-11-171-1/+1
| | | | The parameters were swapped, preventing symlinks from being created.
generated by cgit (git 2.34.1) at 2025-09-27 20:02:51 +0000