summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* maint: use $var notation rather than ${var} when possibleJim Meyering2012-01-2310-17/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I noticed some uses of ${srcdir} in shell scripts. That is almost always better written as $srcdir. The patch below converts most such variable references. Here are the few remaining candidates: $ git grep -i -E '\$\{[a-zA-Z_0-9]+\}'|grep -v Makefile.in.in configure.ac: JAR_INSTALL_DIR=\${prefix}/share/java configure.ac: JNI_INSTALL_DIR=\${libdir} debian/rules: for TEST in ${DEBIAN_SKIP_TEST}; do \ debian/rules:# mv $${mod} $$(dirname $${mod})/libguestfsmod.so; \ java/Makefile.am:libguestfs_jar_DATA = libguestfs-${VERSION}.jar java/Makefile.am:libguestfs-${VERSION}.jar: $(libguestfs_jar_class_files) perl/lib/Sys/Guestfs/Lib.pm: "-f", '${Package} ${Version} ${Architecture} ${Status}\n', perl/typemap: croak (\"${Package}::$func_name(): called on a closed handle\"); perl/typemap: croak (\"${Package}::$func_name(): $var is not a blessed HV reference\"); tests/data/Makefile.am: echo "$${i}abcdefghijklmnopqrstuvwxyz"; \ We could change all of those, too, except the ones in configure.ac and Makefile.am, since they refer to Make variables. Even those should be changed, but to use the preferred Makefile notation: $(prefix), $(libdir), $(VERSION). >From a86770ecd45666232a94d76c8725c8f9b1c76e3a Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering@redhat.com> Date: Mon, 23 Jan 2012 11:15:12 +0100 Subject: [PATCH libguestfs] maint: use $var notation rather than ${var} when possible The only case to avoid in a shell script is when the byte after the "}" is word-constituent, and concatenating it would thus change the name of the variable. These changes were induced by running this command: git grep -l -i -E '\$\{(srcdir|md)' \ |xargs perl -pi -e 's/\$\{(srcdir|md)\}($|\w)/\$$1$2/gi' The "g" was needed because there was one line with two instances. The "i" is to handle ${SRCDIR}. The ($|\w) ensures that concatenating whatever follows the "}" won't change semantics. * gobject/run-bindtests: Use "$srcdir", not "${srcdir}". * haskell/run-bindtests: Likewise. * java/run-bindtests: Likewise. * ocaml/run-bindtests: Likewise. * perl/run-bindtests: Likewise. * python/run-bindtests: Likewise. * ruby/run-bindtests: Likewise. * tests/guests/guest-aux/make-debian-img.sh: Likewise, but $SRCDIR. * tests/guests/guest-aux/make-ubuntu-img.sh: Likewise. * tests/guests/guest-aux/make-windows-img.sh: Likewise. * tests/md/test-mdadm.sh: Likewise, but $md.
* Update API support.Richard W.M. Jones2012-01-2324-474/+11234
|
* gobject: Run bindtests from srcdir.Hilko Bengen2012-01-231-2/+2
|
* build: don't use automake-internal variableJim Meyering2012-01-231-2/+2
| | | | | | | | | | | | | | | | Hi Rich, I realized a day or two late that my suggestion was not quite right. Here's the fix: >From 5294c21cf07c4ec2f094182ba9f32696f3de2751 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering@redhat.com> Date: Mon, 23 Jan 2012 10:01:40 +0100 Subject: [PATCH libguestfs] build: don't use automake-internal variable * ocaml/Makefile.am (mlguestfs.cma): Use the documented variable form, $(libguestfsocaml_a_OBJECTS), not the $(am_libguestfsocaml_a_OBJECTS) that I suggested for commit 1.15.16-17-g8b9eaec.
* check for febootstrap etc. even if not building applianceHilko Bengen2012-01-231-31/+32
|
* fish: Filter out error messages about history file in test scriptHilko Bengen2012-01-231-1/+1
|
* Do not run appliance-related checks if not building applianceHilko Bengen2012-01-2315-13/+56
|
* Replace setting of environment variables with usage of local run scriptHilko Bengen2012-01-2319-63/+21
| | | | (Includes fix by RWMJ)
* php: function_entry -> zend_function_entry.Richard W.M. Jones2012-01-221-1/+1
| | | | | | function_entry was left over from PHP 3. See: http://news.php.net/php.pecl.dev/7123
* php: Enable 'make clean' in extension subdirectory.Richard W.M. Jones2012-01-221-4/+4
|
* Version 1.15.19.1.15.19Richard W.M. Jones2012-01-2220-2278/+2323
|
* gobject: Include bindtests-manual.js in EXTRA_DIST.Richard W.M. Jones2012-01-221-3/+7
| | | | This fixes commit 93b0769ec7929a909678411d75840f81bed55a81.
* gobject: Document these bindings in guestfs(3).Richard W.M. Jones2012-01-221-0/+7
|
* website: Rebuild the HTML manual pages from scratch.Richard W.M. Jones2012-01-221-0/+5
|
* daemon: Move internal-autosync function to new file internal.c.Richard W.M. Jones2012-01-214-18/+48
| | | | This is just code motion.
* gobject: Add bindtests for return valuesMatthew Booth2012-01-202-0/+111
|
* bindtests: Test optargs in test0Matthew Booth2012-01-205-33/+237
| | | | | | | | Note that this change disables compiling and running the haskell bindtests. The haskell bindings do not implement optargs, and adding optargs to test0 causes that method not to be bound in the haskell bindings. This prevents the haskell bindtests from compiling. These should be re-enabled when optargs are implemented.
* gobject: Add basic bindtestsMatthew Booth2012-01-206-2/+78
|
* run script: Add support for gobject introspectionMatthew Booth2012-01-201-3/+9
|
* gobject: Add GObject bindingsMatthew Booth2012-01-209-0/+1079
|
* generator: Add CamelName flagMatthew Booth2012-01-203-5/+15
| | | | | | | | | | We can make a good guess at camel case names for most APIs. For example, add_drive_opts can be automatically transformed to AddDriveOpts. However, other apis don't produce a satisfactory name when transformed automatically. For example, we would want md_create to produce MDCreate rather than MdCreate. This change adds a CamelName flag which allows a camel case name to be specified explicitly when the automatic transformation isn't satisfactory.
* resize, sparsify: find progress mini-library in out-of-tree buildsHilko Bengen2012-01-202-2/+2
|
* Fixed out-of-tree compilation of OCaml code after .depend files removalHilko Bengen2012-01-203-8/+11
|
* fish: Remove hard-coded path from test scriptHilko Bengen2012-01-201-1/+1
|
* c: Fix prototype generator when last argument is a BufferInMatthew Booth2012-01-201-1/+7
| | | | | | We were passing the name of the last argument directly to va_start. However, if the last argument is a BufferIn it expands to 2 arguments, the latter of which is <name>_size.
* bindtests: Add a test for RBufferOutMatthew Booth2012-01-202-0/+2
| | | | Fixup the existing test, and add an entry in actions so it's actually generated.
* bindtests: Fix sscanf test in test0rhashtableMatthew Booth2012-01-201-1/+1
|
* bindtests: Add something non-zero to the RStructList test outputMatthew Booth2012-01-201-0/+3
|
* Update release notes with feedback from Hilko Bengen.Richard W.M. Jones2012-01-201-3/+1
|
* Revert "generator: Add CamelName flag"Richard W.M. Jones2012-01-203-13/+5
| | | | This reverts commit 83c20f02dc0e97b098e9de837839a3f4a4416129.
* Version 1.15.18.1.15.18Richard W.M. Jones2012-01-1918-113/+105
|
* Update release notes.Richard W.M. Jones2012-01-191-1/+12
|
* daemon: Run udev_settle after pwrite-device finishes.Richard W.M. Jones2012-01-192-4/+17
| | | | | | | When you call close on any block device, udev kicks off a rule which runs blkid to reexamine the device. We need to wait for this rule to finish running since it holds the device open and can cause other operations to fail, notably BLKRRPART.
* appliance: Add psmisc package to the appliance.Richard W.M. Jones2012-01-191-0/+1
| | | | This allows us to use 'fuser' and other ps tools.
* daemon: pwrite/pread: Don't double close on error path.Richard W.M. Jones2012-01-191-2/+0
| | | | | In Linux, close (fd) closes the file descriptor even if it returns an error.
* Tempus fugit.Richard W.M. Jones2012-01-18183-298/+298
| | | | Update all copyright dates to 2012.
* tools: Mark obsolete tools clearly in the man pages.Richard W.M. Jones2012-01-183-3/+7
|
* Version 1.15.17.1.15.17Richard W.M. Jones2012-01-1821-19234/+21632
|
* lib: Use -fvisibilty=hidden by default; only ABI symbols are now visible.Richard W.M. Jones2012-01-183-36/+48
| | | | http://gcc.gnu.org/wiki/Visibility
* ocaml: Use automake to build the C part of the bindings.Richard W.M. Jones2012-01-181-18/+21
| | | | | By arranging the C part of the bindings into a library, we can get automake to build it instead of using $(CC) directly.
* ocaml: Don't include guestfs-internal.h directly.Richard W.M. Jones2012-01-182-2/+2
| | | | | | However since the OCaml bindings use guestfs_safe_strdup and guestfs_safe_memdup we need to export those two (in the private functions section) from <guestfs.h>.
* ocaml: Add -Wno-missing-field-initializers to avoid a warning.Richard W.M. Jones2012-01-181-0/+4
|
* New tool: virt-format: erase and make blank disks.Richard W.M. Jones2012-01-1810-1/+758
| | | | | This tool allows you to easily reformat a disk, creating a blank disk with optional partition, LVM and empty filesystem.
* fish options parsing: Allow add_drives to be called multiple times.Richard W.M. Jones2012-01-189-28/+23
| | | | | | Ensure that the drv structure is always zeroed on allocation. Don't leak old drv->device when add_drives is called multiple times.
* c: Allow NULL optargs to be passed to _argv callsMatthew Booth2012-01-171-0/+15
| | | | | | Previously, passing NULL optargs to an _argv call resulted in a segfault. This change causes NULL optargs to be interpreted as no optargs, and to be correctly handled accordingly.
* c: NFC Remove redundant parenthesesMatthew Booth2012-01-171-1/+1
|
* generator: Add an explicit Cancellable flagMatthew Booth2012-01-173-19/+43
| | | | | | | | | Currently any api which takes a FileIn or FileOut parameter is implicitly cancellable. This change make cancellable an explicit flag in anticipation of it being added to other apis. Note that a Cancellable function must be able to return an error, which means it can't return RConstOptString.
* generator: Add CamelName flagMatthew Booth2012-01-173-5/+13
| | | | | | | | | | We can make a good guess at camel case names for most APIs. For example, add_drive_opts can be automatically transformed to AddDriveOpts. However, other apis don't produce a satisfactory name when transformed automatically. For example, we would want md_create to produce MDCreate rather than MdCreate. This change adds a CamelName flag which allows a camel case name to be specified explicitly when the automatic transformation isn't satisfactory.
* resize2fs-M: fix double-free along error path (thanks Matthew Booth).Richard W.M. Jones2012-01-161-4/+2
|
* e2fsck: Tidy up the documentation for this API.Richard W.M. Jones2012-01-161-4/+8
|