| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If this string was non-empty, then it broke a lot of things because
autoconf and other parts of the build system were expecting this
string to contain a simple MAJOR.MINOR.RELEASE version number.
This requires changes to guestfish and guestmount so they use the
guestfs_version API to fetch the version from the library. (The
Perl tools were already doing it this way). In a way this is more
accurate, because it's no longer hard-coded in the binary, but
fetched from the dynamically linked libguestfs.so.
(cherry picked from commit 4932fdca3ca1e9002164a1c0b73876f32739d34d)
|
| |
|
|
|
|
| |
(cherry picked from commit daead56fae46a4fedfef176fa3ed1ba37f88a078)
|
|
|
|
|
|
|
|
| |
Two bits of XDR both contained a definition called 'str' which
means that 'xdr_str' was being exported globally twice. Because
of the linker script this didn't affect us. But it's best to
rename this global so that conflicts cannot arise.
(cherry picked from commit 27ef6f9171127afd248f38d280cf3d0eae51fdaf)
|
|
|
|
|
|
| |
Without this option, qemu will read some defaults from /etc/qemu/
configuration files.
(cherry picked from commit 6d15d4e7c27477507ba355384a340ce86cec617b)
|
|
|
|
|
| |
Don't print them because no one's listening ...
(cherry picked from commit 5c1346dae72064f7fd9c2afe5517afc6f050cd9a)
|
|
|
|
|
| |
This is just code movement.
(cherry picked from commit 4b753c62089be663ac722e4a875bb061d259e87d)
|
|
|
|
|
|
|
|
| |
This is just code movement.
For stable-1.4 branch, cherry picked from
commit a2d4a8bf073c3551d174bd6c406e0cf3d27fb560
and backported.
|
|
|
|
| |
(cherry picked from commit 4d2f1632ad655130fafab3bf7fe8fa5cb59705d8)
|
|
|
|
|
| |
This haven't been used -- and haven't worked -- for a long time.
(cherry picked from commit c56fa58721a710aeb4a41bd73a472354a2128069)
|
|
|
|
|
|
| |
These are already defined in "guestfs-internal.h" which is
included in the .c file.
(cherry picked from commit 3cd272fc6acb043b4002dbcbbf741cecbc4820be)
|
|
|
|
| |
(cherry picked from commit 3905cc7ab496549b6ca0a0f67ec61d1d16968c33)
|
| |
|
|
|
|
| |
(cherry picked from commit 29925244c1be2d1d5f71d46eba205278624a1366)
|
|
|
|
|
|
|
|
| |
This is an update to commit 41f25ab3df5f306ac717fa7a6efd58328d30c1ae.
Internal functions should be named guestfs___* (3 underscores) to
avoid clashing with the implementation of actions (2 underscores).
(cherry picked from commit 737181bcd7b1de8c3a613d6282030c34efa78fb6)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We split the library code into these separate files:
- guestfs.c: creating handles, closing handles, handle-related variables
- actions.c: generated library-side stubs for each action
- bindtests.c: generated code to test bindings
- launch.c: launching the appliance
- proto.c: the library side of the daemon communications protocol
This is just code movement.
Cherry picked from commit 41f25ab3df5f306ac717fa7a6efd58328d30c1ae
and rebased for stable branch.
|
|
|
|
|
|
| |
Rename these two generated files, in preparation for splitting
up the main src/guestfs.c file.
(cherry picked from commit a617f521a4f695a63ced1c734128dc6c05b7024f)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some tests in the regressions directory deliberately print
error messages. As long as they still PASS, this is OK.
However these tests also printed some misleading messages
about what error to expect. Since error messages were slightly
different across distros, these messages were not accurate.
Therefore remove these messages, and replace with a general
message before all tests telling users not to worry about
errors from the tests as long as the tests don't fail.
(cherry picked from commit e7ee6eebed6ee3a5b56c0482ba2770e697d8febc)
|
|
|
|
| |
(cherry picked from commit 2fd8c259d3daa88b0cdf98090bb57f3dbd178432)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding the readonly=on option is not so clever. This causes
qemu to present the disk as read-only to the guest. (The
expected behaviour of snapshots=on,readonly=on was that it
would open the disk O_RDONLY but present a writable disk to
the guest).
Since the guest sees a read-only disk, we are unable to do any
recovery if a filesystem on the disk is inconsistent. This basically
prevents most accesses to live disk images.
What we really want is a qemu option which presents a writable
disk to the guest, but only opens the disk on the host side with
O_RDONLY, to alleviate the udev bug RHBZ#571714.
This reverts commit 676462684e05dd8341dd695762dd99a87d8ec022.
(cherry picked from commit 799d52be4f08f6c70c0e8ba1aa7367ba4cdd78c4)
|
|
|
|
|
|
| |
The 'name' parameter is not used on the right hand side of the
match, so it can be removed.
(cherry picked from commit 2e7da2a2f3bbc6d6db148d7dc2ce238bf56f34db)
|
|
|
|
|
|
|
|
|
|
| |
This resolves a warning from gcc 4.5:
assuming signed overflow does not occur when simplifying
conditional to constant
This page explains the issues in some detail:
http://www.airs.com/blog/archives/120
(cherry picked from commit 321ca1ef91a90cec5b94058b84420e8018e3f1d8)
|
|
|
|
|
|
| |
Only one function currently uses DeviceList. The generated code
unfortunately hard-coded the argument name from that function.
(cherry picked from commit aac51942aab63a9355ad6724345ea923148bf2a9)
|
|
|
|
|
|
| |
Various language bindings simply need this, so we have to allow
it even though it's a GCC extension.
(cherry picked from commit 0c0976496dafda4d172c5a7fc787d6a87d5bce8d)
|
|
|
|
| |
(cherry picked from commit 5b77be72bc4e46c7a53a24f1eb4cbd107a708f17)
|
| |
|
|
|
|
| |
(cherry picked from commit 70d27f6e796097630134bd8ebc2b65a65b1bf5c4)
|
|
|
|
|
|
|
|
|
| |
Note to self: The 'tempfile' function does *not* default to
removing files with the program exits!
For stable-1.4 branch:
- Cherry picked from commit 10ea14a3f1adb7023dd0601e4759bd24a030a1c3
- Rebased
|
|
|
|
|
|
|
| |
Add BUGS and RELEASE-NOTES to EXTRA_DIST.
Update RELEASE-NOTES by copying the final file from the
development branch.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Testing this against a Fedora disk image:
$ ./fish/guestfish --ro -a F13.img -m /dev/sda1 --listen
export GUESTFISH_PID=6033
$ ./fish/guestfish --remote=6033 -- ping-daemon
$ ./fish/guestfish --remote=6033 -- ping-daemon
$ ./fish/guestfish --remote=6033 -- exit
Without this fix the first remote command would fail because
qemu would have already been killed.
|
| |
|
| |
|
|
|
|
| |
See: http://lists.fedoraproject.org/pipermail/devel/2010-June/137953.html
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There's a thread safety issue with the current OCaml bindings which
is well explained in the bug report:
https://bugzilla.redhat.com/show_bug.cgi?id=604691
This commit fixes the safety issue by copying strings temporarily
before releasing the thread lock. Updated code looks like this:
char *filename = guestfs_safe_strdup (g, String_val (filenamev));
int r;
caml_enter_blocking_section ();
r = guestfs_add_drive_ro (g, filename);
caml_leave_blocking_section ();
free (filename);
if (r == -1)
ocaml_guestfs_raise_error (g, "add_drive_ro");
Also included is a regression test.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This add an optional explicit $g->close method which may be
used to force the handle to be closed immediately. Note the
provisos about this method in the manual page entry. Callers
should *not* normally use this method.
The implementation of the handle also changes. Before, the
handle was a blessed reference to an integer (the integer
being the pointer to the C guestfs_h handle). Now we change
this to a hashref containing currently the following field:
_g => pointer to C guestfs_h handle (as an integer)
If this field is not present, it means that the handle has been
explicitly closed. This avoids double-freeing the handle.
The user may add their own fields to this hash in order to store
per-handle data. However any fields whose names begin with
an underscore are reserved for use by the Perl bindings.
This commit also adds a regression test.
This commit also changes the existing warning when you call
a method without a Sys::Guestfs handle as the first parameter,
into an error. This is because such cases are always errors.
|
|
|
|
| |
Read the note in the man page before using this feature.
|
| |
|
| |
|
|
|
|
| |
This reverts commit f8ee7869f4836427109959cf20e299a31fa86eaf.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before this commit, if you used the -h and --csv options together
you would get these warnings from virt-df:
$ virt-df -h --csv Guest
Virtual Machine,Filesystem,Size,Used,Available,Use%
Argument "13.5G" isn't numeric in printf at /home/rjones/d/libguestfs/tools/virt-df line 298.
Argument "4.7G" isn't numeric in printf at /home/rjones/d/libguestfs/tools/virt-df line 298.
Argument "8.1G" isn't numeric in printf at /home/rjones/d/libguestfs/tools/virt-df line 298.
"/dev/vg_trick/RHEL55x64","/dev/VolGroup00/LogVol00",13,4,8,34.8%
Argument "98.7M" isn't numeric in printf at /home/rjones/d/libguestfs/tools/virt-df line 298.
Argument "18.8M" isn't numeric in printf at /home/rjones/d/libguestfs/tools/virt-df line 298.
Argument "74.9M" isn't numeric in printf at /home/rjones/d/libguestfs/tools/virt-df line 298.
"/dev/vg_trick/RHEL55x64","/dev/vda1",98,18,74,19.0%
We could fix this so that the human-readable numbers get written
into the CSV file. However would probably be wrong for most uses
of the CSV format (databases and spreadsheets) since they would not
be able to interpret these human-readable numbers, or worse could
misinterpret, eg. thinking that "1M" and "1G" are both 1.
Therefore this commit disallows this combination of options.
|