summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Version 1.19.41.1.19.41Richard W.M. Jones2012-09-1620-4335/+4803
|
* extra-tests: Write a qemu wrapper script on the fly.Richard W.M. Jones2012-09-153-26/+14
| | | | | | | | | | | Passing the $upstream_qemu environment variable is not reliable when libvirt is involved: Environment variables are passed to the first instance of the session libvirtd, but because libvirt reuses the session libvirtd, subsequent environment variable settings are lost (this is filed as RHBZ#856619). Bypass all of this by writing a custom qemu-wrapper.sh which contains the hard-coded values we want.
* extra-tests: Rerun extra tests with regular appliance attach method.Richard W.M. Jones2012-09-152-1/+35
| | | | | If libvirt is being used as the backend, rerun all the extra-tests again using the regular appliance backend.
* extra-tests: The upstream qemu test now reruns all the extra tests.Richard W.M. Jones2012-09-153-10/+12
|
* extra-tests: Fix libvirt URI so we can run tests with libvirt attach-method.Richard W.M. Jones2012-09-151-14/+10
|
* syntax: Remove trailing whitespace.Richard W.M. Jones2012-09-1512-16/+11
| | | | Found by 'make syntax-check'.
* generator: Remove inaccurate comment.Richard W.M. Jones2012-09-151-20/+0
| | | | | The correct way to extend functions is documented in generator/README. This comment was no longer accurate.
* syntax: Replace test == with = or -eq as appropriate.Richard W.M. Jones2012-09-152-12/+12
| | | | Found by 'make syntax-check'.
* syntax: xfs: Rewrite split_strdup function to avoid use of strncpy.Richard W.M. Jones2012-09-151-6/+8
| | | | Found by 'make syntax-check'.
* syntax: Use STREQ/STRNEQ in place of strcmp.Richard W.M. Jones2012-09-153-3/+5
| | | | Found by 'make syntax-check'.
* syntax: Remove include <signal.h> in file that doesn't use it.Richard W.M. Jones2012-09-151-1/+0
| | | | Found by 'make syntax-check'.
* syntax: Remove PATH_MAX-sized buffers allocated on the stack.Richard W.M. Jones2012-09-154-15/+33
| | | | | | | | | | | | | | On Linux PATH_MAX is 4096, but on some platforms it can be much larger or even not defined (ie. unlimited). Therefore using a PATH_MAX-sized stack buffer is not a great idea for portable programs. This change removes use of PATH_MAX-sized stack-allocated buffers. This change only applies to the library and standalone programs. Inside the daemon, memory allocation is much more complicated so I have not changed those (yet). Found by 'make syntax-check'.
* syntax: Remove gnulib "ignore-value.h" in files that don't use it.Richard W.M. Jones2012-09-157-8/+0
| | | | Found by 'make syntax-check'.
* syntax: Remove include <dirent.h> in files that don't use it.Richard W.M. Jones2012-09-152-2/+0
| | | | Found by 'make syntax-check'.
* syntax: Remove gnulib c-ctype.h in files that don't use it.Richard W.M. Jones2012-09-158-9/+0
| | | | Found by 'make syntax-check'.
* syntax: Remove include <assert.h> where assert is not used.Richard W.M. Jones2012-09-155-5/+0
| | | | Found by 'make syntax-check'.
* lib: Rearrange headers.Richard W.M. Jones2012-09-152-10/+8
| | | | This is just code motion.
* lib: Remove unused headers <arpa/inet.h> and <netinet/in.h>Richard W.M. Jones2012-09-152-4/+0
| | | | | These were used back in the day when we used TCP for the communications channel with the guest.
* syntax: Remove HAVE_*_H tests which are always true.Richard W.M. Jones2012-09-153-42/+7
| | | | | Gnulib supplies replacements for these headers, so there is no need to test.
* perl: Add <stdio.h> and <stdlib.h> for printf and malloc.Richard W.M. Jones2012-09-151-0/+2
|
* perl: Include <inttypes.h> and assume it always defines PRId64 and PRIu64.Richard W.M. Jones2012-09-151-8/+2
| | | | | | If these are not defined in the header files, it's a problem on the platform which we should fix with gnulib. Our replacement definitions might be wrong here.
* lib: These optargs structures are not modified, hence const.Richard W.M. Jones2012-09-151-3/+3
|
* syntax: Remove test for TAB indentation.Richard W.M. Jones2012-09-151-8/+0
| | | | | Nothing particularly wrong with using TABs for indentation, and this test also has a lot of false positives.
* syntax: xfs: Remove useless if before free.Richard W.M. Jones2012-09-151-4/+4
| | | | Found by running 'make syntax-check'.
* docs: Fix documentation of syntax-check target, add extra-tests.Richard W.M. Jones2012-09-151-2/+7
|
* faq: Make the legal section less unnecessarily legalistic.Richard W.M. Jones2012-09-141-6/+7
|
* faq: Tidy up headings.Richard W.M. Jones2012-09-141-12/+16
|
* faq: Add more answers about read-only disks.Richard W.M. Jones2012-09-141-0/+35
|
* launch: libvirt: Enable sVirt.Richard W.M. Jones2012-09-141-21/+0
|
* test-9p: Disable this test with libvirt.Richard W.M. Jones2012-09-141-2/+2
| | | | | This test doesn't work with sVirt if SELinux is enforcing, because qemu won't be able to access the 9p-exported directory on the host.
* build: Create new 'tmp' directory for tests.Richard W.M. Jones2012-09-145-3/+21
| | | | | | | | | | | | Having a separate directory means: (1) It's easy to clean up orphaned temporary files, the appliance, etc. (2) You can put an SELinux label on this directory so that qemu can write to it when you're using sVirt and SELinux is enforcing: chcon --reference=/tmp tmp
* launch: libvirt: Mark appliance disk as <shareable/> (thanks Dan Berrange).Richard W.M. Jones2012-09-141-0/+3
| | | | | | | | | | | This is a fix for multiprogramming: If two instances of libguestfs share the same appliance disk, then libvirt would unlabel the disk when one of the instances closes the handle, resulting in the other qemu being unable to continue accessing the appliance. Adding the flag makes libvirt understand that the disk is shared so it doesn't do this, and it apparently handles locking correctly too if we were using sanlock.
* test-tool: Print more environment variables.Richard W.M. Jones2012-09-141-7/+18
| | | | | This prints LIBVIRT_*, LIBVIRTD_*, LD_* and PATH, since these are all useful for debugging and could affect libguestfs in some way.
* fish: Replace '_' with '-' in deprecation cross-refs (thanks Olaf Hering).Richard W.M. Jones2012-09-132-3/+5
|
* lib: guestfs_disk_format: Set LC_ALL=C instead of LANG=C.Richard W.M. Jones2012-09-121-1/+1
| | | | | | LC_ALL takes precedence over LANG. See: http://pubs.opengroup.org/onlinepubs/7908799/xbd/envvar.html
* release-notes: Add 'draft' background image.Richard W.M. Jones2012-09-065-5/+91
|
* extra-tests: Don't use $QEMU as a variable.Richard W.M. Jones2012-09-052-6/+13
| | | | | | Since 'QEMU' is set (overwritten) by the autoconf-generated Makefile, this test would always test installed qemu, not upstream qemu, making it pretty useless. Use another name for this variable.
* generator: Remove generated and unused files from previous runs of the ↵Richard W.M. Jones2012-09-053-1/+44
| | | | | | | | | | | | generator. If you go back in time in git (eg. git reset, git bisect) then you can end up in a situation where a file that was generated by a later version is left around unused in the earlier version. This isn't a problem for most things, but gobject documentation generation picks up any file in a directory, even unreferenced ones, and breaks. So the correct thing to do is to remove these files.
* generator: gobject: Use a more normal way to output files.Richard W.M. Jones2012-09-052-100/+111
| | | | | The generator output is identical, verified by comparing the output files before and after the change.
* Version 1.19.40.1.19.40Richard W.M. Jones2012-09-043-5/+5
|
* sparsify: Fix use of closed handle (thanks Olaf Hering).Richard W.M. Jones2012-09-042-2/+2
| | | | | | | This fixes commit faaedeb3432253847107ca2c4530f681c6a1e385. Also contains an update to the test which tests the format auto-detect path.
* fix fuse_opt_add_opt_escaped return typeOlaf Hering2012-09-041-1/+1
| | | | | | | | | | I: Program returns random data in a function E: libguestfs no-return-in-nonvoid-function guestmount.c:75 The function fuse_opt_add_opt_escaped has only one caller and a return code is not checked. Signed-off-by: Olaf Hering <olaf@aepfle.de>
* Version 1.19.39.1.19.39Richard W.M. Jones2012-09-0420-23615/+24505
|
* shutdown: Add 'check_for_errors' hint along the shutdown path.Richard W.M. Jones2012-09-046-10/+26
| | | | | | | | This hint tells the backend whether anyone cares about errors when the appliance is shut down. Currently this only has any effect on the libvirt backend, where it controls whether or not we use the VIR_DOMAIN_DESTROY_GRACEFUL flag.
* launch: libvirt: Add VIR_DOMAIN_DESTROY_GRACEFUL flag.Richard W.M. Jones2012-09-041-2/+1
| | | | | | We want libvirt to report failures when destroying the guest. See: https://bugzilla.redhat.com/show_bug.cgi?id=853369#c12
* rescue: Add an expect-driven test for the virt-rescue command.Richard W.M. Jones2012-09-044-0/+67
| | | | | | | | This command was not tested at all. As a result we didn't notice that it was broken for a long time (RHBZ#853159). This adds a test that drives the command through a pty. It uses the perl 'Expect' module, although this is not required.
* proto: Don't set g->fd[] to /dev/null in direct mode, fixing virt-rescue ↵Richard W.M. Jones2012-09-041-13/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (RHBZ#853159). https://bugzilla.redhat.com/show_bug.cgi?id=853159 git bisect pointed to the following commit: commit ec8e3b6cad170d08ac18b580792dfb137eb171dc Author: Richard W.M. Jones <rjones@redhat.com> Date: Fri Jul 20 14:24:10 2012 +0100 launch: Abstract attach method operations. g->attach_ops points to a structure which contains the operations supported by each attach method backend (ie. appliance, unix, etc.). Since that commit was essentially just code motion, it wasn't clear why virt-rescue should be affected by it. In fact the reason is as follows: (1) In direct mode, we don't need g->fd[] (which would normally be connected to the stdin/stdout of qemu). So we opened them on /dev/null so they had some value. (2) accept_from_daemon / read_log_message_or_eof reads from g->fd[1]. Since this is connected to /dev/null, it always reads EOF. (3) This would cause child_cleanup to be called. This is completely unintentional: we don't want to cleanup the child at this point, even in direct mode. (4) Prior to the commit above, child_cleanup first waited for the process to exit (ie. waitpid). This happened to work, since we are effectively waiting for the user to exit virt-rescue. (5) After the commit above, the order of operations was changed so that we first killed qemu before waiting for it. This broke virt-rescue. The fix is to change direct mode so that it leaves g->fd[]'s as -1. The rest of the protocol code can deal with this situation -- it ignores the log fd instead of trying to read from it.
* rescue: If attach-method is 'libvirt', force it to be 'appliance'.Richard W.M. Jones2012-09-041-0/+16
| | | | | | The libvirt backend currently doesn't support direct mode. We should make that work in future. As a workaround, force the attach-method to be 'appliance' in this case.
* rescue: If -v / debugging enabled, don't mask error messages.Richard W.M. Jones2012-09-041-1/+2
| | | | | | | | We set the error handler to NULL in order to mask "normal" error messages that we expect to see because of the unusual way that virt-rescue runs the appliance. However if the user selected -v / enabled debugging, then it is reasonable to expect they want to see every message, so do not mask anything.
* launch: libvirt: Direct mode flag is not (yet) supported, so give an error ↵Richard W.M. Jones2012-09-041-0/+6
| | | | | | in this case. We definitely intend to support this in future.
generated by cgit (git 2.34.1) at 2025-08-30 21:24:36 +0000