| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
In the libguestfs live case we need to be careful not to modify the
real /etc/lvm/lvm.conf file (when setting the filter rule).
When the daemon starts, make a complete copy of /etc/lvm in a
temporary directory, and adjust LVM_SYSTEM_DIR to point to the copy.
All changes are made in the temporary copy.
|
|
|
|
|
|
| |
Although this doesn't matter for the ordinary (appliance) case, it
matters for the libguestfs live case. In that case it could cause the
guest to be exploited by a tmp/symlink attack.
|
| |
|
|
|
|
| |
Use virt-inspector --xpath option instead.
|
|
|
|
|
|
|
| |
xmlstarlet is good, but not available in Red Hat Enterprise Linux.
Build a simple but sane XPath query parser into virt-inspector
directly so that we don't need any external tools.
|
|
|
|
|
| |
This library is not available in RHEL 6, and in any case removing the
dependency is a simple change.
|
| |
|
|
|
|
|
|
|
|
|
| |
The major/minor fields only exist in Python >= 2.7. This works for at
least Python 2.5 and 2.6.
Thanks to Hilko Bengen.
This updates commit 646142f5136da9cfe2b908703a822c53350f70e9.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These fixes allow libguestfs bindings to work with Python 3 (tested
with Python 3.2)
You can select which Python you compile against by doing:
PYTHON=python ./configure && make && make check
or:
PYTHON=python3 ./configure && make && make check
|
|
|
|
|
|
|
|
| |
If the user set PYTHON when configuring, this variable is not passed
through to the tests, so it is possible the tests will fail because
they are testing the wrong version of python. By passing $PYTHON
through to the tests we ensure that we test against the same version
of python that we configured with.
|
|
|
|
| |
Ooops ...
|
|
|
|
|
|
|
|
| |
The manual for sys.version warns that you should not parse the string,
which we were doing. It would have failed on python "2.10" or
similar.
Do it correctly using the sys.version_info struct instead.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
| |
This is a short (10-15 min) talk that I give to introduce the main
features of libguestfs. The "slides" are in the form of a complete
self-contained HTML page with a handful images that can be easily
distributed before the talk.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
When given an invalid debug command, libguestfs responds with the
error message:
libguestfs: error: debug: use 'debug help' to list the supported commands
However this command does not work, as debug requires two
arguments. This change updates the message to prompt the user to use
'debug help 0'.
|
| |
|
|
|
|
|
| |
Because this is a useful introspection API, it is a candidate for
being backported into older stable branches.
|
| |
|
| |
|
|
|
|
|
| |
This warning was applied unevenly. Potentially any command can be
dangerous or safe, so it was a needless warning.
|
|
|
|
|
| |
This dependency is optional, don't fail the test if it's not
installed.
|
|
|
|
|
| |
This dependency is optional, so don't fail the test if it
is not installed.
|
|
|
|
| |
(thanks Matt Booth).
|
|
|
|
|
|
|
| |
size_after on Debian was 10136K. The host filesystem was ext3 (vs
ext4 for Fedora where we did the original testing). Probably indirect
blocks (vs more efficient extents on ext4) causes the difference,
although I did not look at it in detail.
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
Tools like virt-edit would not be able to edit disks marked as
<readonly/> in the libvirt XML. It's not clear if this is a bug or a
feature.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This optional argument controls how <readonly/> disks in
the libvirt XML are handled. It can be set to one of:
"write" (default) - add them R/W
"read" - add them R/O
"error" - throw an error if asked to add them R/W
"ignore" - ignore these disks
I have added limited regression tests for this feature. However
libvirt's test:/// XML does not allow you to specify that a domain
starts off shut down, so we cannot fully test this. Instead I tested
it by hand.
|
|
|
|
|
|
| |
This changes the private function guestfs___for_each_disk so that the
<readonly/> flag on libvirt disks is detected and passed through to
the callback function.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use a Gaussian distribution for random numbers so that smaller numbers
are chosen more frequently.
This also exposes a bug in this test which only happens when small
numbers are chosen:
If the test thread starts up quickly, it can get to
guestfs_user_cancel before the guestfs_upload command has happened in
the main thread. This causes the cancel to be ignored (correctly) and
we end up in the second loop writing data until the disk runs out of
space. Fix this by repeatedly asserting the cancel flag in the second
loop.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Commit 2910413850c7d9e8df753afad179e415f0638d6d caused Windows 7
resizes to break with the 0xc0000225 boot error.
Change the --align-first auto (default) option so that it is more
conservative about when it moves the first partition. In particular
it doesn't move it if it's already aligned (as it is for Win7), nor if
there is more than one partition (also Win7).
Tested with: Windows XP, 2003, 7, Ubuntu 10.10 and RHEL 5.
|
| |
|
| |
|
|
|
|
|
|
| |
Also we only permit MBR (DOS) and GPT partition tables. In theory
previously we allowed other partition table types, but it is unlikely
that it would have worked in reality.
|
|
|
|
|
|
|
|
|
|
|
| |
The four new APIs:
guestfs_copy_device_to_device,
guestfs_copy_device_to_file,
guestfs_copy_file_to_device, and
guestfs_copy_file_to_file
let you copy from a source to a destination, between files and
devices, optionally allowing source and destination offsets and size
to be specified.
|
|
|
|
|
|
|
|
| |
Add a dependency so these tools are rebuilt from scratch if the
Guestfs API changes. This prevents the error:
"[...] make inconsistent assumptions over interface Guestfs".
This commit includes the generated changes to .depend files.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds an extra column containing this information, looking
like this:
Name Type VFS Label MBR Size Parent
/dev/sda1 filesystem ntfs - - 6.0G -
/dev/sda1 partition - - 07 6.0G /dev/sda
/dev/sda device - - - 6.0G -
In particular you can use this to tell if a partition is an extended
partition, because the field will contain '05' or '0f'.
|
|
|
|
|
|
| |
This converts a partition device name (eg. /dev/sda1) to a partition
number (eg. 1). This is useful in conjunction with the parted APIs
that mostly take a disk device + partnum.
|
| |
|
| |
|
|
|
|
|
|
|
| |
Also add this option, if necessary, when testing for virtio-serial
support.
When the workaround is enabled, we specify machine type 'pc'.
|