summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* tests: Add a regression test for RHBZ#789960.Richard W.M. Jones2012-02-132-0/+69
| | | | | Test all the ways that the 'mount' command can fail. Ensure that none of them result in failures or desynchronization.
* regressions: One test is not being run.Richard W.M. Jones2012-02-131-0/+4
| | | | | | | | | rhbz727178.sh exists, but historically was never added to the list of tests, so it doesn't run. Create a special variable for this test and ensure it is added to EXTRA_DIST. Test was originally added in commit d7356a2801130907997acd5c7502e8417566e782.
* daemon: Return error properly when user tries to mount appliance root ↵Richard W.M. Jones2012-02-131-1/+4
| | | | | | | | | | | | (RHBZ#789960). In the case where the caller attempts to mount the "hidden" appliance root device (eg. /dev/vdb if /dev/vda is the only normal block device added), we were calling reply_with_error but not actually returning immediately, resulting in protocol desynchronization. This commit fixes this obvious mistake.
* daemon: Don't xdr_free uninitialized args struct on error paths.Richard W.M. Jones2012-02-131-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For stubs of functions that had arguments, code did this: static void mount_stub (XDR *xdr_in) { int r; struct guestfs_mount_args args; if (optargs_bitmask != 0) { //... goto done; } // possibly other tests here memset (&args, 0, sizeof args); [...] done: xdr_free ((xdrproc_t) xdr_guestfs_mount_args, (char *) &args); return; } This caused xdr_free to be called on uninitialized 'args' struct, causing a segfault. The fix is to add another label, so the code looks like: static void mount_stub (XDR *xdr_in) { int r; struct guestfs_mount_args args; if (optargs_bitmask != 0) { //... goto done_no_free; } // possibly other tests here memset (&args, 0, sizeof args); [...] done: xdr_free ((xdrproc_t) xdr_guestfs_mount_args, (char *) &args); done_no_free: return; } This fixes commit 330fbea5b2d6bd7db84f7ea7afe87cf1bcd438e0 and commit 0344248af55802bbbd816b349ec1ba9305996f6e.
* Do not run test-virt-format.sh if appliance has not been builtHilko Bengen2012-02-121-0/+2
|
* Version 1.17.6.1.17.6Richard W.M. Jones2012-02-1020-17150/+17649
|
* virt-format: Add a test.Richard W.M. Jones2012-02-102-7/+40
|
* fish: edit: Preserve permissions, UID, GID, SELinux context when editing ↵Richard W.M. Jones2012-02-102-1/+92
| | | | files (RHBZ#788641).
* fish: In edit command, upload to a new file.Richard W.M. Jones2012-02-104-3/+110
| | | | | | | If the upload fails, this means we don't leave a partially written file. Also add a test for the edit command.
* fish: Refactor error handling in the 'edit' command.Richard W.M. Jones2012-02-101-24/+17
| | | | This is just code motion.
* wipefs: Fix documentation.Richard W.M. Jones2012-02-101-3/+1
| | | | This fixes commit a2b3e0900ee14e5a49d526c24e22edefc3030f99.
* ocaml: Ensure bindings are recompiled whenever there is an API change.Richard W.M. Jones2012-02-101-7/+3
|
* wipefs: Include "optgroups.h".Richard W.M. Jones2012-02-101-0/+1
| | | | This fixes commit a2b3e0900ee14e5a49d526c24e22edefc3030f99.
* virt-format: erase the filesystem signatures before erase partitionsWanlong Gao2012-02-101-15/+4
| | | | | | | erase the filesystem signatures on each device, then erase the partitions, avoid to list all the partitions here. Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
* NEW API: add a new api wipefsWanlong Gao2012-02-104-3/+41
| | | | | | | Add the new api wipefs to erase the filesystem signatures on a device but now erase any data. Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
* docs: Note that JRuby should use the Java bindings.Richard W.M. Jones2012-02-091-0/+2
|
* New API: llz: This runs ls -laZ and is useful for showing SELinux contexts.Richard W.M. Jones2012-02-093-1/+36
|
* edit: Preserve file permissions, UID, GID, SELinux context on edited files. ↵Richard W.M. Jones2012-02-093-0/+93
| | | | (RHBZ#788641)
* java: Make use of JAR_INSTALL_DIR, JNI_INSTALL_DIRHilko Bengen2012-02-082-5/+9
|
* Version 1.17.5.1.17.5Richard W.M. Jones2012-02-0818-23/+29
|
* findfs: Remove /run/blkid/blkid.tab.Richard W.M. Jones2012-02-081-0/+1
| | | | | See this util-linux commit: https://github.com/karelzak/util-linux/commit/b82590ad46acf9fe8d332b53875e24c3c31e2482
* extra-tests: Add suppression for uninitialized memory bug in latest glibc.Richard W.M. Jones2012-02-081-0/+8
|
* extra-tests: libnl moved from /lib64 to /usr/lib64 on Fedora.Richard W.M. Jones2012-02-081-0/+13
| | | | Update suppressions file to match.
* perl: Ignore perl/MYMETA.jsonRichard W.M. Jones2012-02-071-0/+1
|
* blockdev, parted: Call udev_settle before and after commands. (RHBZ#769304)Richard W.M. Jones2012-02-062-52/+115
| | | | | | | See comments in the code for details. This is an alternate fix to commit a9c8123c72db47bcab8dd738e8d5256a9ae87f11.
* Revert "daemon: Run udev_settle after pwrite-device finishes."Richard W.M. Jones2012-02-062-17/+4
| | | | This reverts commit a9c8123c72db47bcab8dd738e8d5256a9ae87f11.
* build: Choose a virtual directory for the daemon which is not a symlink.Richard W.M. Jones2012-02-062-4/+27
| | | | | | | Check /sbin, /usr/sbin, /bin and /usr/bin to ensure that neither the directory nor the parent (eg. /usr) is a symlink, and use this directory for the virtual directory used to store guestfsd in the appliance.
* build: Remove 'run' from EXTRA_DIST.Richard W.M. Jones2012-02-031-1/+0
| | | | | | This file shouldn't be included in the tarball as it contains hard-coded paths from the maintainer's machine which cannot be relevant to the target machine.
* Version 1.17.4.1.17.4Richard W.M. Jones2012-02-0120-46/+65
|
* Clarify the error message when unavailable functions are called (RHBZ#679737).Richard W.M. Jones2012-02-018-136/+271
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Callers are supposed to use the availability API to check for functions that may not be available in particular builds of libguestfs. If they don't do this, currently they tend to get obscure error messages, eg: libguestfs: error: zerofree: /dev/vda1: zerofree: No such file or directory This commit changes the error message to explain what callers ought to be doing instead: libguestfs: error: zerofree: feature 'zerofree' is not available in this build of libguestfs. Read 'AVAILABILITY' in the guestfs(3) man page for how to check for the availability of features. This patch makes the stubs check for availability. The stub code changes to: static void zerofree_stub (XDR *xdr_in) { [...] /* The caller should have checked before calling this. */ if (! optgroup_zerofree_available ()) { reply_with_error ("feature '%s' is not available in this\n" "build of libguestfs. Read 'AVAILABILITY' in the guestfs(3) man page for\n" "how to check for the availability of features.", "zerofree"); goto done; } [...]
* examples: code cleanupsWanlong Gao2012-01-312-2/+2
| | | | | | do a code cleanup by removing the tailing spaces Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
* guestmount: use O_ACCMODE instead of hard codingWanlong Gao2012-01-301-1/+1
| | | | | | | Change hard code 3 to O_ACCMODE. it'll be more sensible. Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
* guestmount: remove tailing spacesWanlong Gao2012-01-301-2/+2
| | | | | | | just do a cleanup. remove the tailing spaces. Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
* daemon: Fix crash in aug-defnode (RHBZ#785668).Richard W.M. Jones2012-01-301-6/+15
|
* virt-alignment-scan: Fix typo in man page (thanks yurchor).Richard W.M. Jones2012-01-281-1/+1
|
* ocaml: Various fixes for bytecode compilation.Richard W.M. Jones2012-01-281-8/+15
| | | | | | | | | | | | Set LD_LIBRARY_PATH so we link against the just-built library, not the installed library. Use OCAMLCFLAGS instead of OCAMLOPTFLAGS where appropriate. Remove unnecessary -cclib option for bytecode linking (gcc is not used in this case). This fixes commit eb68a314133c88260cdf4547d7d338446488e698.
* Version 1.17.3.1.17.3Richard W.M. Jones2012-01-2818-20/+26
|
* ocaml: Sort the tests.Richard W.M. Jones2012-01-281-2/+3
|
* extra-tests: ocaml: Additional suppressions so we can test bytecode.Richard W.M. Jones2012-01-281-0/+14
|
* ocaml: Test bytecode and native code bindings.Richard W.M. Jones2012-01-273-24/+68
| | | | | Compile each test twice, as bytecode and native code, and test both.
* ocaml: Fix bytecode bindings for functions with >= 6 args.Richard W.M. Jones2012-01-271-1/+1
|
* Update to latest gnulib.Richard W.M. Jones2012-01-272-0/+1
| | | | | | | | This contains a workaround for stdalign bug: http://lists.gnu.org/archive/html/bug-gnulib/2012-01/msg00340.html http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52023 (Thanks Paul Eggert).
* appliance: udev >= 176 now requires /dev to be a devtmpfs.Richard W.M. Jones2012-01-271-0/+3
| | | | | See this udev commit: https://git.kernel.org/?p=linux/hotplug/udev.git;a=commitdiff;h=220893b3cbdbf8932f95c44811b169a8f0d33939
* Version 1.17.2.1.17.2Richard W.M. Jones2012-01-2619-23/+27
|
* build: Add gobject/TODO.txt to EXTRA_DIST.Richard W.M. Jones2012-01-261-1/+2
| | | | This updates commit dd25638fc14ea63cf8e8eb0940173f1c6952447f.
* build: Add contrib/make-check-on-installed.pl to EXTRA_DIST.Richard W.M. Jones2012-01-261-0/+1
| | | | This updates commit 3d0c9f3fc63395083fef798ee31058a0bea8432e.
* contrib: Add a script for running test suite on installed packages.Richard W.M. Jones2012-01-262-0/+184
|
* contrib: Delete 'removed' sections from the README file.Richard W.M. Jones2012-01-261-19/+0
| | | | There is no point in continuing to document removed stuff.
* fish: Fix 'test-guestfish-escapes.sh' when running an alternate guestfish ↵Richard W.M. Jones2012-01-261-12/+16
| | | | | | | | | | | binary. The error messages would be prefixed by the path to the alternate binary, eg: ../fish/guestfish: invalid escape sequence in string (starting at offset 0) Fix this by normalizing the messages further.
* ocaml: Don't install bindtests.*.Richard W.M. Jones2012-01-261-0/+1
|