| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
| |
(cherry picked from commit 86f64c37b914645afb345f96af13ad843ec641b1)
|
|
|
|
| |
(cherry picked from commit 94a7fb9fc5d04615f23f94c34eb90c35d20ba117)
|
|
|
|
| |
(cherry picked from commit ff2e685828ce6160de34756696069b80e35472e8)
|
|
|
|
|
| |
This is just a code clean-up with no functional change.
(cherry picked from commit 4c2101362edf5f2df5d018c3674b423de2a3538a)
|
|
|
|
| |
(cherry picked from commit aa978b75ae1df0d3111953114fafe0854c3f222e)
|
|
|
|
|
| |
This is just a code clean-up with no functional change.
(cherry picked from commit 43a6974cb35759d4772f610f3c92b0d31f0503ac)
|
|
|
|
| |
(cherry picked from commit f86c3a45ae19f5bb558ab9ead255ecaf004b24b0)
|
|
|
|
| |
(cherry picked from commit 9f8f1fd8560f2c3e7b625cf6d65a052cd061fd2e)
|
|
|
|
| |
(cherry picked from commit f65f653ab1541400afe2f796ab1b20cd721e769d)
|
|
|
|
|
|
| |
This uninitialized data was also sent over the protocol,
potentially being a serious information leak.
(cherry picked from commit 9cf7ecbe4fea5162b86e2c78c1a40cca737bc1da)
|
|
|
|
| |
(cherry picked from commit 84242a8d0bf9c37e700cd8a3436607dbc7908f1e)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This commit allows you to run the daemon under valgrind. You have to
enable it at configure time:
./configure --enable-valgrind-daemon
This should *not* be done for production builds.
When this feature is enabled, valgrind is added to the appliance and
the daemon is run under valgrind. Log messages from valgrind are
passed back over a virtio-serial channel into a file called
'valgrind.log.$PID' in the top build directory.
Running 'make check', 'make extra-tests' etc causes many
valgrind.log.* files to be created which must be examined by hand.
(cherry picked from commit d08806adfc5d111b4b6c761540ff508d3f25b66e)
|
|
|
|
| |
(cherry picked from commit b7122eaa58ccd153a8c39bc3b6f890755c5df089)
|
|
|
|
|
|
|
|
|
| |
This fixes...
configure: error: conditional "INSTALL_DAEMON" was never defined.
... when specifying --disable-daemon
(cherry picked from commit 22224254fa4676735985818d2ff3c8feafe4457c)
|
| |
|
|
|
|
|
| |
This fixes commit 37e07db1598b433c12ee643302712d81b2c5415d.
(cherry picked from commit 734b1f662f4e563cc8baad3aca8cf751314e0e49)
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
Fix the existing test to work correctly in this case.
Other cleanups.
|
|
|
|
|
| |
The GObject bindings require G_DEFINE_BOXED_TYPE, which was not added until
2.25.15. There are probably other dependencies.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I noticed some uses of ${srcdir} in shell scripts.
That is almost always better written as $srcdir.
The patch below converts most such variable references.
Here are the few remaining candidates:
$ git grep -i -E '\$\{[a-zA-Z_0-9]+\}'|grep -v Makefile.in.in
configure.ac: JAR_INSTALL_DIR=\${prefix}/share/java
configure.ac: JNI_INSTALL_DIR=\${libdir}
debian/rules: for TEST in ${DEBIAN_SKIP_TEST}; do \
debian/rules:# mv $${mod} $$(dirname $${mod})/libguestfsmod.so; \
java/Makefile.am:libguestfs_jar_DATA = libguestfs-${VERSION}.jar
java/Makefile.am:libguestfs-${VERSION}.jar: $(libguestfs_jar_class_files)
perl/lib/Sys/Guestfs/Lib.pm: "-f", '${Package} ${Version} ${Architecture} ${Status}\n',
perl/typemap: croak (\"${Package}::$func_name(): called on a closed handle\");
perl/typemap: croak (\"${Package}::$func_name(): $var is not a blessed HV reference\");
tests/data/Makefile.am: echo "$${i}abcdefghijklmnopqrstuvwxyz"; \
We could change all of those, too, except the ones in configure.ac
and Makefile.am, since they refer to Make variables. Even those
should be changed, but to use the preferred Makefile notation:
$(prefix), $(libdir), $(VERSION).
>From a86770ecd45666232a94d76c8725c8f9b1c76e3a Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Mon, 23 Jan 2012 11:15:12 +0100
Subject: [PATCH libguestfs] maint: use $var notation rather than ${var} when
possible
The only case to avoid in a shell script is when the byte after the
"}" is word-constituent, and concatenating it would thus change the
name of the variable.
These changes were induced by running this command:
git grep -l -i -E '\$\{(srcdir|md)' \
|xargs perl -pi -e 's/\$\{(srcdir|md)\}($|\w)/\$$1$2/gi'
The "g" was needed because there was one line with two instances.
The "i" is to handle ${SRCDIR}. The ($|\w) ensures that concatenating
whatever follows the "}" won't change semantics.
* gobject/run-bindtests: Use "$srcdir", not "${srcdir}".
* haskell/run-bindtests: Likewise.
* java/run-bindtests: Likewise.
* ocaml/run-bindtests: Likewise.
* perl/run-bindtests: Likewise.
* python/run-bindtests: Likewise.
* ruby/run-bindtests: Likewise.
* tests/guests/guest-aux/make-debian-img.sh: Likewise, but $SRCDIR.
* tests/guests/guest-aux/make-ubuntu-img.sh: Likewise.
* tests/guests/guest-aux/make-windows-img.sh: Likewise.
* tests/md/test-mdadm.sh: Likewise, but $md.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Hi Rich,
I realized a day or two late that my suggestion was not quite right.
Here's the fix:
>From 5294c21cf07c4ec2f094182ba9f32696f3de2751 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Mon, 23 Jan 2012 10:01:40 +0100
Subject: [PATCH libguestfs] build: don't use automake-internal variable
* ocaml/Makefile.am (mlguestfs.cma): Use the documented variable form,
$(libguestfsocaml_a_OBJECTS), not the $(am_libguestfsocaml_a_OBJECTS)
that I suggested for commit 1.15.16-17-g8b9eaec.
|
| |
|
| |
|
| |
|
|
|
|
| |
(Includes fix by RWMJ)
|
|
|
|
|
|
| |
function_entry was left over from PHP 3.
See: http://news.php.net/php.pecl.dev/7123
|
| |
|
| |
|
|
|
|
| |
This fixes commit 93b0769ec7929a909678411d75840f81bed55a81.
|
| |
|
| |
|
|
|
|
| |
This is just code motion.
|
| |
|
|
|
|
|
|
|
|
| |
Note that this change disables compiling and running the haskell bindtests. The
haskell bindings do not implement optargs, and adding optargs to test0 causes
that method not to be bound in the haskell bindings. This prevents the haskell
bindtests from compiling. These should be re-enabled when optargs are
implemented.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
We can make a good guess at camel case names for most APIs. For example,
add_drive_opts can be automatically transformed to AddDriveOpts. However, other
apis don't produce a satisfactory name when transformed automatically. For
example, we would want md_create to produce MDCreate rather than MdCreate.
This change adds a CamelName flag which allows a camel case name to be specified
explicitly when the automatic transformation isn't satisfactory.
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
We were passing the name of the last argument directly to va_start. However, if
the last argument is a BufferIn it expands to 2 arguments, the latter of which
is <name>_size.
|
|
|
|
| |
Fixup the existing test, and add an entry in actions so it's actually generated.
|
| |
|
| |
|
| |
|