summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Version 1.16.32.1.16.32Richard W.M. Jones2012-10-0120-4744/+5181
|
* daemon: When sorting devices, don't fail on mix of /dev/sd and /dev/vdRichard W.M. Jones2012-10-011-0/+8
| | | | | | | | | | | | | | | | (RHBZ#858128). If compare_device_names was given two devices with devices with different interfaces (eg. /dev/sda and /dev/vda) then it would try to compare the partition numbers, and fail when it could parse them. It's arguable what we should be doing in this case (except for strongly discouraging people from using the interface feature), but let's at least not cause the daemon to assert-fail. Found by Red Hat QA, thanks Mohua Li. (cherry picked from commit 6f53d49a27fbf7f1b5c22080e2509375e128d5e4) (cherry picked from commit 4ff32ca76ef11cc7a7b62ba2503c037cbd791b36)
* inspection: Fix calls to case_sensitive_path (RHBZ#858126).Richard W.M. Jones2012-10-015-34/+35
| | | | | | | | | | | | | | | | | | | | | | | | Don't assume that if guestfs_case_sensitive_path returns NULL, that it means the file does not exist. The (previously undefined) behaviour of case_sensitive_path was that a NULL return meant "either the file doesn't exist or some other error". However in commit 973581780d8a006f336684fef6762801402d775d this was changed so that if the last element of the path didn't exist, it was assumed to be a new file and the (non-NULL) path of the new file is returned. This change breaks code (including in libguestfs) which tries to use case_sensitive_path as a dual-purpose call to fix-up a path for Windows and test if the file exists. Such code should be rewritten so that it explicitly tests for file existence after calling case_sensitive_path. I examined all the calls to case_sensitive_path in libguestfs and modified them where necessary. Cherry picked from commit 9ea6e9701461e594033999150f930cc4fafec4d2. (cherry picked from commit ff610469fb8ad1d27dac5d3cb2f1e007d8c0ecc7)
* virt-edit: If case_sensitive_path returns an error, exit.Richard W.M. Jones2012-10-011-0/+2
| | | | | | | | | The 'windows_path' function was blindly copied from virt-cat. In virt-cat, errors are checked by the caller to 'windows_path'. But virt-edit lacks this check. Change the function in virt-edit to add a check and exit on error. (cherry picked from commit 55b7c4df7895b8c22d737723d857a9a63db69926) (cherry picked from commit dd913ddd0e78bd7f4a2a586fd824f467590f28d6)
* recipes: Add a section about diagnosing hanging guests.Richard W.M. Jones2012-10-011-0/+29
| | | | | (cherry picked from commit f7e138835a7194135113088767c46df65dbf292a) (cherry picked from commit f487298ed4cff3cbda26c0a62c94b9a5e71c13df)
* test-tool: Add prominent warning about including complete output.Richard W.M. Jones2012-10-011-0/+11
| | | | | | | | | Everyone ignores the documentation. Everyone ignores me even when I specifically tell them to include the complete output. Place a prominent notice at the beginning of the output. (cherry picked from commit 4f3048c6be0663c6c254a765ec5f83a7b40a8808) (cherry picked from commit 093d286f844b64dcb28543cec113c35208ea8e0d)
* test-tool: guestfs_get_path might return NULL.Richard W.M. Jones2012-10-011-1/+1
| | | | | | | It would almost certainly indicate a bug if it happens, but don't rely on printf not segfaulting if it did happen. (cherry picked from commit ca2e65275d797864d2a5b3b3d0e115460522e5bb) (cherry picked from commit c3eedd00d7d974613b4f8138211b8226e37b2c79)
* guestfs-testing(1): Start by running libguestfs-test-tool.Richard W.M. Jones2012-10-011-0/+14
| | | | | (cherry picked from commit 9b7813c5bd91d53e358deee64ab42b00b42c37ba) (cherry picked from commit 7d674f2fbfa663366c957f8662822f55ed1f2e1c)
* remove the useless "h" optionWanlong Gao2012-10-014-12/+0
| | | | | | | | "h" option is not enabled in virt-cat, remove it. Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com> (cherry picked from commit f7f746a98e8d378ac8934a7f7b82a48b3e2a5aa4) (cherry picked from commit 9b45ae5ddeb1703ba14a4eeefde53a45e03ce0c8)
* docs: Link to guestfs-recipes(1) from intro in guestfs(3).Richard W.M. Jones2012-10-011-0/+2
| | | | | (cherry picked from commit d19e557df54f3822d38621b8c2da098bf44b4d53) (cherry picked from commit b782d36589a981760625967b47b8e1d38aa1c90a)
* generator: Tidy up comments in guestfs_protocol.x.Richard W.M. Jones2012-10-011-8/+17
| | | | | (cherry picked from commit db6a8512402f068815f882928662af0d8f5eec83) (cherry picked from commit d7f08bc4f7b4fa50d15fcf74a41591ba952b9f1d)
* generator: Allow an optional emacs-mode at the top of generated files.Richard W.M. Jones2012-10-011-2/+7
| | | | | (cherry picked from commit a95d4261b8cedc31bfc3c5358be7b346b27d457b) (cherry picked from commit d8014089d1585810153f97fc75d8e5e93fb34b2f)
* test-launch-race: Add comment.Richard W.M. Jones2012-10-011-1/+1
| | | | | (cherry picked from commit 09c372ea250e8241d62e9fde70eabe7bdca83050) (cherry picked from commit 77ca1f94d5982a0b49a57b7787a7f89b6b0b7de4)
* ./run: Keep gnome-keyring from disturbing test script outputHilko Bengen2012-10-011-0/+4
| | | | | (cherry picked from commit 71f87d9a8f04212fc0534b3fb423780185181585) (cherry picked from commit 29d2be7d8e36068feea2bda5775a63672c15887c)
* rename local variable to avoid clash with match macroOlaf Hering2012-10-011-3/+3
| | | | | | | | match will expand to guestfs___match, rename the local variable to avoid clash. Signed-off-by: Olaf Hering <olaf@aepfle.de> (cherry picked from commit b36b44af9e177fe5c9677d430abc7cba0633049c) (cherry picked from commit 409a80476442a65b3c4498422fa6c812e21ba928)
* docs: Add links to various guestfs-* man pages from guestfs(3).Richard W.M. Jones2012-10-011-0/+4
| | | | | | Cherry picked from commit 64cc0dafd03bb23ef1520c8f46fd2dd44a0d8c4e. Remove ref to guestfs-release-notes(1) which doesn't exist in 1.18. (cherry picked from commit 9a01948a80cf4d6c3902b23c12d88e1b886dc4a5)
* recipes: Add section about uploading raw filesystem content.Richard W.M. Jones2012-10-011-0/+24
| | | | | (cherry picked from commit 8aa8eb205b02e1014e5ed9577f4a9da9fd864aba) (cherry picked from commit 53c4ec871d0d43dd628a9693b18017d1552ec651)
* launch: Make the "launched failed" message more explanatory.Richard W.M. Jones2012-10-012-2/+19
| | | | | | | | | | | Since this is the most common error seen by people who have installation problems, buggy qemu, etc, and since no one reads the FAQ, describe in this error message what resources are available to debug launch problems. Cherry picked from commit 840deea12079b05a9f588016af273843d5d6e1b8 and fixed for the stable branch. Cherry picked from commit 58f190b2b8c507c6151fd86e6fef896f842b3e87.
* Version 1.16.31.1.16.31Richard W.M. Jones2012-09-1921-1155/+1478
|
* extra-tests: Clean up some comments about the upstream qemu tests.Richard W.M. Jones2012-09-191-3/+4
| | | | (cherry picked from commit 157b5006dbf2db2927e48ce592a83a279513d183)
* extra-tests: Add scripts used by these tests to EXTRA_DIST.Richard W.M. Jones2012-09-191-1/+4
| | | | (cherry picked from commit 7e4b197cb6a5071c13e407546a21f9b93fe3798d)
* maint: remove a subsumed syntax-check ruleJim Meyering2012-09-191-11/+1
| | | | | | | * cfg.mk (sc_prohibit_trailing_blank_lines): Remove rule. It is now subsumed by the much more efficient sc_prohibit_empty_lines_at_EOF rule in gnulib's maint.mk. (cherry picked from commit 176bd182d3f94fe7e774b8af0b56c014f639d6c7)
* syntax: Exclude examples and test program from <config.h> requirementRichard W.M. Jones2012-09-191-0/+1
| | | | | (thanks Jim Meyering). (cherry picked from commit 3988dec9b7bbf3cb8628aff879d1f518a9d52404)
* syntax: Allow strncpy in launch-*.c files (thanks Jim Meyering).Richard W.M. Jones2012-09-191-0/+1
| | | | | | We use strncpy, justifiably, to copy the socket name into the fixed length Unix domain sun_path buffer. (cherry picked from commit 72ab351acef2f2bc6b0e4f36d69e94f8fa064f3c)
* syntax: Exclude examples from strcmp and strncmp checks (thanks Jim Meyering).Richard W.M. Jones2012-09-191-0/+2
| | | | (cherry picked from commit 369709177e47773eaa37f1fdbe8d9967b21d1133)
* syntax: Ignore documentation when testing for magic number exit() calls ↵Richard W.M. Jones2012-09-191-0/+1
| | | | | | (thanks Jim Meyering). (cherry picked from commit 552576c7f9ccb1862bcfc9fbd5c301d775aaf90c)
* syntax: Exclude PO files from doubled words test (thanks Jim Meyering).Richard W.M. Jones2012-09-191-0/+1
| | | | (cherry picked from commit 2100ba14fbfaf3e89059d9112959463506932d74)
* syntax: Remove definitions of O_CLOEXEC, except in examples (thanks Jim ↵Richard W.M. Jones2012-09-192-5/+1
| | | | | | | | Meyering). The gnulib <fcntl.h> replacement header will now define this symbol if it's not defined already. (cherry picked from commit cb13ffe190ac41a9b77fe27521838f495c1a5077)
* syntax: Exclude period in error message checks from PHP programs (thanks: ↵Richard W.M. Jones2012-09-191-0/+1
| | | | | | Jim Meyering). (cherry picked from commit 2337b9ccd729e05b46cf6abb1f4173e6e994c1cb)
* syntax: Disable cast arg to free test (thanks Jim Meyering).Richard W.M. Jones2012-09-191-1/+2
| | | | (cherry picked from commit fbdcfe2b77b6c272876143779912d41b0849111f)
* syntax: Exclude certain files from bindtextdomain test (thanks Jim Meyering).Richard W.M. Jones2012-09-191-0/+3
| | | | (cherry picked from commit b95fff13577cdd3da4300bbd639441cc77cf935a)
* Update to latest gnulib.Richard W.M. Jones2012-09-192-0/+1
| | | | (cherry picked from commit e942c02a2eeb4d55606dec5fe943ea7d81f989ba)
* build: Ignore -Wjump-misses-init warning.Richard W.M. Jones2012-09-191-0/+1
| | | | | | | | | This libguestfs 1.18 and 1.16-specific patch is necessary because something (gcc? gnulib?) has enabled a strict -Wjump-misses-init warning, which breaks libguestfs builds. In the development branch we fixed everything (commit e128a627fb8f39f4f4c11b782cef895bd79f0282, commit 74283d58cfb62e6cc73bfe0f62ca142ddc1e8fb2), but that patch is too invasive to backport.
* extra-tests: Write a qemu wrapper script on the fly.Richard W.M. Jones2012-09-193-26/+14
| | | | | | | | | | | | Passing the $upstream_qemu environment variable is not reliable when libvirt is involved: Environment variables are passed to the first instance of the session libvirtd, but because libvirt reuses the session libvirtd, subsequent environment variable settings are lost (this is filed as RHBZ#856619). Bypass all of this by writing a custom qemu-wrapper.sh which contains the hard-coded values we want. (cherry picked from commit e6bd0b87eb753fa96b6533b0dbe498697701ad3a)
* extra-tests: The upstream qemu test now reruns all the extra tests.Richard W.M. Jones2012-09-193-10/+12
| | | | (cherry picked from commit 509dd90c43afed75b861b7d82ebe8739d3500d54)
* extra-tests: Fix libvirt URI so we can run tests with libvirt attach-method.Richard W.M. Jones2012-09-191-12/+8
| | | | (cherry picked from commit eeb0c598ec8caa50998336713ed4e62902e0a74d)
* syntax: Remove trailing whitespace.Richard W.M. Jones2012-09-197-9/+5
| | | | | Found by 'make syntax-check'. (cherry picked from commit 2cac8d490e9884a8c7376e49fd1cda2e3d3abec1)
* generator: Remove inaccurate comment.Richard W.M. Jones2012-09-191-20/+0
| | | | | | The correct way to extend functions is documented in generator/README. This comment was no longer accurate. (cherry picked from commit 44a11e955b31f7c0cf463a04d640263cccdd0c4d)
* syntax: Replace test == with = or -eq as appropriate.Richard W.M. Jones2012-09-192-12/+12
| | | | | Found by 'make syntax-check'. (cherry picked from commit 6361810b53be4d5e0513b4f7c11d29cf1d6d3b45)
* syntax: Use STREQ/STRNEQ in place of strcmp.Richard W.M. Jones2012-09-193-3/+5
| | | | | Found by 'make syntax-check'. (cherry picked from commit b0cefb417d01c6dcb87cc6bafe9c19b98c690c9d)
* perl: Add <stdio.h> and <stdlib.h> for printf and malloc.Richard W.M. Jones2012-09-191-0/+2
| | | | (cherry picked from commit cd8976a5b52425f9d7c45249e1a593a341d91c52)
* perl: Include <inttypes.h> and assume it always defines PRId64 and PRIu64.Richard W.M. Jones2012-09-191-8/+2
| | | | | | | If these are not defined in the header files, it's a problem on the platform which we should fix with gnulib. Our replacement definitions might be wrong here. (cherry picked from commit 188b44ee458a666bee8a18ed47cccdec25859aff)
* lib: These optargs structures are not modified, hence const.Richard W.M. Jones2012-09-191-3/+3
| | | | (cherry picked from commit 5a46eadd3dcab1b8944eabc0f21097048e0ebe13)
* syntax: Remove test for TAB indentation.Richard W.M. Jones2012-09-191-8/+0
| | | | | | Nothing particularly wrong with using TABs for indentation, and this test also has a lot of false positives. (cherry picked from commit ae137124ca143e57f16d103f24cb3f21a3157b09)
* docs: Fix documentation of syntax-check target, add extra-tests.Richard W.M. Jones2012-09-191-2/+7
| | | | (cherry picked from commit 6951becfdb0b69b4defff4393f48314e884ad7c1)
* test-tool: Print more environment variables.Richard W.M. Jones2012-09-191-7/+18
| | | | | | This prints LIBVIRT_*, LIBVIRTD_*, LD_* and PATH, since these are all useful for debugging and could affect libguestfs in some way. (cherry picked from commit 281b155800f2e62b994e59bef418ca200da8e93a)
* fish: Replace '_' with '-' in deprecation cross-refs (thanks Olaf Hering).Richard W.M. Jones2012-09-192-3/+5
| | | | (cherry picked from commit 8acdc23622ea95a233ac831d67c143517aa94bba)
* extra-tests: Don't use $QEMU as a variable.Richard W.M. Jones2012-09-192-6/+13
| | | | | | | Since 'QEMU' is set (overwritten) by the autoconf-generated Makefile, this test would always test installed qemu, not upstream qemu, making it pretty useless. Use another name for this variable. (cherry picked from commit 81c682f1295a934d18bd4dc9e42b8e843df0c207)
* fix fuse_opt_add_opt_escaped return typeOlaf Hering2012-09-191-1/+1
| | | | | | | | | | | I: Program returns random data in a function E: libguestfs no-return-in-nonvoid-function guestmount.c:75 The function fuse_opt_add_opt_escaped has only one caller and a return code is not checked. Signed-off-by: Olaf Hering <olaf@aepfle.de> (cherry picked from commit bdb5689f58c0db18de28d6a703b3af4f22eded38)
* rescue: If -v / debugging enabled, don't mask error messages.Richard W.M. Jones2012-09-191-1/+2
| | | | | | | | | We set the error handler to NULL in order to mask "normal" error messages that we expect to see because of the unusual way that virt-rescue runs the appliance. However if the user selected -v / enabled debugging, then it is reasonable to expect they want to see every message, so do not mask anything. (cherry picked from commit 6fdf1f40fa85d2e6e7a1118f4cfa532ea9831b89)
generated by cgit (git 2.34.1) at 2025-09-26 13:30:56 +0000