summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Version 1.16.11.1.16.11Richard W.M. Jones2012-03-1620-627/+1209
|
* generator: Sort camel-case structs.Richard W.M. Jones2012-03-162-6/+7
| | | | (cherry picked from commit 14938b46a74467d0e4b1cd076ffd7fcbf06c26eb)
* generator: Fix CompareWithString test.Richard W.M. Jones2012-03-161-1/+1
| | | | | | This type of test was not used, and in fact the generated test simply didn't work. (cherry picked from commit 6bee63beb45678ff937593af59748dfceacdc608)
* generator: Fix FUInt{32,64} struct field types.Richard W.M. Jones2012-03-161-2/+4
| | | | | | | We were not using an unsigned type in the XDR. This doesn't affect data integrity or the protocol, but it makes it more complicated for the daemon to set these fields. (cherry picked from commit c8630300b8ab46c668da1c8d5c1cdb9d1e3a4552)
* daemon: Don't call reply_with_* after split_lines fails.Richard W.M. Jones2012-03-162-6/+2
| | | | | | split_lines already sets reply_with_*, so calling it again would lose protocol synchronization. (cherry picked from commit 710ec49bac8bce10bfc0b9ba4b34d877c22f7287)
* inspect: Fedora/RHEL CDs are multipart if totaldiscs > 1, not > 0.Richard W.M. Jones2012-03-161-1/+1
| | | | (cherry picked from commit 974dffc6769b732befe85bcd8f614b9600927631)
* inspect: Add comment documenting findings of RHEL 5, 6 install CDs.Richard W.M. Jones2012-03-161-0/+58
| | | | (cherry picked from commit 5749de39c2b44644662fb176784731bce851b828)
* sparsify: Add a note about encrypted disks to the man page.Richard W.M. Jones2012-03-161-1/+2
| | | | (cherry picked from commit 1c1ecb2c419382f1677501b22cb98a06c7abe9a9)
* sparsify: Unlink temporary overlay file if user presses ^C.Richard W.M. Jones2012-03-161-1/+5
| | | | | | Add a signal handler so this potentially large temporary file is removed when the user hits ^C. (cherry picked from commit 7283a5a2765c0670e9dceec70e626a49a30d269c)
* sparsify: Use zero-device instead of dd if=/dev/zero to zero device.Richard W.M. Jones2012-03-161-5/+3
| | | | | | zero-device is more efficient in general, and avoids writing to blocks which are already zero. (cherry picked from commit 8c9f6a64be9840a955e481e932f13d005c0de0de)
* sparsify: Only print qemu-img command if verbose.Richard W.M. Jones2012-03-161-1/+1
| | | | (cherry picked from commit 7934ea2395d2a417fbc20efc22573113f7ae9d7a)
* inspect: Ignore missing HKLM\SYSTEM\MountedDevices (RHBZ#803664).Richard W.M. Jones2012-03-161-4/+6
| | | | | | | When a Windows guest doesn't have a HKLM\SYSTEM\MountedDevices node, inspection fails. However inspection should not completely fail just because we cannot get the drive letter mapping from a guest. (cherry picked from commit 91cede3465cd2496a01a89d5c8815df7c326c2ec)
* inspector: Update man page to describe how to access inspection info from ↵Richard W.M. Jones2012-03-161-6/+112
| | | | | | other languages and guestfish. (cherry picked from commit 2bc922dd8e12bcf05e0aeef8a8b60b6aab9ee915)
* Add guestfsd.suppressions file to EXTRA_DIST.Richard W.M. Jones2012-03-141-2/+3
| | | | (cherry picked from commit c23f3b8e527bde9a83dd7ae24273db6da87a7268)
* java: Make sure generator is rerun when necessary to rebuild generated files.Richard W.M. Jones2012-03-141-9/+7
| | | | (cherry picked from commit 13e7a1b400b7e2a5e9335d25205b09e74c89d858)
* appliance: Enhance --enable-valgrind-daemon with a suppressions file.Richard W.M. Jones2012-03-143-3/+26
| | | | | This lets us suppress errors in system libraries. (cherry picked from commit 302309921a8cde83eb19a7c25b7ee43932b91a05)
* daemon: When copy subprocess fails, print return code.Richard W.M. Jones2012-03-141-1/+1
| | | | | Useful for debugging. (cherry picked from commit 5da61d30520315a7d5060137a6c109f2109a7631)
* Version 1.16.10.1.16.10Richard W.M. Jones2012-03-1320-6492/+6540
|
* Fix strict-overflow bugs and reenable this warning.Richard W.M. Jones2012-03-132-4/+4
| | | | | | | | | In two places, we were counting things in an array using an 'int'. In theory, the int could overflow, so gcc determines this to be undefined behaviour. The fix is to use size_t or ssize_t instead. (cherry picked from commit d66dd2260c724bdfe57a8595aac37c8e9173cee5)
* fish: Rename tests and make test paths relative.Richard W.M. Jones2012-03-1315-49/+49
| | | | | | | | | | | When these tests were originally in the old regressions/ directory, they used to refer to guestfish via the path '../fish/guestfish'. Some of the tests were also called 'test-guestfish-*'. Now that the tests have been moved into the fish/ directory, neither of these things make sense. So change the relative path to './guestfish' and rename all 'test-guestfish-*' as 'test-*'. (cherry picked from commit 1f603bfd6d7cd17e88f737a496b7e5ee053750c2)
* tests: Remove/fix unused variables warnings.Richard W.M. Jones2012-03-132-1/+1
| | | | (cherry picked from commit 2c8ead5aa0e6b821bf2d21a89e437e9a6c0ed1ca)
* tests: Remove unused variable.Richard W.M. Jones2012-03-131-1/+0
| | | | (cherry picked from commit 099e3dd9f129e05bff5512855ea89530a7999004)
* erlang: Remove unused variables.Richard W.M. Jones2012-03-131-2/+0
| | | | (cherry picked from commit 6292e630da080eb5d3427af6190eb68fe4eb1415)
* format: Remove unused variables.Richard W.M. Jones2012-03-131-1/+1
| | | | (cherry picked from commit e9e0920c00c55894358559bcdbd89d55cbb66d2a)
* daemon: Remove unused variables.Richard W.M. Jones2012-03-132-8/+0
| | | | (cherry picked from commit 13c2db39abff3c0050eade5bcce997afdf04d721)
* inspect: Move variable decl to top of function.Richard W.M. Jones2012-03-131-1/+3
| | | | (cherry picked from commit 46d1280100b025de2a448331306e794d688748bd)
* lib: Remove some unused variables.Richard W.M. Jones2012-03-134-7/+1
| | | | (cherry picked from commit cd3f2986eee8dbadc8253d4c3462f7e214f1236d)
* lib: Use size_t for allocation size in safe realloc function.Richard W.M. Jones2012-03-132-2/+2
| | | | (cherry picked from commit b8cdf6c2b9d12df6acbe295fd75c8c59c8b7eec1)
* bindtests: Use size_t instead of int for array iterators.Richard W.M. Jones2012-03-131-7/+7
| | | | (cherry picked from commit 24413ac4d8c8d64b3339f9e61886db8f7fbfed4f)
* e2fsck: Comment, whitespace, error message cleanups.Richard W.M. Jones2012-03-131-2/+2
| | | | (cherry picked from commit 4c9218658e4d4b769acaa41d999b4bce437fbc37)
* Close all file descriptors and remove all signal handlers in the recovery ↵Richard W.M. Jones2012-03-131-0/+25
| | | | | | | | | | | | | | | | | | process. If the parent process uses a pipe (or any fd, but pipes are a particular problem), then the recovery process would hold open the file descriptor(s) of the pipe, meaning that it could not be fully closed in the parent. Because the recovery process doesn't use exec(2), this wasn't avoidable even using FD_CLOEXEC. Avoid this by closing all file descriptors when starting the recovery process. After discussion with Dan Berrange, he points out that it's also a good idea to set signal handlers to the default after forking, so that any signal handlers set up in the parent don't affect the child. (cherry picked from commit f1f045adf8d00549dd3efa3619e1162f9004b61e)
* extra-tests: Export LIBVIRT_DEFAULT_URI to pick-guests.pl.Richard W.M. Jones2012-03-131-1/+6
| | | | | This fixes commit 2912e4e1173226f461517a0008664e01b5d3066d. (cherry picked from commit 99702fe443383707b9d9c1b84570baf3bebf9253)
* extra-tests: Check that guests are accessible before picking them.Richard W.M. Jones2012-03-132-11/+65
| | | | (cherry picked from commit 2912e4e1173226f461517a0008664e01b5d3066d)
* Version 1.16.9.1.16.9Richard W.M. Jones2012-03-081-1/+1
|
* fish: Document that guestfish sets pgroup to true (RHBZ#801273).Richard W.M. Jones2012-03-081-1/+3
| | | | (cherry picked from commit 0721464b83915fbfae6d6a9da787f5069b2c6d6a)
* inspect_apps: Avoid double-close on error path (found by Coverity) ↵Richard W.M. Jones2012-03-081-0/+1
| | | | | | | | | (RHBZ#801298). Error: USE_AFTER_FREE: /builddir/build/BUILD/libguestfs-1.16.5/src/inspect_apps.c:392: freed_arg: "fclose" frees "fp". /builddir/build/BUILD/libguestfs-1.16.5/src/inspect_apps.c:404: deref_arg: Calling "fclose" dereferences freed pointer "fp". (cherry picked from commit 270daae52b6a96b4d05cbe03e0b31a0b2e4ac1ae)
* dbdump: Avoid double-close on error path (found by Coverity).Richard W.M. Jones2012-03-081-0/+1
| | | | | | | Error: USE_AFTER_FREE: /builddir/build/BUILD/libguestfs-1.16.5/src/dbdump.c:132: freed_arg: "pclose" frees "pp". /builddir/build/BUILD/libguestfs-1.16.5/src/dbdump.c:142: deref_arg: Calling "pclose" dereferences freed pointer "pp". (cherry picked from commit 3f3b08a6bc610ca0886e02972257dfcb633a9d40)
* daemon: glob: Initialize glob buffer (quiet Coverity warning).Richard W.M. Jones2012-03-081-1/+1
| | | | | | | | | | Error: UNINIT: /builddir/build/BUILD/libguestfs-1.16.5/daemon/glob.c:32: var_decl: Declaring variable "buf" without initializer. /builddir/build/BUILD/libguestfs-1.16.5/daemon/glob.c:36: uninit_use_in_call: Using uninitialized value "buf.gl_offs" when calling "rpl_glob". /builddir/build/BUILD/libguestfs-1.16.5/gnulib/lib/glob.c:557: read_parm_fld: Reading a parameter field. /builddir/build/BUILD/libguestfs-1.16.5/daemon/glob.c:36: uninit_use_in_call: Using uninitialized value "buf.gl_pathc" when calling "rpl_glob". /builddir/build/BUILD/libguestfs-1.16.5/gnulib/lib/glob.c:557: read_parm_fld: Reading a parameter field. (cherry picked from commit b2c1d8be39d4689267ef7e4188e2cf936b30628f)
* comment: Note time-of-check to time-of-use race found by Coverity.Richard W.M. Jones2012-03-081-0/+6
| | | | (cherry picked from commit 3345444cccfe2e2fb07d4769d1e764eca59dd6f9)
* daemon: inotify: Check event->len in inotify struct is reasonable.Richard W.M. Jones2012-03-081-0/+7
| | | | | | | | | | | | | | | The Coverity error is this (which I think is wrong): Error: TAINTED_SCALAR: /builddir/build/BUILD/libguestfs-1.16.5/daemon/inotify.c:211: tainted_data_argument: Calling function "read" taints argument "inotify_buf". /builddir/build/BUILD/libguestfs-1.16.5/daemon/inotify.c:232: var_assign_var: Assigning: "event" = "(struct inotify_event *)&inotify_buf[n]". Both are now tainted. /builddir/build/BUILD/libguestfs-1.16.5/daemon/inotify.c:258: lower_bounds: Checking lower bounds of unsigned scalar "event->len" by "event->len > 0U". /builddir/build/BUILD/libguestfs-1.16.5/daemon/inotify.c:272: var_assign_var: Compound assignment involving tainted variable "16UL + event->len" to variable "n" taints "n". /builddir/build/BUILD/libguestfs-1.16.5/daemon/inotify.c:228: lower_bounds: Checking lower bounds of unsigned scalar "n" by "n < inotify_posn". /builddir/build/BUILD/libguestfs-1.16.5/daemon/inotify.c:281: tainted_data: Using tainted variable "n" as an index into an array "inotify_buf". Adding a sanity check of event->len is prudent. (cherry picked from commit ae0f9f149b2b527b924d4532aa38302056d8a6b0)
* daemon: debug: Close fd along error path (found by Coverity).Richard W.M. Jones2012-03-081-0/+1
| | | | | | | | | Error: RESOURCE_LEAK: /builddir/build/BUILD/libguestfs-1.16.5/daemon/debug.c:469: open_fn: Calling opening function "open". /builddir/build/BUILD/libguestfs-1.16.5/daemon/debug.c:469: var_assign: Assigning: "fd" = handle returned from "open("/proc/sys/kernel/core_pattern", 1)". /builddir/build/BUILD/libguestfs-1.16.5/daemon/debug.c:474: noescape: Variable "fd" is not closed or saved in function "write". /builddir/build/BUILD/libguestfs-1.16.5/daemon/debug.c:476: leaked_handle: Handle variable "fd" going out of scope leaks the handle. (cherry picked from commit 3b3d9ca4e1fa0a4f566cb2a8008540ee640b738b)
* fish: Properly free up strings, lists along all error paths (found by Coverity).Richard W.M. Jones2012-03-081-84/+106
| | | | | | | | | | | | | | | | | | | | | This also includes some tidying up of the generated code. Error: RESOURCE_LEAK: /builddir/build/BUILD/libguestfs-1.16.5/fish/cmds.c:13254: alloc_fn: Calling allocation function "parse_string_list". /builddir/build/BUILD/libguestfs-1.16.5/fish/fish.c:1386: alloc_fn: Storage is returned from allocation function "realloc". /builddir/build/BUILD/libguestfs-1.16.5/fish/fish.c:1386: var_assign: Assigning: "argv_new" = "realloc(argv, 8UL * argv_len)". /builddir/build/BUILD/libguestfs-1.16.5/fish/fish.c:1392: var_assign: Assigning: "argv" = "argv_new". /builddir/build/BUILD/libguestfs-1.16.5/fish/fish.c:1396: return_alloc: Returning allocated memory "argv". /builddir/build/BUILD/libguestfs-1.16.5/fish/cmds.c:13254: var_assign: Assigning: "devices" = storage returned from "parse_string_list(argv[i++])". /builddir/build/BUILD/libguestfs-1.16.5/fish/cmds.c:13271: leaked_storage: Variable "devices" going out of scope leaks the storage it points to. /builddir/build/BUILD/libguestfs-1.16.5/fish/cmds.c:13288: leaked_storage: Variable "devices" going out of scope leaks the storage it points to. /builddir/build/BUILD/libguestfs-1.16.5/fish/cmds.c:13293: leaked_storage: Variable "devices" going out of scope leaks the storage it points to. /builddir/build/BUILD/libguestfs-1.16.5/fish/cmds.c:13311: leaked_storage: Variable "devices" going out of scope leaks the storage it points to. /builddir/build/BUILD/libguestfs-1.16.5/fish/cmds.c:13316: leaked_storage: Variable "devices" going out of scope leaks the storage it points to. /builddir/build/BUILD/libguestfs-1.16.5/fish/cmds.c:13334: leaked_storage: Variable "devices" going out of scope leaks the storage it points to. /builddir/build/BUILD/libguestfs-1.16.5/fish/cmds.c:13349: leaked_storage: Variable "devices" going out of scope leaks the storage it points to. /builddir/build/BUILD/libguestfs-1.16.5/fish/cmds.c:13355: leaked_storage: Variable "devices" going out of scope leaks the storage it points to. (cherry picked from commit 4dd26c28a3786f756c20f204488bfbcfc5e75309)
* daemon: proto: Close fd along error paths (found by Coverity).Richard W.M. Jones2012-03-081-0/+3
| | | | | | | | | | Error: RESOURCE_LEAK: /builddir/build/BUILD/libguestfs-1.16.5/src/proto.c:894: open_fn: Calling opening function "open". /builddir/build/BUILD/libguestfs-1.16.5/src/proto.c:894: var_assign: Assigning: "fd" = handle returned from "open(filename, 0)". /builddir/build/BUILD/libguestfs-1.16.5/src/proto.c:903: noescape: Variable "fd" is not closed or saved in function "read". /builddir/build/BUILD/libguestfs-1.16.5/src/proto.c:911: leaked_handle: Handle variable "fd" going out of scope leaks the handle. /builddir/build/BUILD/libguestfs-1.16.5/src/proto.c:918: leaked_handle: Handle variable "fd" going out of scope leaks the handle. (cherry picked from commit d0453c02545c825810fec6e5874c55d7ac5ec678)
* daemon: upload: Close fd along error path (found by Coverity).Richard W.M. Jones2012-03-081-0/+1
| | | | | | | | | Error: RESOURCE_LEAK: /builddir/build/BUILD/libguestfs-1.16.5/daemon/upload.c:225: open_fn: Calling opening function "open". /builddir/build/BUILD/libguestfs-1.16.5/daemon/upload.c:225: var_assign: Assigning: "fd" = handle returned from "open(filename, 0)". /builddir/build/BUILD/libguestfs-1.16.5/daemon/upload.c:233: noescape: Variable "fd" is not closed or saved in function "lseek". /builddir/build/BUILD/libguestfs-1.16.5/daemon/upload.c:235: leaked_handle: Handle variable "fd" going out of scope leaks the handle. (cherry picked from commit fbf10d7f682178a6a71cfa8dbac2acd23f869597)
* daemon: 9p: Close fd along error paths (found by Coverity).Richard W.M. Jones2012-03-081-0/+2
| | | | | | | | | | Error: RESOURCE_LEAK: /builddir/build/BUILD/libguestfs-1.16.5/daemon/9p.c:130: open_fn: Calling opening function "open". /builddir/build/BUILD/libguestfs-1.16.5/daemon/9p.c:130: var_assign: Assigning: "fd" = handle returned from "open(filename, 0)". /builddir/build/BUILD/libguestfs-1.16.5/daemon/9p.c:142: leaked_handle: Handle variable "fd" going out of scope leaks the handle. /builddir/build/BUILD/libguestfs-1.16.5/daemon/9p.c:149: noescape: Variable "fd" is not closed or saved in function "read". /builddir/build/BUILD/libguestfs-1.16.5/daemon/9p.c:153: leaked_handle: Handle variable "fd" going out of scope leaks the handle. (cherry picked from commit cba36e730524525b5fc1c0df2ec3dd878d55ff15)
* proto: Close file along error and cancel paths (found by Coverity).Richard W.M. Jones2012-03-081-1/+5
| | | | | | | | | | Error: RESOURCE_LEAK: /builddir/build/BUILD/libguestfs-1.16.5/src/proto.c:1125: open_fn: Calling opening function "open". /builddir/build/BUILD/libguestfs-1.16.5/src/proto.c:1125: var_assign: Assigning: "fd" = handle returned from "open(filename, 833, 438)". /builddir/build/BUILD/libguestfs-1.16.5/src/proto.c:1133: noescape: Variable "fd" is not closed or saved in function "xwrite". /builddir/build/BUILD/libguestfs-1.16.5/src/proto.c:1146: leaked_handle: Handle variable "fd" going out of scope leaks the handle. /builddir/build/BUILD/libguestfs-1.16.5/src/proto.c:1173: leaked_handle: Handle variable "fd" going out of scope leaks the handle. (cherry picked from commit 855aaf414af3b8c8ca1f722a589fd251cc8317ee)
* Check return values of guestfs_inspect_get_{type,distro} (found by Coverity).Richard W.M. Jones2012-03-081-0/+4
| | | | | | | | | | Error: NULL_RETURNS: /builddir/build/BUILD/libguestfs-1.16.5/examples/virt-dhcp-address.c:129: var_assigned: Assigning: "guest_distro" = null return value from "guestfs_inspect_get_distro". /builddir/build/BUILD/libguestfs-1.16.5/examples/virt-dhcp-address.c:131: dereference: Dereferencing a pointer that might be null "guest_distro" when calling "__coverity_strcmp". [...] /builddir/build/BUILD/libguestfs-1.16.5/examples/virt-dhcp-address.c:126: var_assigned: Assigning: "guest_type" = null return value from "guestfs_inspect_get_type". /builddir/build/BUILD/libguestfs-1.16.5/examples/virt-dhcp-address.c:128: dereference: Dereferencing a pointer that might be null "guest_type" when calling "__coverity_strcmp". (cherry picked from commit 618954a6b0adc3e0eacda799b88f020c801a0106)
* Check return values from calloc (found by Coverity).Richard W.M. Jones2012-03-081-25/+29
| | | | | | | | | | | | Error: NULL_RETURNS: /builddir/build/BUILD/libguestfs-1.16.5/src/inspect.c:417: returned_null: Function "calloc" returns null (checked 67 out of 81 times). /builddir/build/BUILD/libguestfs-1.16.5/src/inspect.c:417: var_assigned: Assigning: "ret" = null return value from "calloc". /builddir/build/BUILD/libguestfs-1.16.5/src/inspect.c:418: dereference: Dereferencing a null pointer "ret". [...] /builddir/build/BUILD/libguestfs-1.16.5/src/inspect.c:374: returned_null: Function "calloc" returns null (checked 67 out of 81 times). /builddir/build/BUILD/libguestfs-1.16.5/src/inspect.c:374: var_assigned: Assigning: "ret" = null return value from "calloc". /builddir/build/BUILD/libguestfs-1.16.5/src/inspect.c:375: dereference: Dereferencing a null pointer "ret". (cherry picked from commit 35d5be22b1c09c3a99b445f65453601ec25b9f60)
* Dead code: Remove comma-check in first if-clause (found by Coverity).Richard W.M. Jones2012-03-081-3/+4
| | | | | | | | | Error: DEADCODE: /builddir/build/BUILD/libguestfs-1.16.5/fish/event-names.c:65: dead_error_condition: On this path, the condition "comma" cannot be true. /builddir/build/BUILD/libguestfs-1.16.5/fish/event-names.c:57: const: After this line, the value of "comma" is equal to 0. /builddir/build/BUILD/libguestfs-1.16.5/fish/event-names.c:57: assignment: Assigning: "comma" = "0". /builddir/build/BUILD/libguestfs-1.16.5/fish/event-names.c:65: dead_error_line: Execution cannot reach this statement "fputc(44, fp);". (cherry picked from commit 0ffa223a75fe4b5b077e4ec68534155039772c3a)
* Dead code: 'lvs' cannot be true here (found by Coverity).Richard W.M. Jones2012-03-081-1/+1
| | | | | | | | | | | | | | Remove dead code; however only comment it out since if we change the preceeding code we may need this line again. Error: DEADCODE: /builddir/build/BUILD/libguestfs-1.16.5/src/listfs.c:107: dead_error_condition: On this path, the condition "lvs" cannot be true. /builddir/build/BUILD/libguestfs-1.16.5/src/listfs.c:54: const: After this line, the value of "lvs" is equal to 0. /builddir/build/BUILD/libguestfs-1.16.5/src/listfs.c:91: const: After this line, the value of "lvs" is equal to 0. /builddir/build/BUILD/libguestfs-1.16.5/src/listfs.c:54: assignment: Assigning: "lvs" = "NULL". /builddir/build/BUILD/libguestfs-1.16.5/src/listfs.c:91: new_values: Noticing condition "lvs == NULL". /builddir/build/BUILD/libguestfs-1.16.5/src/listfs.c:107: dead_error_line: Execution cannot reach this statement "guestfs___free_string_list(...". (cherry picked from commit 109d3ad34aac8d50a1c02437928a64d9bad9f1a6)
generated by cgit (git 2.34.1) at 2025-08-30 05:42:27 +0000