| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Hi Rich,
I realized a day or two late that my suggestion was not quite right.
Here's the fix:
>From 5294c21cf07c4ec2f094182ba9f32696f3de2751 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Mon, 23 Jan 2012 10:01:40 +0100
Subject: [PATCH libguestfs] build: don't use automake-internal variable
* ocaml/Makefile.am (mlguestfs.cma): Use the documented variable form,
$(libguestfsocaml_a_OBJECTS), not the $(am_libguestfsocaml_a_OBJECTS)
that I suggested for commit 1.15.16-17-g8b9eaec.
(cherry picked from commit 70070cf24420bee01770da2897d2ca32e3183181)
|
|
|
|
|
|
|
| |
function_entry was left over from PHP 3.
See: http://news.php.net/php.pecl.dev/7123
(cherry picked from commit 5cfd3e7b3e1a7a4031f676d5b65392c7de113164)
|
|
|
|
| |
(cherry picked from commit 4f868b84d6e7c387e27f50aae54476bc97a70bc2)
|
|
|
|
|
| |
This is just code motion.
(cherry picked from commit de5d416fc7b3213641b035288c1df199346e9020)
|
|
|
|
| |
(cherry picked from commit b8720abfe56391bf5b7b624e003ab7df90f5ceb4)
|
|
|
|
| |
(cherry picked from commit 251c6e994de97d9e87a0ace01144c12366e12c2b)
|
|
|
|
|
|
|
| |
We were passing the name of the last argument directly to va_start. However, if
the last argument is a BufferIn it expands to 2 arguments, the latter of which
is <name>_size.
(cherry picked from commit 3d80161d9c277c800a3214694ba56a8909e655df)
|
|
|
|
| |
(cherry picked from commit a20b88be8364fc485d654377819e6daab303ef7a)
|
|
|
|
| |
(cherry picked from commit 7412bb342141bdfe0d44d6526728f4e1fd284fe0)
|
|
|
|
|
|
|
|
| |
When you call close on any block device, udev kicks off a rule which
runs blkid to reexamine the device. We need to wait for this rule to
finish running since it holds the device open and can cause other
operations to fail, notably BLKRRPART.
(cherry picked from commit a9c8123c72db47bcab8dd738e8d5256a9ae87f11)
|
|
|
|
|
| |
This allows us to use 'fuser' and other ps tools.
(cherry picked from commit ea3f16f6d9dd1aedc03c4438d1f01565d634ffda)
|
|
|
|
|
|
| |
In Linux, close (fd) closes the file descriptor even if it returns an
error.
(cherry picked from commit 61abcf71c05c07bfaca96666b16a0bc30a6edab4)
|
|
|
|
| |
(cherry picked from commit d8a1389df35ddd5b6d9af86dc27c1978ea07348f)
|
|
|
|
|
|
| |
By arranging the C part of the bindings into a library, we can get
automake to build it instead of using $(CC) directly.
(cherry picked from commit 8b9eaec993e3199ff4ef1056abe2f18cbed1289b)
|
|
|
|
|
|
|
| |
However since the OCaml bindings use guestfs_safe_strdup and
guestfs_safe_memdup we need to export those two (in the private
functions section) from <guestfs.h>.
(cherry picked from commit 607784df926aeb9293dbeb346f45d93907c7ffa2)
|
|
|
|
| |
(cherry picked from commit db90770ec5e867cc120a9753bf928f081002c2e7)
|
|
|
|
|
|
|
| |
Previously, passing NULL optargs to an _argv call resulted in a segfault. This
change causes NULL optargs to be interpreted as no optargs, and to be correctly
handled accordingly.
(cherry picked from commit fd1a6d8003b29eaec5230f838f673df7cd0e9c86)
|
|
|
|
| |
(cherry picked from commit c7119da1306e1e04a1a35c5c2caf407e4b46d173)
|
|
|
|
| |
(cherry picked from commit b1ea8a7808744068fe0d1306d1005e841a570b4c)
|
|
|
|
|
|
|
|
| |
Tweak the error message "e2fsck -f" and "e2fsck -fy".
Indicate the user to use the correct and/or forceall options.
Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
(cherry picked from commit 0eaf06e673833bc25673d5c3d2487fffae310285)
|
|
|
|
|
|
| |
Remove generated .depend files from source control, and don't barf when they
don't exist while bootstrapping.
(cherry picked from commit f6db1ec41050e70580674ebbeb8fac5335df3284)
|
|
|
|
|
|
|
|
|
|
| |
If you have a lot of guests, running extra tests takes a lot of time,
but (arguably) you're not really doing any more detailed testing.
Thus pick up to 5 guests at random to test. A different random
selection is done on each run, ensuring that data-driven errors (eg in
inspection) will still be found eventually.
(cherry picked from commit 54a7982dc3a6d3cc903c8d6e73be30c46fdf90d4)
|
| |
|
|
|
|
| |
(cherry picked from commit 01e717b3c141c509a7200b0a6c560f75815c08f2)
|
|
|
|
|
|
|
| |
Move the filename's comma character checking to a wrapper.
Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
(cherry picked from commit e0c309379556ad50d43a08b4aa4ec0146d2b60d8)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, optional arguments had the same type as regular arguments, but were
constrained by various runtime tests to be only Bool, Int, Int64 or String. This
change makes the type of optional arguments stronger by giving them their own
type.
A convenience function, optargs_to_args is defined to convert optargs in the few
places where they are genuinely treated identically to mandatory arguments.
It also allows for future changes to optional arguments which do not affect
mandatory arguments.
RWMJ:
- removed redundant parens
- readded the check for > 64 optargs, but changed it to > 63
- changed the new function to args_of_optargs
(cherry picked from commit 0a7b734d2f54d4e98882532da9887feb66c9824a)
|
|
|
|
|
|
| |
This map was originally included just for the java bindings, but is generally
useful to any binding which uses camel case by requirement or convention.
(cherry picked from commit e24af214fe8f9dccac39ed520b57ce7d458f9fd1)
|
|
|
|
|
|
|
|
| |
Code cleanup.
Add a goto label to simplify the code.
Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
(cherry picked from commit 6f6485ec34f29401bbab65dd4275a3b564ed11b3)
|
|
|
|
| |
(cherry picked from commit 49b894599bf82790c83e2949626b7a8958732b6a)
|
|
|
|
| |
(cherry picked from commit c51caebea20b499ca0f9e652da0d964689969d79)
|
|
|
|
| |
(cherry picked from commit ebdda911b5dc4e2695413578ed2e0f0b387c0d89)
|
|
|
|
| |
(cherry picked from commit c655415dc051b84d6178399e5f7cb76ff7af06c0)
|
|
|
|
|
|
|
| |
Handle SIGQUIT by guestfish, so that it can't be terminated.
Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
(cherry picked from commit f49a30eba8bb9f352637c3c24138074bbe3f5555)
|
|
|
|
|
|
|
|
| |
Add the email address for authors.
It would be better.
Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
(cherry picked from commit 10df9d88ab4191c4092f4a88c7343ab3f5f31a70)
|
|
|
|
| |
(cherry picked from commit 49218ae6b451004c8f7b5549d5876c8568a7c1a6)
|
|
|
|
| |
(cherry picked from commit 871e1cfe3ae28028eaa4be7d87d7c43f68b4d5ec)
|
|
|
|
| |
(cherry picked from commit 6032da66819b7ccf99001ba636926100f475cb89)
|
|
|
|
|
|
|
|
| |
This function does 'rm -rf <dir>' for temporary directories, safely
working if '<dir>' contains shell meta-characters.
Replace existing code for removing directories with this.
(cherry picked from commit 690ff694ca6db586c06ec484ea158261c156aa2f)
|
|
|
|
|
|
|
|
|
|
|
|
| |
v1->v2: fix a typo pointed by Matt
Optimizations by reducing the STREQ operations and do some
code cleanup.
Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
RWMJ: Whitespace changes.
(cherry picked from commit 2ac869bcc86fbf0dd7e878f10a2b60769a58c962)
|
|
|
|
|
|
| |
The python3.1 package shipped with Debian/squeeze does not have the
'mu' suffix that was assumed before.
(cherry picked from commit ad5b5f96da53a6f51424e22e26f2d8a325eec681)
|
|
|
|
| |
(cherry picked from commit f5a49bf1cae335889da6be53fd1ca302273be78b)
|
|
|
|
| |
(cherry picked from commit a0a8de4253ad545d668977dbf54f90118f601192)
|
|
|
|
| |
(cherry picked from commit 3c9dfd1e95fae5c31df1fbcb6bdec2982a69a004)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(CVE-2011-4127, RHBZ#757071)
CVE-2011-4127 is a serious qemu & kernel privilege escalation bug
found by Paolo Bonzini.
http://seclists.org/oss-sec/2011/q4/536
An untrusted guest kernel is able to issue special SG_IO ioctls on
virtio devices which qemu passes through to the host kernel without
filtering or sanitizing. These ioctls allow raw sectors from the
underlying host device to be read and written. Significantly, neither
qemu nor the host kernel checks that the range of sectors is within
the partition / LV assigned to the guest. For example, if the guest
is assigned host partition /dev/sda3, it would be able to read or
write any part of /dev/sda including other partitions and the boot
sector. Exploits through LVs passed to the guest are also possible,
with some limitations. File-backed virtual block devices are not
vulnerable. Non-virtio block devices are not vulnerable.
This patch mitigates the problem by disabling the SG_IO ioctl
passthrough in qemu. Thus if libguestfs is examining an untrusted
guest and the libguestfs appliance/daemon is compromised (eg. by
executing guest commands, or through some other compromise), then the
compromised appliance will not be able to issue the above SG_IO ioctls
and exploit the host.
Note that this is just mitigation for libguestfs. Users will still
want to fully update their host kernel, qemu/KVM and libvirt, in order
to prevent other (non-libguestfs) routes to compromise.
The following versions of libguestfs (will/have) this patch applied.
libguestfs >= 1.15.13
libguestfs >= 1.14.8
libguestfs >= 1.12.11
libguestfs >= 1.10.12
libguestfs >= 1.8.16
Earlier versions may be vulnerable unless a downstream packager has
applied this patch.
Cc: Hilko Bengen <bengen@hilluzination.de>
(cherry picked from commit 9a5f784d511a8f00a8386f316eab41fe660430db)
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
fuse_main can return any non-zero value on error. In particular on
certain sorts of error such as unsupported -o options it returns 1
(not -1).
Therefore make sure any non-zero return is turned into EXIT_FAILURE.
(Thanks Pádraig Brady)
(cherry picked from commit ae45cee728039d7724fc73e5ffb2550c8054d268)
|
|
|
|
|
|
|
|
|
| |
In particular this stops a problem with guestmount where if the -i
option half-recognizes the guest OS, it would mount the disk (and
fail, giving only warnings), leaving the mountpoint unusable.
(Thanks Pádraig Brady)
(cherry picked from commit 54e91da925323642e67b8ce4b95899fe4b7a51c4)
|
|
|
|
|
|
|
|
|
|
|
| |
This also adds comprehensive tests for utimens on regular files,
directories (RHBZ#761451), named pipes (RHBZ#761460), symbolic links,
block and char devices.
Note that there is a small change in the (previously undefined)
semantics of this call: It now sets the time on a symbolic link
itself, not on what the symbolic link points to.
(cherry picked from commit 19e2f5aa4fd4ed70b505661d918b5575616ad441)
|