summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* python: Newer versions want parentheses around arguments of "print"Hilko Bengen2011-08-281-2/+2
| | | | (cherry picked from commit 54911bdd325393d1f7f2861f298463c364b45469)
* php: Fix bug in PHP tests.Richard W.M. Jones2011-08-281-2/+2
| | | | | | | | | | | We partitioned the disk, and then tried to create a PV on the whole disk. LVM gave the error: Device /dev/vda not found (or ignored by filtering). It is unclear how this bug persisted for so long. It might be due to a change in LVM. (cherry picked from commit 4fb3b23fb69e4274f434f9258e38f185426298f7)
* Coverity: fix memory leak along error path.Richard W.M. Jones2011-08-281-0/+12
| | | | (cherry picked from commit ce18be33cd5279a8d4120eedd037400c275585c0)
* Coverity: Initialize msg buffer.Richard W.M. Jones2011-08-281-0/+2
| | | | | | msg_flags was not being initialized and would have been passed to sendmsg with a random value. (cherry picked from commit a31ac8fc32297cc9185fd20a5578d2bc81cc1bce)
* Coverity: fix memory leak in guestfish.Richard W.M. Jones2011-08-281-2/+1
| | | | (cherry picked from commit c38cb92ec478c4dca83e4d38963720f463d52314)
* Coverity: in daemon, free struct in RStruct, RStructList functions.Richard W.M. Jones2011-08-281-0/+2
| | | | (cherry picked from commit b2edcbe1b9c9d161e96cb56d0efd944e84d84526)
* pclose: Fix other places where we only tested pclose == -1.Richard W.M. Jones2011-08-284-4/+4
| | | | | pclose can return > 0 when the status of the command was non-zero. (cherry picked from commit 631faad97171d7c1238b2e413c663cf61476f440)
* test_qemu: Improve the error message.Richard W.M. Jones2011-08-281-1/+2
| | | | | | Note that errno is probably not set to a useful value here, so there is not much point recording it. (cherry picked from commit f15961911316460f7d45342d63c2d784a483f0d1)
* test_qemu: pclose may return any != 0 on error.Richard W.M. Jones2011-08-281-1/+1
| | | | | In particular pclose returns a status > 0 if the command fails. (cherry picked from commit a24652c7b27e8494268ccb6c9a5a2e5541ba5efd)
* qemu detection: Free up previous qemu help/version strings if they exist.Richard W.M. Jones2011-08-281-0/+5
| | | | (cherry picked from commit 2ace9be4cd69e84cd88e5b0fd74de861a4973c91)
* Coverity: test_qemu: Ensure FILE * is not leaked along error paths.Richard W.M. Jones2011-08-281-15/+21
| | | | | | This refactors the code in test_qemu slightly to ensure that FILE *fp is not leaked on error paths. (cherry picked from commit 08e77ad8cb4e8ac70d4217ebd5d236eba81645b5)
* Coverity: Check guestfs_inspect_get_product_name() != NULL before using.Richard W.M. Jones2011-08-281-1/+1
| | | | (cherry picked from commit fa44536b0ff12102c72ae0337e51d272f0fc2353)
* rescue: Ignore errno after guestfs_launch.Richard W.M. Jones2011-08-281-10/+0
| | | | | | | | errno is pretty much random on the error path back from guestfs_launch so there is nothing useful to be gained by checking it. We could do with a better way to detect if appliance launch failed. (cherry picked from commit 00fef9eed6a53e10a975814beef775483ff0b3dd)
* Coverity: Ignore return value from guestfs_launch in virt-rescue.Richard W.M. Jones2011-08-281-1/+4
| | | | | We expect guestfs_launch to fail in this program. (cherry picked from commit 9bab154d48e367702b65852c3c822341b474ffd2)
* Coverity: Check return value from sscanf in bindtests calls.Richard W.M. Jones2011-08-281-5/+22
| | | | (cherry picked from commit 4c76aaa391d591c5917a06b0277fb9eb7d6d790f)
* autobuild: Only add last 100 lines of the log file.Richard W.M. Jones2011-08-281-4/+13
| | | | (cherry picked from commit ca727deac186981f4d9784696324c8f3af79f9e5)
* New autobuild script.Richard W.M. Jones2011-08-283-96/+104
| | | | | | | | Remove the old top-level autobuild.sh that confused a lot of people. Add an autobuild.sh script that builds from the latest tarball. (cherry picked from commit 6375aede61d57422ad82f4941693493c07b78aa2)
* configure: Add --with-extra flag to allow setting the extra version string.Richard W.M. Jones2011-08-281-9/+19
| | | | | | | Intended use in Fedora and RHEL is to encode the release string, eg. ./configure [...] --with-extra="-%{release}"
* protocol: Fix case where download can fail for small files.Richard W.M. Jones2011-08-282-6/+26
| | | | | | | | | | | | | | There is another case where downloads of small files could fail if the library side (writer) fails. In this case the library would send back a cancellation, but it would be received after the daemon had finished sending the whole file (because the file is small enough). The daemon would reenter the main loop and immediately get an unexpected cancel message, causing the daemon to die. This commit also makes test-cancellation-download-librarycancels.sh more robust. We use Monte-Carlo testing with a range of file sizes. Small file sizes should trigger the error case. (cherry picked from commit e4cba8f2b1a68e7361ce342ff659cccb0490446e)
* Escape special/non-printing characters in debug output (RHBZ#731744).Richard W.M. Jones2011-08-281-12/+42
| | | | | | | | | | | | | | | | | | | The default event handler in libguestfs was simply writing all debug output directly to stderr. However if the output contains non-printable characters such as terminal control codes then these would also be sent directly. With newer SeaBIOS there is a lame attempt to implement a splash screen using terminal control codes, thus when libguestfs tries to display debugging output it would cause the screen to clear and debug output to be lost. This commit causes all non-printing characters to be escaped. (\n and \r characters from the appliance are treated somewhat specially). Furthermore, instead of using write(2), use buffered stderr calls. (cherry picked from commit 06019bc82e107f7715ebc59e491610e06dad1e39)
* Remove guestfs___print_timestamped_argv.Richard W.M. Jones2011-08-283-48/+90
| | | | | | | | | | | | | | | | | | | | | | | | This function was used to print the qemu and febootstrap-supermin-helper command lines. Unfortunately in the qemu case it was used incorrectly: it called the internal debug function (ie. event API callback) from the forked qemu subprocess, which meant that higher level event callbacks might have been invoked from the child process. To fix this, convert the qemu case into a new function called print_qemu_command line which just prints the command line directly to stderr. This is called after stderr has been redirected into the pipe to the main process. Thus the qemu command line will be marshalled into the event API along with other qemu and appliance output. After fixing this, only one use of guestfs___print_timestamped_argv remained, for printing the febootstrap-supermin-helper command line. This is converted to a local function print_febootstrap_command_line. Also print_febootstrap_command_line is now called before we fork febootstrap-supermin-helper, so that messages no longer overlap. (cherry picked from commit 635af5be04265f845186b40e9a9fe7b102ad6909)
* out-of-tree build: generate ./run from template, fix image checksHilko Bengen2011-08-288-23/+23
| | | | | | | | ./run can now be run in a separate build directory. Since some files needed in the image checks are found in the source tree (but not the build tree), the source tree location is passed to make-*-img.sh via an environment variable. (cherry picked from commit 70c033998e0e721dc4f9eb2a20348098b259752c)
* fish: Add fish-cmds.h to generator_built.Richard W.M. Jones2011-08-280-0/+0
| | | | | This updates commit 3064277680ad11f887691646d0fa17bb35f38c19. (cherry picked from commit 85efbc6aa70d522af066a38fd1aae05b790c46d3)
* out-of-tree build: fix make and make installHilko Bengen2011-08-281-2/+2
| | | | | | $(srcdir) is not needed for guestfs_c.c. *.mli only exists in $(srcdir) and isn't found on "make install" otherwise (cherry picked from commit 0938e43a60f9d729d9795cf45498e60217fece0e)
* out-of-tree build: fix documentation generation IIHilko Bengen2011-08-281-2/+2
| | | | (cherry picked from commit 8876b2d3764b42ebae3c5fdf61b1899095508169)
* out-of-tree build: remove unneeded explicit pathsHilko Bengen2011-08-283-7/+7
| | | | (cherry picked from commit 4baec012b1b09a888e570fc89dbaa9fbf9944f34)
* Improve zeroing and detection of zeroes.Richard W.M. Jones2011-08-282-21/+70
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This code modifies zero, zero-device, is-zero, is-zero-device. zero and zero-device are modified so that if the blocks of the device already contain zeroes, then we don't write zeroes. The reason for this is to avoid unnecessarily making the underlying storage non-sparse or (in the qcow2 case) growing it. is-zero and is-zero-device are modified so that zero detection is faster. This is a nice side effect of making the first change. Since avoiding unnecessary zeroing involves reading the blocks before writing them, whereas before we just blindly wrote, this can be slower. As you can see from the tests below, in the case where the disk is sparse, it actually turns out to be faster, because we avoid allocating the underlying blocks. However in the case where the disk is non-sparse and full of existing data, it is much slower. There might be a case for an API flag to adjust whether or not we perform the zero check. I did not add this flag because it is unlikely that the caller would have enough information to be able to set the flag correctly. (Elapsed time in seconds) Format Test case Before After Raw Sparse 16.4 5.3 Preallocated zero 17.0 18.8 Preallocated random 16.0 41.3 Qcow2 preallocation=off 18.7 5.6 preallocation=metadata 17.4 5.8 The current code uses a fixed block size of 4K for reading and writing. I also tried the same tests with a block size of 64K but it didn't make any significant difference. (Thanks to Federico Simoncelli for suggesting this change) (cherry picked from commit 5a50c04906828f6e99db6a9be420c84114476d39)
* recipes: Remove two C file dependencies which are not actually used in the POD.Richard W.M. Jones2011-08-281-1/+1
| | | | (cherry picked from commit 1fdd0193fd63af71359748915a0326d623a3d6ad)
* out-of-tree build: fix building libraryHilko Bengen2011-08-281-3/+3
| | | | (cherry picked from commit 0241c753937e577d51a070f7db471260bf931f9c)
* out-of-tree build: Fix up OCaml bindings and generatorHilko Bengen2011-08-282-15/+15
| | | | (cherry picked from commit 900c9626b9d4f567b21aae433493b4b3b1d09f6d)
* out-of-tree build: fix applianceHilko Bengen2011-08-281-0/+1
| | | | (cherry picked from commit 36e0f35a5828458ebeaf72999b3461ab66a230d8)
* out-of-tree build: fix documentation generationHilko Bengen2011-08-2820-65/+66
| | | | (cherry picked from commit ff101adf7ead7bcdb46bccdb227ef18d844b965f)
* Version 1.12.4.1.12.4Richard W.M. Jones2011-08-1720-18293/+18334
|
* ruby: Fix typo in Ruby bindings file.Richard W.M. Jones2011-08-171-2/+2
| | | | (cherry picked from commit 44c3a300265ef7bfa5d49d2b9a2a8faccd9db2de)
* Note that additional memory may be required to typecheck Augeas lenses ↵Richard W.M. Jones2011-08-171-1/+6
| | | | | | (RHBZ#729887). (cherry picked from commit 7739d7f471f9575828bd32489695d92dde005a9c)
* fish: Document that remote run in cmd substitution context hangs.Richard W.M. Jones2011-08-171-0/+11
| | | | | This documents bug 592910. (cherry picked from commit 6cabc1cd02e181063596b48df55c3f6db51a6bb9)
* Fix 'unknown filesystem' warnings in old inspection code (RHBZ#678231 ↵Richard W.M. Jones2011-08-171-14/+20
| | | | | | | | | | | RHBZ#666578). This is a comprehensive fix for the warnings from the old (and obsolete) Perl inspection code. For a full description and reproducer, see: https://bugzilla.redhat.com/show_bug.cgi?id=678231#c5 (cherry picked from commit b9838001015a06a69a08b69d9f013d82f0ea3139)
* inspection: Better checking for Windows root disks (RHBZ#729075).Richard W.M. Jones2011-08-173-30/+75
| | | | | | | | | | | | | | | | | | Previously any disk that had /autoexec.bat or /boot.ini or /ntldr would be picked up as a candidate for a Windows root disk. If further checking could not find any systemroot (eg. /windows) then this would result in complete failure of inspection. In particular, this got confused by Hp_recovery partitions which have /autoexec.bat, but don't have a systemroot in one of the usual places (they have /MiniNT instead). What we do now is to properly investigate all possible systemroot places before deciding this is a Windows systemroot, so the subsequent failure cannot occur. (Thanks to lorimar for reporting this bug). (cherry picked from commit 2c57305f72cd6181d1849ae6e1b892aa01c7f844)
* build: Set TMPDIR for local testing.Richard W.M. Jones2011-08-1718-17/+44
| | | | | | | This avoids conflicts with the globally installed libguestfs appliance, or lets us build in multiple local directories at the same time without conflicts. (cherry picked from commit f7d18c84dde596699ffc5100fec2cf7b0d582450)
* fish: Add fish-cmds.h to generator_built.Richard W.M. Jones2011-08-171-0/+1
| | | | | This updates commit 3064277680ad11f887691646d0fa17bb35f38c19. (cherry picked from commit 85efbc6aa70d522af066a38fd1aae05b790c46d3)
* fish: Declare run_* functions in a generated header file.Richard W.M. Jones2011-08-174-41/+24
| | | | | | Calls to these functions are generated, so there is no need to declare the functions by hand. (cherry picked from commit 3064277680ad11f887691646d0fa17bb35f38c19)
* Version 1.12.3.1.12.3Richard W.M. Jones2011-08-0720-147/+404
|
* docs: Fix function names in deprecation notices.Richard W.M. Jones2011-08-072-4/+4
| | | | (cherry picked from commit 60adf092a8900323c048c94f3f0934be416a3eb6)
* docs: guestfs_set_out_of_memory_handler returns void, not int.Richard W.M. Jones2011-08-071-2/+2
| | | | | It always has done. The documentation was wrong. (cherry picked from commit 70f44cc0ea0bcdd025ed657461e07f6778be44ba)
* debian: bash is required to run libtool replacement script.Richard W.M. Jones2011-08-071-1/+1
| | | | | This was failing on Debian where $(SHELL) is the minimal dash shell. (cherry picked from commit 6a98ed953b1e3b0d3251385f0ca2dd1dee80b63d)
* configure: Fix info about virt-resize when OCaml bindings are disabled.Richard W.M. Jones2011-08-071-1/+1
| | | | (cherry picked from commit e1c6d1738a2b9123dd08fb4ecff8176daf558f35)
* python: Don't name extension with .so.0.0 and symlinks (thanks Dan Berrange).Richard W.M. Jones2011-08-071-0/+1
| | | | (cherry picked from commit 36f662c58fcda43829bcef166e600855960fd223)
* debian: Add gawk to packagelist.Richard W.M. Jones2011-08-071-0/+1
| | | | | It's already included, but implicitly. (cherry picked from commit 5f9c168d9135fa81ee2f3a15461467fe04c26888)
* virt-tar test: Stable ordering of test output.Richard W.M. Jones2011-08-071-1/+1
| | | | | | The files could be listed in any order, resulting in the test failing for no reason. Sort the output of tar. (cherry picked from commit 995b3fecb9af7a8bd52b238bad2a631a1193c83a)
* Change link, since PostgreSQL switched to using git.Richard W.M. Jones2011-08-071-1/+1
| | | | (cherry picked from commit 3cf31c2fe0b356ea5c04117c5235b0a3cfe34971)
generated by cgit (git 2.34.1) at 2025-08-30 15:54:30 +0000