diff options
| author | Richard Jones <rjones@trick.home.annexia.org> | 2009-08-19 09:37:44 +0100 |
|---|---|---|
| committer | Richard Jones <rjones@trick.home.annexia.org> | 2009-08-19 09:37:44 +0100 |
| commit | 8f1b06f64807239d4b4c923af4db8626a866ff6f (patch) | |
| tree | d797699b141b2e89ada4a7e583019b9a70685f7e /src/guestfs.c | |
| parent | e55c1fc51e0f9bb5da9b35b8915bd04401798d14 (diff) | |
| download | libguestfs-8f1b06f64807239d4b4c923af4db8626a866ff6f.tar.gz libguestfs-8f1b06f64807239d4b4c923af4db8626a866ff6f.tar.xz libguestfs-8f1b06f64807239d4b4c923af4db8626a866ff6f.zip | |
guestfs_launch: Correct checks for dup failure.
Diffstat (limited to 'src/guestfs.c')
| -rw-r--r-- | src/guestfs.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/src/guestfs.c b/src/guestfs.c index 58a03544..04bd4e88 100644 --- a/src/guestfs.c +++ b/src/guestfs.c @@ -1165,16 +1165,16 @@ guestfs_launch (guestfs_h *g) close (wfd[1]); close (rfd[0]); - int fail = 0; - fail |= dup (wfd[0]); - fail |= dup (rfd[1]); - close (wfd[0]); - close (rfd[1]); - - if (fail) { + if (dup (wfd[0]) == -1) { + dup_failed: perror ("dup failed"); _exit (1); } + if (dup (rfd[1]) == -1) + goto dup_failed; + + close (wfd[0]); + close (rfd[1]); #if 0 /* Set up a new process group, so we can signal this process |