guestfs_ls: Reimplement to avoid protocol limits.

1 files changed, 102 insertions, 0 deletions

diff --git a/src/file.c b/src/file.c
index 71b208d3..9257b857 100644
--- a/src/file.c
+++ b/src/file.c
@@ -535,3 +535,105 @@ guestfs__readlinklist (guestfs_h *g, const char *dir, char *const *names)
 
   return ret;
 }
+
+char **
+guestfs__ls (guestfs_h *g, const char *directory)
+{
+  int fd = -1;
+  struct stat statbuf;
+  char *tmpfile = NULL, *buf = NULL;
+  char **ret = NULL;
+  size_t i, count, size;
+
+  tmpfile = safe_asprintf (g, "%s/ls%d", g->tmpdir, ++g->unique);
+
+  if (guestfs_ls0 (g, directory, tmpfile) == -1)
+    goto err;
+
+  fd = open (tmpfile, O_RDONLY|O_CLOEXEC);
+  if (fd == -1) {
+    perrorf (g, "open: %s", tmpfile);
+    goto err;
+  }
+
+  unlink (tmpfile);
+  free (tmpfile);
+  tmpfile = NULL;
+
+  /* Read the whole file into memory. */
+  if (fstat (fd, &statbuf) == -1) {
+    perrorf (g, "stat: %s", tmpfile);
+    goto err;
+  }
+
+  /* Don't use safe_malloc, because we want to return an errno to the caller. */
+  size = statbuf.st_size;
+  buf = malloc (size);
+  if (!buf) {
+    perrorf (g, "malloc: %zu bytes", size);
+    goto err;
+  }
+
+  if (full_read (fd, buf, size) != size) {
+    perrorf (g, "full-read: %s: %zu bytes", tmpfile, size);
+    goto err;
+  }
+
+  if (close (fd) == -1) {
+    perrorf (g, "close: %s", tmpfile);
+    goto err;
+  }
+  fd = -1;
+
+  /* 'buf' contains the list of strings, separated (and terminated) by
+   * '\0' characters.  Convert this to a list of lines.  Note we
+   * handle the case where buf is completely empty (size == 0).
+   */
+  count = 0;
+  for (i = 0; i < size; ++i)
+    if (buf[i] == '\0')
+      count++;
+
+  ret = malloc ((count + 1) * sizeof (char *));
+  if (!ret) {
+    perrorf (g, "malloc");
+    goto err;
+  }
+
+  count = 0;
+  ret[count++] = buf;
+  for (i = 0; i < size; ++i) {
+    if (buf[i] == '\0')
+      ret[count++] = &buf[i+1];
+  }
+  ret[--count] = NULL;
+
+  /* Finally we have to duplicate and sort the strings, since that's
+   * what the caller is expecting.
+   */
+  for (i = 0; ret[i] != NULL; ++i) {
+    ret[i] = strdup (ret[i]);
+    if (ret[i] == NULL) {
+      perrorf (g, "strdup");
+      while (i > 0)
+        free (ret[--i]);
+      goto err;
+    }
+  }
+  free (buf);
+
+  sort_strings (ret, count);
+
+  return ret;                   /* caller frees */
+
+ err:
+  free (buf);
+  free (ret);
+  if (fd >= 0)
+    close (fd);
+  if (tmpfile) {
+    unlink (tmpfile);
+    free (tmpfile);
+  }
+  return NULL;
+}