diff options
| author | Richard Jones <rjones@redhat.com> | 2010-02-09 18:00:24 +0000 |
|---|---|---|
| committer | Richard Jones <rjones@redhat.com> | 2010-02-10 10:46:23 +0000 |
| commit | f93cbe5756cf052cce8049087afdcf714a3fc70c (patch) | |
| tree | c8caeeeb48f4293aa3aa7781fa3ae013b146728a /regressions | |
| parent | 245ac5673700f54479e9408e8659cb68f80c344a (diff) | |
| download | libguestfs-f93cbe5756cf052cce8049087afdcf714a3fc70c.tar.gz libguestfs-f93cbe5756cf052cce8049087afdcf714a3fc70c.tar.xz libguestfs-f93cbe5756cf052cce8049087afdcf714a3fc70c.zip | |
Use mount-options instead of mount to avoid implicit -o sync.
guestfs_mount adds -o sync implicitly. This causes a very large
performance problem for write-intensive programs (eg. virt-v2v).
Document this as a "gotcha".
Change the tests, guestfish, Sys::Guestfs::Lib, guestmount to use
mount-options instead.
(Note that this gotcha does not affect mount-ro).
The source of the performance problem was first identified by
Matthew Booth.
Diffstat (limited to 'regressions')
| -rwxr-xr-x | regressions/rhbz503169c10.sh | 2 | ||||
| -rwxr-xr-x | regressions/rhbz503169c13.sh | 2 | ||||
| -rwxr-xr-x | regressions/test-cancellation-upload-daemoncancels.sh | 2 | ||||
| -rwxr-xr-x | regressions/test-remote.sh | 2 |
4 files changed, 4 insertions, 4 deletions
diff --git a/regressions/rhbz503169c10.sh b/regressions/rhbz503169c10.sh index 5cf70699..0a327495 100755 --- a/regressions/rhbz503169c10.sh +++ b/regressions/rhbz503169c10.sh @@ -28,7 +28,7 @@ dd if=/dev/zero of=test1.img bs=1024k count=10 launch part-disk /dev/sda mbr mkfs ext2 /dev/sda1 -mount /dev/sda1 / +mount-options "" /dev/sda1 / ll /../dev/console ll /../dev/full ll /../dev/mapper/ diff --git a/regressions/rhbz503169c13.sh b/regressions/rhbz503169c13.sh index d360d5c2..f7ad9e43 100755 --- a/regressions/rhbz503169c13.sh +++ b/regressions/rhbz503169c13.sh @@ -33,7 +33,7 @@ dd if=/dev/zero of=test1.img bs=1024k count=10 run part-disk /dev/sda mbr mkfs ext2 /dev/sda1 -mount /dev/sda1 / +mount-options "" /dev/sda1 / mkdir /dev -command /ignore-this-error unmount-all diff --git a/regressions/test-cancellation-upload-daemoncancels.sh b/regressions/test-cancellation-upload-daemoncancels.sh index 296d3686..4962c255 100755 --- a/regressions/test-cancellation-upload-daemoncancels.sh +++ b/regressions/test-cancellation-upload-daemoncancels.sh @@ -30,7 +30,7 @@ run part-disk /dev/sda mbr mkfs ext2 /dev/sda1 -mount /dev/sda1 / +mount-options "" /dev/sda1 / # Upload image, daemon should cancel because the image is too large # to upload into itself. diff --git a/regressions/test-remote.sh b/regressions/test-remote.sh index d778a07a..40c2ee9a 100755 --- a/regressions/test-remote.sh +++ b/regressions/test-remote.sh @@ -28,7 +28,7 @@ eval `../fish/guestfish --listen` ../fish/guestfish --remote run ../fish/guestfish --remote part-disk /dev/sda mbr ../fish/guestfish --remote mkfs ext2 /dev/sda1 -../fish/guestfish --remote mount /dev/sda1 / +../fish/guestfish --remote mount-options "" /dev/sda1 / # Failure of the above commands will cause the guestfish listener to exit. # Incorrect return from echo_daemon will not, so need to ensure the listener |