summaryrefslogtreecommitdiffstats
path: root/python/t/050-lvcreate.py
diff options
context:
space:
mode:
authorRichard W.M. Jones <rjones@redhat.com>2012-09-28 10:15:13 +0100
committerRichard W.M. Jones <rjones@redhat.com>2012-10-01 15:07:05 +0100
commit1b2a2d596c01806fdafe689368bc065865bd5d57 (patch)
treeef23845732a3ade05af195a6bfd38f6b777acbd1 /python/t/050-lvcreate.py
parentc618a5137308b5aef0047fce252374cf4a168ac3 (diff)
downloadlibguestfs-1b2a2d596c01806fdafe689368bc065865bd5d57.tar.gz
libguestfs-1b2a2d596c01806fdafe689368bc065865bd5d57.tar.xz
libguestfs-1b2a2d596c01806fdafe689368bc065865bd5d57.zip
inspection: Fix calls to case_sensitive_path (RHBZ#858126).
Don't assume that if guestfs_case_sensitive_path returns NULL, that it means the file does not exist. The (previously undefined) behaviour of case_sensitive_path was that a NULL return meant "either the file doesn't exist or some other error". However in commit 973581780d8a006f336684fef6762801402d775d this was changed so that if the last element of the path didn't exist, it was assumed to be a new file and the (non-NULL) path of the new file is returned. This change breaks code (including in libguestfs) which tries to use case_sensitive_path as a dual-purpose call to fix-up a path for Windows and test if the file exists. Such code should be rewritten so that it explicitly tests for file existence after calling case_sensitive_path. I examined all the calls to case_sensitive_path in libguestfs and modified them where necessary. Cherry picked from commit 9ea6e9701461e594033999150f930cc4fafec4d2. (cherry picked from commit ff610469fb8ad1d27dac5d3cb2f1e007d8c0ecc7)
Diffstat (limited to 'python/t/050-lvcreate.py')
0 files changed, 0 insertions, 0 deletions