summaryrefslogtreecommitdiffstats
path: root/python/run-python-tests
diff options
context:
space:
mode:
authorRichard Jones <rjones@redhat.com>2010-06-08 16:44:18 +0100
committerRichard Jones <rjones@redhat.com>2010-07-12 08:34:25 +0100
commit2373ba34c24f6efcf287042feaa7664d423f63c7 (patch)
tree6aed67ab3a6157965c5174e96af1af2847296d15 /python/run-python-tests
parent3b1f3d64dedcfffde2b7ae40d48244c24d5bbd71 (diff)
downloadlibguestfs-2373ba34c24f6efcf287042feaa7664d423f63c7.tar.gz
libguestfs-2373ba34c24f6efcf287042feaa7664d423f63c7.tar.xz
libguestfs-2373ba34c24f6efcf287042feaa7664d423f63c7.zip
virt-df: Disallow -h and --csv options together (RHBZ#600977).
Before this commit, if you used the -h and --csv options together you would get these warnings from virt-df: $ virt-df -h --csv Guest Virtual Machine,Filesystem,Size,Used,Available,Use% Argument "13.5G" isn't numeric in printf at /home/rjones/d/libguestfs/tools/virt-df line 298. Argument "4.7G" isn't numeric in printf at /home/rjones/d/libguestfs/tools/virt-df line 298. Argument "8.1G" isn't numeric in printf at /home/rjones/d/libguestfs/tools/virt-df line 298. "/dev/vg_trick/RHEL55x64","/dev/VolGroup00/LogVol00",13,4,8,34.8% Argument "98.7M" isn't numeric in printf at /home/rjones/d/libguestfs/tools/virt-df line 298. Argument "18.8M" isn't numeric in printf at /home/rjones/d/libguestfs/tools/virt-df line 298. Argument "74.9M" isn't numeric in printf at /home/rjones/d/libguestfs/tools/virt-df line 298. "/dev/vg_trick/RHEL55x64","/dev/vda1",98,18,74,19.0% We could fix this so that the human-readable numbers get written into the CSV file. However would probably be wrong for most uses of the CSV format (databases and spreadsheets) since they would not be able to interpret these human-readable numbers, or worse could misinterpret, eg. thinking that "1M" and "1G" are both 1. Therefore this commit disallows this combination of options. (cherry picked from commit aaf03a51a26ee501f5dbf2720bbb8a5e3b4e1e6b)
Diffstat (limited to 'python/run-python-tests')
0 files changed, 0 insertions, 0 deletions