diff options
author | Richard W.M. Jones <rjones@redhat.com> | 2011-10-01 08:20:50 +0100 |
---|---|---|
committer | Richard W.M. Jones <rjones@redhat.com> | 2011-10-01 08:20:50 +0100 |
commit | 5c2f1a2d9433eeb5aebeec26f0412c703bbe7269 (patch) | |
tree | e85c23ac34c149df558b537d576361aa84401417 /generator | |
parent | 4e9ed018475ff4bd5171ed50a47ffae7abbdda4b (diff) | |
download | libguestfs-5c2f1a2d9433eeb5aebeec26f0412c703bbe7269.tar.gz libguestfs-5c2f1a2d9433eeb5aebeec26f0412c703bbe7269.tar.xz libguestfs-5c2f1a2d9433eeb5aebeec26f0412c703bbe7269.zip |
mount: No longer implicitly add -o sync,noatime options.
Diffstat (limited to 'generator')
-rw-r--r-- | generator/generator_actions.ml | 15 |
1 files changed, 6 insertions, 9 deletions
diff --git a/generator/generator_actions.ml b/generator/generator_actions.ml index 8d03275f..49146873 100644 --- a/generator/generator_actions.ml +++ b/generator/generator_actions.ml @@ -1595,15 +1595,12 @@ exist. The mounted filesystem is writable, if we have sufficient permissions on the underlying device. -B<Important note:> -When you use this call, the filesystem options C<sync> and C<noatime> -are set implicitly. This was originally done because we thought it -would improve reliability, but it turns out that I<-o sync> has a -very large negative performance impact and negligible effect on -reliability. Therefore we recommend that you avoid using -C<guestfs_mount> in any code that needs performance, and instead -use C<guestfs_mount_options> (use an empty string for the first -parameter if you don't want any options)."); +Before libguestfs 1.13.16, this call implicitly added the options +C<sync> and C<noatime>. The C<sync> option greatly slowed +writes and caused many problems for users. If your program +might need to work with older versions of libguestfs, use +C<guestfs_mount_options> instead (using an empty string for the +first parameter if you don't want any options)."); ("sync", (RErr, [], []), 2, [], [ InitEmpty, Always, TestRun [["sync"]]], |