diff options
| author | Richard W.M. Jones <rjones@redhat.com> | 2009-07-01 17:13:39 +0100 |
|---|---|---|
| committer | Richard W.M. Jones <rjones@redhat.com> | 2009-07-01 17:13:39 +0100 |
| commit | 3e2d925717d1dac6b3862e98192c12d1080c2152 (patch) | |
| tree | 85ccb80f7b245ab68b09f3bdc3675c3f89b2182f /daemon | |
| parent | fe27753ae5925cbe50042e47115364a57aadbbd7 (diff) | |
| download | libguestfs-3e2d925717d1dac6b3862e98192c12d1080c2152.tar.gz libguestfs-3e2d925717d1dac6b3862e98192c12d1080c2152.tar.xz libguestfs-3e2d925717d1dac6b3862e98192c12d1080c2152.zip | |
All instances of 'pclose' now check for return value != 0.
We are generally interested that the subcommand ran without
error, ie. had exit status of 0. 'pclose' returns the exit
status, so we now check that pclose (fp) != 0.
Diffstat (limited to 'daemon')
| -rw-r--r-- | daemon/find.c | 2 | ||||
| -rw-r--r-- | daemon/initrd.c | 2 | ||||
| -rw-r--r-- | daemon/tar.c | 8 |
3 files changed, 6 insertions, 6 deletions
diff --git a/daemon/find.c b/daemon/find.c index 287aae39..7ceeafaf 100644 --- a/daemon/find.c +++ b/daemon/find.c @@ -113,7 +113,7 @@ do_find (char *dir) return NULL; } } - if (pclose (fp) == -1) { + if (pclose (fp) != 0) { reply_with_perror ("pclose: find"); free_stringslen (res, size); return NULL; diff --git a/daemon/initrd.c b/daemon/initrd.c index 513ed8da..2d6cbdde 100644 --- a/daemon/initrd.c +++ b/daemon/initrd.c @@ -78,7 +78,7 @@ do_initrd_list (char *path) return NULL; } - if (pclose (fp) == -1) { + if (pclose (fp) != 0) { reply_with_perror ("pclose"); free_strings (filenames); return NULL; diff --git a/daemon/tar.c b/daemon/tar.c index 4d9feaa0..0320604c 100644 --- a/daemon/tar.c +++ b/daemon/tar.c @@ -88,7 +88,7 @@ do_tar_in (char *dir) return -1; } - if (pclose (fp) == -1) { + if (pclose (fp) != 0) { err = errno; cancel_receive (); errno = err; @@ -150,7 +150,7 @@ do_tar_out (char *dir) return -1; } - if (pclose (fp) == -1) { + if (pclose (fp) != 0) { perror (dir); send_file_end (1); /* Cancel. */ return -1; @@ -214,7 +214,7 @@ do_tgz_in (char *dir) return -1; } - if (pclose (fp) == -1) { + if (pclose (fp) != 0) { err = errno; cancel_receive (); errno = err; @@ -276,7 +276,7 @@ do_tgz_out (char *dir) return -1; } - if (pclose (fp) == -1) { + if (pclose (fp) != 0) { perror (dir); send_file_end (1); /* Cancel. */ return -1; |