summaryrefslogtreecommitdiffstats
path: root/daemon
diff options
context:
space:
mode:
authorRichard Jones <rjones@redhat.com>2010-08-28 14:29:21 +0100
committerRichard Jones <rjones@redhat.com>2010-09-01 10:00:40 +0100
commit133a92be6948ff7e65bfecb7be70b15f4336d2af (patch)
tree048279fc10cb5fbd740fabd7dce63477bcc9ac01 /daemon
parent88ab203e611694bc0d01aca745e8df18cb3f094e (diff)
downloadlibguestfs-133a92be6948ff7e65bfecb7be70b15f4336d2af.tar.gz
libguestfs-133a92be6948ff7e65bfecb7be70b15f4336d2af.tar.xz
libguestfs-133a92be6948ff7e65bfecb7be70b15f4336d2af.zip
Add progress messages to zero-device command.
Diffstat (limited to 'daemon')
-rw-r--r--daemon/zero.c21
1 files changed, 16 insertions, 5 deletions
diff --git a/daemon/zero.c b/daemon/zero.c
index 43089e0b..8fbd963d 100644
--- a/daemon/zero.c
+++ b/daemon/zero.c
@@ -62,9 +62,10 @@ do_zero (const char *device)
int
do_zero_device (const char *device)
{
- int64_t size = do_blockdev_getsize64 (device);
- if (size == -1)
+ int64_t ssize = do_blockdev_getsize64 (device);
+ if (ssize == -1)
return -1;
+ uint64_t size = (uint64_t) ssize;
int fd = open (device, O_WRONLY);
if (fd == -1) {
@@ -75,8 +76,16 @@ do_zero_device (const char *device)
char buf[1024*1024];
memset (buf, 0, sizeof buf);
- while (size > 0) {
- size_t n = (size_t) size > sizeof buf ? sizeof buf : (size_t) size;
+ uint64_t pos = 0;
+
+ while (pos < size) {
+ uint64_t n64 = size - pos;
+ size_t n;
+ if (n64 > sizeof buf)
+ n = sizeof buf;
+ else
+ n = (size_t) n64; /* safe because of if condition */
+
ssize_t r = write (fd, buf, n);
if (r == -1) {
reply_with_perror ("write: %s (with %" PRId64 " bytes left to write)",
@@ -84,7 +93,9 @@ do_zero_device (const char *device)
close (fd);
return -1;
}
- size -= r;
+
+ pos += r;
+ notify_progress (pos, size);
}
if (close (fd) == -1) {