diff options
| author | Richard Jones <rjones@redhat.com> | 2010-04-17 13:33:14 +0100 |
|---|---|---|
| committer | Richard Jones <rjones@redhat.com> | 2010-04-17 13:36:26 +0100 |
| commit | 61ab83d19009a8006dd73ebe16d22494b78be4d1 (patch) | |
| tree | ad14a0f005867ceea391da618792c59c9b395728 /daemon/mknod.c | |
| parent | 42fc0e02b094ef3b19dae115276a0a33116af6d5 (diff) | |
| download | libguestfs-61ab83d19009a8006dd73ebe16d22494b78be4d1.tar.gz libguestfs-61ab83d19009a8006dd73ebe16d22494b78be4d1.tar.xz libguestfs-61ab83d19009a8006dd73ebe16d22494b78be4d1.zip | |
Improved checking, documentation of modes (RHBZ#582901, RHBZ#582929).
chmod: Disallow negative mode, document mode affected by umask.
mkdir-mode: Disallow negative mode, document that filesystems
may interpret the mode in different ways.
mknod: Disallow negative mode, document mode affected by umask.
umask: Check the range of umask mask value carefully.
Diffstat (limited to 'daemon/mknod.c')
| -rw-r--r-- | daemon/mknod.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/daemon/mknod.c b/daemon/mknod.c index 50865a62..2458a851 100644 --- a/daemon/mknod.c +++ b/daemon/mknod.c @@ -51,6 +51,11 @@ do_mknod (int mode, int devmajor, int devminor, const char *path) #ifdef HAVE_MKNOD int r; + if (mode < 0) { + reply_with_error ("%s: mode is negative", path); + return -1; + } + CHROOT_IN; r = mknod (path, mode, makedev (devmajor, devminor)); CHROOT_OUT; |